From: <Wenyou.Yang@microchip.com> To: <alexandre.belloni@free-electrons.com>, <linux@roeck-us.net> Cc: <wim@iguana.be>, <Nicolas.Ferre@microchip.com>, <linux-watchdog@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 2/4] watchdog: sama5d4: fix race condition Date: Tue, 7 Mar 2017 02:06:33 +0000 [thread overview] Message-ID: <F9F4555C4E01D7469D37975B62D0EFBB4FC519@CHN-SV-EXMX07.mchp-main.com> (raw) In-Reply-To: <20170302173114.28508-3-alexandre.belloni@free-electrons.com> > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: 2017年3月3日 1:31 > To: Guenter Roeck <linux@roeck-us.net> > Cc: Wim Van Sebroeck <wim@iguana.be>; Nicolas Ferre - M43238 > <Nicolas.Ferre@microchip.com>; Wenyou Yang - A41535 > <Wenyou.Yang@microchip.com>; linux-watchdog@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Alexandre Belloni > <alexandre.belloni@free-electrons.com> > Subject: [PATCH 2/4] watchdog: sama5d4: fix race condition > > WDT_MR and WDT_CR must not updated within three slow clock periods after > the last ping (write to WDT_CR or WDT_MR). Ensure enough time has elapsed > before writing those registers. > wdt_write() waits for 4 periods to ensure at least 3 edges are seen by the IP. Indeed. Acked-by: Wenyou.Yang <wenyou.yang@microchip.com> Thanks > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > drivers/watchdog/sama5d4_wdt.c | 33 +++++++++++++++++++++++++++++---- > 1 file changed, 29 insertions(+), 4 deletions(-) > > diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c > index 5cee20caca78..362fd229786d 100644 > --- a/drivers/watchdog/sama5d4_wdt.c > +++ b/drivers/watchdog/sama5d4_wdt.c > @@ -6,6 +6,7 @@ > * Licensed under GPLv2. > */ > > +#include <linux/delay.h> > #include <linux/interrupt.h> > #include <linux/io.h> > #include <linux/kernel.h> > @@ -29,6 +30,7 @@ struct sama5d4_wdt { > struct watchdog_device wdd; > void __iomem *reg_base; > u32 mr; > + unsigned long last_ping; > }; > > static int wdt_timeout = WDT_DEFAULT_TIMEOUT; @@ -49,8 +51,29 @@ > MODULE_PARM_DESC(nowayout, #define wdt_read(wdt, field) \ > readl_relaxed((wdt)->reg_base + (field)) > > -#define wdt_write(wtd, field, val) \ > - writel_relaxed((val), (wdt)->reg_base + (field)) > +/* 4 slow clock periods is 4/32768 = 122.07µs*/ > +#define WDT_DELAY usecs_to_jiffies(123) > + > +static void wdt_write(struct sama5d4_wdt *wdt, u32 field, u32 val) { > + /* > + * WDT_CR and WDT_MR must not be modified within three slow clock > + * periods following a restart of the watchdog performed by a write > + * access in WDT_CR. > + */ > + while (time_before(jiffies, wdt->last_ping + WDT_DELAY)) > + usleep_range(30, 125); > + writel_relaxed(val, wdt->reg_base + field); > + wdt->last_ping = jiffies; > +} > + > +static void wdt_write_nosleep(struct sama5d4_wdt *wdt, u32 field, u32 > +val) { > + if (time_before(jiffies, wdt->last_ping + WDT_DELAY)) > + udelay(123); > + writel_relaxed(val, wdt->reg_base + field); > + wdt->last_ping = jiffies; > +} > > static int sama5d4_wdt_start(struct watchdog_device *wdd) { @@ -164,11 > +187,12 @@ static int sama5d4_wdt_init(struct sama5d4_wdt *wdt) > * Else, we have to disable it properly. > */ > if (wdt_enabled) { > - wdt_write(wdt, AT91_WDT_MR, wdt->mr); > + wdt_write_nosleep(wdt, AT91_WDT_MR, wdt->mr); > } else { > reg = wdt_read(wdt, AT91_WDT_MR); > if (!(reg & AT91_WDT_WDDIS)) > - wdt_write(wdt, AT91_WDT_MR, reg | > AT91_WDT_WDDIS); > + wdt_write_nosleep(wdt, AT91_WDT_MR, > + reg | AT91_WDT_WDDIS); > } > return 0; > } > @@ -193,6 +217,7 @@ static int sama5d4_wdt_probe(struct platform_device > *pdev) > wdd->ops = &sama5d4_wdt_ops; > wdd->min_timeout = MIN_WDT_TIMEOUT; > wdd->max_timeout = MAX_WDT_TIMEOUT; > + wdt->last_ping = jiffies; > > watchdog_set_drvdata(wdd, wdt); > > -- > 2.11.0 Best Regards, Wenyou Yang
WARNING: multiple messages have this Message-ID (diff)
From: Wenyou.Yang@microchip.com (Wenyou.Yang at microchip.com) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/4] watchdog: sama5d4: fix race condition Date: Tue, 7 Mar 2017 02:06:33 +0000 [thread overview] Message-ID: <F9F4555C4E01D7469D37975B62D0EFBB4FC519@CHN-SV-EXMX07.mchp-main.com> (raw) In-Reply-To: <20170302173114.28508-3-alexandre.belloni@free-electrons.com> > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com] > Sent: 2017?3?3? 1:31 > To: Guenter Roeck <linux@roeck-us.net> > Cc: Wim Van Sebroeck <wim@iguana.be>; Nicolas Ferre - M43238 > <Nicolas.Ferre@microchip.com>; Wenyou Yang - A41535 > <Wenyou.Yang@microchip.com>; linux-watchdog at vger.kernel.org; linux-arm- > kernel at lists.infradead.org; linux-kernel at vger.kernel.org; Alexandre Belloni > <alexandre.belloni@free-electrons.com> > Subject: [PATCH 2/4] watchdog: sama5d4: fix race condition > > WDT_MR and WDT_CR must not updated within three slow clock periods after > the last ping (write to WDT_CR or WDT_MR). Ensure enough time has elapsed > before writing those registers. > wdt_write() waits for 4 periods to ensure at least 3 edges are seen by the IP. Indeed. Acked-by: Wenyou.Yang <wenyou.yang@microchip.com> Thanks > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > drivers/watchdog/sama5d4_wdt.c | 33 +++++++++++++++++++++++++++++---- > 1 file changed, 29 insertions(+), 4 deletions(-) > > diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c > index 5cee20caca78..362fd229786d 100644 > --- a/drivers/watchdog/sama5d4_wdt.c > +++ b/drivers/watchdog/sama5d4_wdt.c > @@ -6,6 +6,7 @@ > * Licensed under GPLv2. > */ > > +#include <linux/delay.h> > #include <linux/interrupt.h> > #include <linux/io.h> > #include <linux/kernel.h> > @@ -29,6 +30,7 @@ struct sama5d4_wdt { > struct watchdog_device wdd; > void __iomem *reg_base; > u32 mr; > + unsigned long last_ping; > }; > > static int wdt_timeout = WDT_DEFAULT_TIMEOUT; @@ -49,8 +51,29 @@ > MODULE_PARM_DESC(nowayout, #define wdt_read(wdt, field) \ > readl_relaxed((wdt)->reg_base + (field)) > > -#define wdt_write(wtd, field, val) \ > - writel_relaxed((val), (wdt)->reg_base + (field)) > +/* 4 slow clock periods is 4/32768 = 122.07?s*/ > +#define WDT_DELAY usecs_to_jiffies(123) > + > +static void wdt_write(struct sama5d4_wdt *wdt, u32 field, u32 val) { > + /* > + * WDT_CR and WDT_MR must not be modified within three slow clock > + * periods following a restart of the watchdog performed by a write > + * access in WDT_CR. > + */ > + while (time_before(jiffies, wdt->last_ping + WDT_DELAY)) > + usleep_range(30, 125); > + writel_relaxed(val, wdt->reg_base + field); > + wdt->last_ping = jiffies; > +} > + > +static void wdt_write_nosleep(struct sama5d4_wdt *wdt, u32 field, u32 > +val) { > + if (time_before(jiffies, wdt->last_ping + WDT_DELAY)) > + udelay(123); > + writel_relaxed(val, wdt->reg_base + field); > + wdt->last_ping = jiffies; > +} > > static int sama5d4_wdt_start(struct watchdog_device *wdd) { @@ -164,11 > +187,12 @@ static int sama5d4_wdt_init(struct sama5d4_wdt *wdt) > * Else, we have to disable it properly. > */ > if (wdt_enabled) { > - wdt_write(wdt, AT91_WDT_MR, wdt->mr); > + wdt_write_nosleep(wdt, AT91_WDT_MR, wdt->mr); > } else { > reg = wdt_read(wdt, AT91_WDT_MR); > if (!(reg & AT91_WDT_WDDIS)) > - wdt_write(wdt, AT91_WDT_MR, reg | > AT91_WDT_WDDIS); > + wdt_write_nosleep(wdt, AT91_WDT_MR, > + reg | AT91_WDT_WDDIS); > } > return 0; > } > @@ -193,6 +217,7 @@ static int sama5d4_wdt_probe(struct platform_device > *pdev) > wdd->ops = &sama5d4_wdt_ops; > wdd->min_timeout = MIN_WDT_TIMEOUT; > wdd->max_timeout = MAX_WDT_TIMEOUT; > + wdt->last_ping = jiffies; > > watchdog_set_drvdata(wdd, wdt); > > -- > 2.11.0 Best Regards, Wenyou Yang
next prev parent reply other threads:[~2017-03-07 2:08 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-02 17:31 [PATCH 0/4] watchdog: sama5d4: fix issues Alexandre Belloni 2017-03-02 17:31 ` Alexandre Belloni 2017-03-02 17:31 ` [PATCH 1/4] watchdog: sama5d4: fix WDDIS handling Alexandre Belloni 2017-03-02 17:31 ` Alexandre Belloni 2017-03-04 15:04 ` Guenter Roeck 2017-03-04 15:04 ` Guenter Roeck 2017-03-07 2:05 ` Wenyou.Yang 2017-03-07 2:05 ` Wenyou.Yang at microchip.com 2017-03-02 17:31 ` [PATCH 2/4] watchdog: sama5d4: fix race condition Alexandre Belloni 2017-03-02 17:31 ` Alexandre Belloni 2017-03-02 17:42 ` Guenter Roeck 2017-03-02 17:42 ` Guenter Roeck 2017-03-02 17:54 ` Alexandre Belloni 2017-03-02 17:54 ` Alexandre Belloni 2017-03-04 15:05 ` Guenter Roeck 2017-03-04 15:05 ` Guenter Roeck 2017-03-07 2:06 ` Wenyou.Yang [this message] 2017-03-07 2:06 ` Wenyou.Yang at microchip.com 2017-03-02 17:31 ` [PATCH 3/4] watchodg: sama5d4: simplify probe Alexandre Belloni 2017-03-02 17:31 ` Alexandre Belloni 2017-03-02 19:29 ` Alexander Dahl 2017-03-02 19:29 ` Alexander Dahl 2017-03-03 8:03 ` Thomas Petazzoni 2017-03-03 8:03 ` Thomas Petazzoni 2017-03-03 9:29 ` Alexandre Belloni 2017-03-03 9:29 ` Alexandre Belloni 2017-03-03 14:14 ` Guenter Roeck 2017-03-03 14:14 ` Guenter Roeck 2017-03-04 15:06 ` Guenter Roeck 2017-03-04 15:06 ` Guenter Roeck 2017-03-02 17:31 ` [PATCH 4/4] watchdog: sama5d4: Add comment explaining what happens on resume Alexandre Belloni 2017-03-02 17:31 ` Alexandre Belloni 2017-03-04 15:07 ` Guenter Roeck 2017-03-04 15:07 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F9F4555C4E01D7469D37975B62D0EFBB4FC519@CHN-SV-EXMX07.mchp-main.com \ --to=wenyou.yang@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.