From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Drew Fustini <drew@beagleboard.org>,
Patrick Menschel <menschel.p@posteo.de>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org, Josh S <josh@macchina.cc>
Subject: Re: mcp251xfd on RPi 5.4 downstream
Date: Mon, 2 Nov 2020 08:25:34 +0100 [thread overview]
Message-ID: <7b0920d7-50c5-ff40-033c-57aca5a992bd@pengutronix.de> (raw)
In-Reply-To: <CAPgEAj7LT48tVa47p-5+5=sb+J=Ff61pdhcOa=70ppPvCMeDzw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1626 bytes --]
On 11/1/20 11:49 PM, Drew Fustini wrote:
>>>> Try these lines in /boot/config.txt
>>>>
>>>> dtoverlay=mcp251xfd-spi0-0,interrupt=25
>>>> dtoverlay=mcp251xfd-spi1-0,interrupt=16
If you use the above lines ^^, the patching of the overlay should not be necessary:
> I changed this in mcp251xfd-spi1-0-overlay.dts:
> - interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
[...]
> pi@raspberrypi:~$ dmesg | grep -Ei can\|spi
> [ 14.663345] CAN device driver interface
> [ 14.669552] spi_master spi0: will run message pump with realtime priority
> [ 14.677102] mcp251xfd spi0.0 can0: MCP2517FD rev0.0 (-RX_INT
> +MAB_NO_WARN +CRC_REG +CRC_RX +CRC_TX +ECC -HD c:40.00MHz m:20.00MHz
> r:17.00MHz e:0.00MHz) successfully initialized.
> [ 14.677833] spi_master spi1: will run message pump with realtime priority
> [ 14.682667] mcp251xfd spi1.0 can1: MCP2517FD rev0.0 (-RX_INT
> +MAB_NO_WARN +CRC_REG +CRC_RX +CRC_TX +ECC -HD c:40.00MHz m:20.00MHz
> r:17.00MHz e:0.00MHz) successfully initialized.
Note: the waveshare module uses a mcp2517fd, which has some erratas. You will
experience error frames generated by sending mcp2517fd modules, during certain
conditions. Sometimes CAN frames in the RX path are dropped.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-02 7:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 3:10 mcp251xfd on RPi 5.4 downstream Drew Fustini
2020-10-22 6:00 ` Drew Fustini
2020-10-22 6:33 ` Marc Kleine-Budde
2020-10-22 18:42 ` Drew Fustini
2020-10-25 4:30 ` Drew Fustini
2020-10-25 8:49 ` Oliver Hartkopp
2020-10-25 10:58 ` Marc Kleine-Budde
2020-10-25 17:43 ` Patrick Menschel
2020-10-25 18:14 ` Marc Kleine-Budde
2020-10-25 18:42 ` Patrick Menschel
2020-10-26 1:59 ` Drew Fustini
2020-10-26 2:50 ` Drew Fustini
2020-10-26 5:16 ` Patrick Menschel
2020-10-26 7:45 ` Marc Kleine-Budde
2020-10-26 9:40 ` Marc Kleine-Budde
2020-10-26 16:51 ` Patrick Menschel
2020-10-26 17:00 ` Marc Kleine-Budde
2020-10-27 2:22 ` Drew Fustini
2020-10-27 6:35 ` Drew Fustini
2020-10-27 7:06 ` Marc Kleine-Budde
2020-10-27 18:18 ` Patrick Menschel
2020-10-27 18:22 ` Marc Kleine-Budde
2020-10-28 1:57 ` Drew Fustini
2020-10-28 3:47 ` Drew Fustini
2020-10-28 7:57 ` Marc Kleine-Budde
2020-10-31 12:27 ` Drew Fustini
2020-10-31 15:14 ` Patrick Menschel
2020-10-31 15:35 ` Patrick Menschel
2020-10-31 21:57 ` Drew Fustini
2020-11-01 22:49 ` Drew Fustini
2020-11-02 7:25 ` Marc Kleine-Budde [this message]
2020-11-02 8:18 ` Marc Kleine-Budde
[not found] ` <CAPgEAj7LcX3cb+syhtR1i3Uo1XkYYFQ_wDPV8GniaA-YwPk2Hg@mail.gmail.com>
2020-11-02 11:00 ` Marc Kleine-Budde
[not found] ` <CAPgEAj7BTJyiBg4QkKuekYH0zyrA-10dby3Lgb5qj2uiD4ZOYQ@mail.gmail.com>
2020-11-02 14:22 ` mcp251xfd: loopback test on waveshare canfd hat Marc Kleine-Budde
2020-11-02 14:35 ` Drew Fustini
2020-11-02 14:38 ` Marc Kleine-Budde
2020-11-02 17:34 ` mcp251xfd on RPi 5.4 downstream Patrick Menschel
2020-11-02 18:47 ` Patrick Menschel
2020-11-02 18:57 ` Thomas.Kopp
2020-11-02 19:32 ` Patrick Menschel
2020-11-04 18:48 ` Patrick Menschel
2020-11-05 7:15 ` Marc Kleine-Budde
2020-11-05 18:11 ` Patrick Menschel
2020-11-06 9:00 ` Marc Kleine-Budde
2020-11-06 11:31 ` Patrick Menschel
2020-11-06 11:36 ` Marc Kleine-Budde
2020-11-06 11:46 ` Patrick Menschel
2020-11-05 8:08 ` Marc Kleine-Budde
2020-11-05 8:07 ` Marc Kleine-Budde
2020-11-02 7:55 ` Marc Kleine-Budde
2020-11-02 7:26 ` Marc Kleine-Budde
2020-10-26 7:43 ` Marc Kleine-Budde
2020-11-20 12:32 ` Marc Kleine-Budde
[not found] ` <CAEf4M_B68X2T0rkaq0tqahBFPc+Gbvac7-+G0j5jd-g4j+j01g@mail.gmail.com>
2020-11-20 13:16 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0920d7-50c5-ff40-033c-57aca5a992bd@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=drew@beagleboard.org \
--cc=josh@macchina.cc \
--cc=linux-can@vger.kernel.org \
--cc=menschel.p@posteo.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.