All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Reza Arbab <arbab@linux.vnet.ibm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jonathan Corbet <corbet@lwn.net>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	Nathan Fontenot <nfont@linux.vnet.ibm.com>,
	devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node
Date: Fri, 12 Aug 2016 11:50:43 +1000	[thread overview]
Message-ID: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> (raw)
In-Reply-To: <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com>



On 09/08/16 04:27, Reza Arbab wrote:
> Remove the check which prevents us from hotplugging into an empty node.
> 
> Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>
> ---
>  arch/powerpc/mm/numa.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 80d067d..bc70c4f 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -1127,7 +1127,7 @@ static int hot_add_node_scn_to_nid(unsigned long scn_addr)
>  int hot_add_scn_to_nid(unsigned long scn_addr)
>  {
>  	struct device_node *memory = NULL;
> -	int nid, found = 0;
> +	int nid;
>  

Do we want to do this only for ibm,hotplug-aperture compatible ranges?

I'm OK either ways

Acked-by: Balbir Singh <bsingharora@gmail.com>

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora@gmail.com>
To: Reza Arbab <arbab@linux.vnet.ibm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jonathan Corbet <corbet@lwn.net>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	Nathan Fontenot <nfont@linux.vnet.ibm.com>,
	devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node
Date: Fri, 12 Aug 2016 11:50:43 +1000	[thread overview]
Message-ID: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> (raw)
In-Reply-To: <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com>



On 09/08/16 04:27, Reza Arbab wrote:
> Remove the check which prevents us from hotplugging into an empty node.
> 
> Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com>
> ---
>  arch/powerpc/mm/numa.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 80d067d..bc70c4f 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -1127,7 +1127,7 @@ static int hot_add_node_scn_to_nid(unsigned long scn_addr)
>  int hot_add_scn_to_nid(unsigned long scn_addr)
>  {
>  	struct device_node *memory = NULL;
> -	int nid, found = 0;
> +	int nid;
>  

Do we want to do this only for ibm,hotplug-aperture compatible ranges?

I'm OK either ways

Acked-by: Balbir Singh <bsingharora@gmail.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-08-12  1:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 18:27 [PATCH 0/4] powerpc/mm: movable hotplug memory nodes Reza Arbab
2016-08-08 18:27 ` Reza Arbab
2016-08-08 18:27 ` Reza Arbab
2016-08-08 18:27 ` [PATCH 1/4] dt-bindings: add doc for ibm,hotplug-aperture Reza Arbab
2016-08-08 18:27   ` Reza Arbab
2016-08-10 20:24   ` Rob Herring
2016-08-10 20:24     ` Rob Herring
2016-08-11  4:12   ` Balbir Singh
2016-08-11  4:12     ` Balbir Singh
2016-08-11  4:39     ` Stewart Smith
2016-08-11  4:39       ` Stewart Smith
2016-08-11 17:53       ` Reza Arbab
2016-08-11 17:53         ` Reza Arbab
2016-08-08 18:27 ` [PATCH 2/4] powerpc/mm: create numa nodes for hotplug memory Reza Arbab
2016-08-08 18:27   ` Reza Arbab
2016-08-12  1:43   ` Balbir Singh
2016-08-12  1:43     ` Balbir Singh
2016-08-08 18:27 ` [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node Reza Arbab
2016-08-08 18:27   ` Reza Arbab
2016-08-12  1:50   ` Balbir Singh [this message]
2016-08-12  1:50     ` Balbir Singh
2016-08-12 17:24     ` Reza Arbab
2016-08-12 17:24       ` Reza Arbab
2016-08-08 18:27 ` [PATCH 4/4] mm: enable CONFIG_MOVABLE_NODE on powerpc Reza Arbab
2016-08-08 18:27   ` Reza Arbab
2016-08-08 18:27   ` Reza Arbab
2016-08-10 10:30 ` [PATCH 0/4] powerpc/mm: movable hotplug memory nodes Michael Ellerman
2016-08-10 10:30   ` Michael Ellerman
2016-08-10 14:39   ` Nathan Fontenot
2016-08-10 14:39     ` Nathan Fontenot
2016-08-10 18:43   ` Reza Arbab
2016-08-10 18:43     ` Reza Arbab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com \
    --to=bsingharora@gmail.com \
    --cc=arbab@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.