From: Johannes Berg <johannes@sipsolutions.net> To: Abhinav Kumar <quic_abhinavk@quicinc.com>, Greg KH <gregkh@linuxfoundation.org> Cc: linux-kernel@vger.kernel.org, rafael@kernel.org, robdclark@gmail.com, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, seanpaul@chromium.org, swboyd@chromium.org, nganji@codeaurora.org, aravindh@codeaurora.org, khsieh@codeaurora.org, daniel@ffwll.ch, dmitry.baryshkov@linaro.org Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins Date: Sat, 12 Feb 2022 09:24:50 +0100 [thread overview] Message-ID: <7db7d01fcf5a3edce61161769c0e6eb1541237bf.camel@sipsolutions.net> (raw) In-Reply-To: <b9156bde-137c-2fac-19e0-b205ab4d6016@quicinc.com> On Fri, 2022-02-11 at 23:52 -0800, Abhinav Kumar wrote: > > The thread is writing the data to a file in local storage. From our > profiling, the read is the one taking the time not the write. > That seems kind of hard to believe, let's say it's a 4/3 split (4 minutes reading, 3 minutes writing, to make read > write as you say), and 3MiB size, that'd mean you get 12.8KiB/sec? That seems implausibly low, unless you're reading with really tiny buffers? Can you strace this somehow? (with timestamp info) > Just doubling what we have currently. I am not sure how the current 5 > mins timeout came from. > To be honest it came out of thin air, and wasn't really meant as a limit on how fast you can read (feels like even if it's tens of MiB you should read it in milliseconds into userspace), but more of a maximum time that we're willing to waste kernel memory if nobody is around to read the data. I thought it'd be better if we could somehow pin it while the userspace is reading it, but OTOH maybe that's actually bad, since that means userspace (though suitably privileged) could pin this kernel memory indefinitely. johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net> To: Abhinav Kumar <quic_abhinavk@quicinc.com>, Greg KH <gregkh@linuxfoundation.org> Cc: rafael@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, khsieh@codeaurora.org, nganji@codeaurora.org, seanpaul@chromium.org, dmitry.baryshkov@linaro.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins Date: Sat, 12 Feb 2022 09:24:50 +0100 [thread overview] Message-ID: <7db7d01fcf5a3edce61161769c0e6eb1541237bf.camel@sipsolutions.net> (raw) In-Reply-To: <b9156bde-137c-2fac-19e0-b205ab4d6016@quicinc.com> On Fri, 2022-02-11 at 23:52 -0800, Abhinav Kumar wrote: > > The thread is writing the data to a file in local storage. From our > profiling, the read is the one taking the time not the write. > That seems kind of hard to believe, let's say it's a 4/3 split (4 minutes reading, 3 minutes writing, to make read > write as you say), and 3MiB size, that'd mean you get 12.8KiB/sec? That seems implausibly low, unless you're reading with really tiny buffers? Can you strace this somehow? (with timestamp info) > Just doubling what we have currently. I am not sure how the current 5 > mins timeout came from. > To be honest it came out of thin air, and wasn't really meant as a limit on how fast you can read (feels like even if it's tens of MiB you should read it in milliseconds into userspace), but more of a maximum time that we're willing to waste kernel memory if nobody is around to read the data. I thought it'd be better if we could somehow pin it while the userspace is reading it, but OTOH maybe that's actually bad, since that means userspace (though suitably privileged) could pin this kernel memory indefinitely. johannes
next prev parent reply other threads:[~2022-02-12 8:25 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-08 19:44 [PATCH] devcoredump: increase the device delete timeout to 10 mins Abhinav Kumar 2022-02-08 19:44 ` Abhinav Kumar 2022-02-08 20:35 ` Johannes Berg 2022-02-08 20:35 ` Johannes Berg 2022-02-08 21:04 ` Abhinav Kumar 2022-02-08 21:04 ` Abhinav Kumar 2022-02-08 21:12 ` Johannes Berg 2022-02-08 21:12 ` Johannes Berg 2022-02-08 21:40 ` Abhinav Kumar 2022-02-08 21:40 ` Abhinav Kumar 2022-02-08 21:54 ` Johannes Berg 2022-02-09 1:55 ` Abhinav Kumar 2022-02-09 1:55 ` Abhinav Kumar 2022-02-09 7:50 ` Johannes Berg 2022-02-09 16:29 ` Abhinav Kumar 2022-02-09 16:29 ` Abhinav Kumar 2022-02-11 11:09 ` Greg KH 2022-02-11 11:09 ` Greg KH 2022-02-11 11:09 ` Greg KH 2022-02-11 11:09 ` Greg KH 2022-02-11 18:59 ` Abhinav Kumar 2022-02-11 18:59 ` Abhinav Kumar 2022-02-12 7:04 ` Greg KH 2022-02-12 7:04 ` Greg KH 2022-02-12 7:52 ` Abhinav Kumar 2022-02-12 7:52 ` Abhinav Kumar 2022-02-12 8:24 ` Johannes Berg [this message] 2022-02-12 8:24 ` Johannes Berg 2022-02-12 8:35 ` Abhinav Kumar 2022-02-12 8:35 ` Abhinav Kumar 2022-02-28 21:38 ` Abhinav Kumar 2022-02-28 21:38 ` Abhinav Kumar 2022-03-01 6:48 ` David Laight 2022-03-01 17:45 ` Rob Clark 2022-03-01 17:45 ` Rob Clark 2022-03-11 11:53 ` Johannes Berg 2022-03-11 11:53 ` Johannes Berg 2022-02-12 8:29 ` Greg KH 2022-02-12 8:29 ` Greg KH 2022-02-12 8:33 ` Abhinav Kumar 2022-02-12 8:33 ` Abhinav Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7db7d01fcf5a3edce61161769c0e6eb1541237bf.camel@sipsolutions.net \ --to=johannes@sipsolutions.net \ --cc=aravindh@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=khsieh@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nganji@codeaurora.org \ --cc=quic_abhinavk@quicinc.com \ --cc=rafael@kernel.org \ --cc=robdclark@gmail.com \ --cc=seanpaul@chromium.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.