From: Johannes Berg <johannes@sipsolutions.net>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>, linux-kernel@vger.kernel.org
Cc: rafael@kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, swboyd@chromium.org,
khsieh@codeaurora.org, nganji@codeaurora.org,
seanpaul@chromium.org, gregkh@linuxfoundation.org,
dmitry.baryshkov@linaro.org, aravindh@codeaurora.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins
Date: Tue, 08 Feb 2022 22:12:41 +0100 [thread overview]
Message-ID: <c59bc1af9974484075091333a3c98a2088251321.camel@sipsolutions.net> (raw)
In-Reply-To: <ebd340e4-2a02-d484-2ed0-9ee738d5b5c5@quicinc.com>
On Tue, 2022-02-08 at 13:04 -0800, Abhinav Kumar wrote:
>
> It opened the file rightaway but could not finish reading.
>
> The device gets deleted so the corresponding /data will disappear too (
> as the data node is under devcd*/data)
Yeah but even if the file disappears, the open file descriptor is still
there, no? Does sysfs somehow make those disappear? I know debugfs does
(now, to some extent, it didn't always), but I thought sysfs was
refcounting things and didn't do that?
What did the userspace actually see? read() returned 0 so EOF?
(I guess I could test it, but it's getting late)
Your other questions are related - you need to consider the file in
sysfs and the open file descriptor separately.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
robdclark@gmail.com, dri-devel@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
seanpaul@chromium.org, swboyd@chromium.org,
nganji@codeaurora.org, aravindh@codeaurora.org,
khsieh@codeaurora.org, daniel@ffwll.ch,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins
Date: Tue, 08 Feb 2022 22:12:41 +0100 [thread overview]
Message-ID: <c59bc1af9974484075091333a3c98a2088251321.camel@sipsolutions.net> (raw)
In-Reply-To: <ebd340e4-2a02-d484-2ed0-9ee738d5b5c5@quicinc.com>
On Tue, 2022-02-08 at 13:04 -0800, Abhinav Kumar wrote:
>
> It opened the file rightaway but could not finish reading.
>
> The device gets deleted so the corresponding /data will disappear too (
> as the data node is under devcd*/data)
Yeah but even if the file disappears, the open file descriptor is still
there, no? Does sysfs somehow make those disappear? I know debugfs does
(now, to some extent, it didn't always), but I thought sysfs was
refcounting things and didn't do that?
What did the userspace actually see? read() returned 0 so EOF?
(I guess I could test it, but it's getting late)
Your other questions are related - you need to consider the file in
sysfs and the open file descriptor separately.
johannes
next prev parent reply other threads:[~2022-02-08 21:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 19:44 [PATCH] devcoredump: increase the device delete timeout to 10 mins Abhinav Kumar
2022-02-08 19:44 ` Abhinav Kumar
2022-02-08 20:35 ` Johannes Berg
2022-02-08 20:35 ` Johannes Berg
2022-02-08 21:04 ` Abhinav Kumar
2022-02-08 21:04 ` Abhinav Kumar
2022-02-08 21:12 ` Johannes Berg [this message]
2022-02-08 21:12 ` Johannes Berg
2022-02-08 21:40 ` Abhinav Kumar
2022-02-08 21:40 ` Abhinav Kumar
2022-02-08 21:54 ` Johannes Berg
2022-02-09 1:55 ` Abhinav Kumar
2022-02-09 1:55 ` Abhinav Kumar
2022-02-09 7:50 ` Johannes Berg
2022-02-09 16:29 ` Abhinav Kumar
2022-02-09 16:29 ` Abhinav Kumar
2022-02-11 11:09 ` Greg KH
2022-02-11 11:09 ` Greg KH
2022-02-11 11:09 ` Greg KH
2022-02-11 11:09 ` Greg KH
2022-02-11 18:59 ` Abhinav Kumar
2022-02-11 18:59 ` Abhinav Kumar
2022-02-12 7:04 ` Greg KH
2022-02-12 7:04 ` Greg KH
2022-02-12 7:52 ` Abhinav Kumar
2022-02-12 7:52 ` Abhinav Kumar
2022-02-12 8:24 ` Johannes Berg
2022-02-12 8:24 ` Johannes Berg
2022-02-12 8:35 ` Abhinav Kumar
2022-02-12 8:35 ` Abhinav Kumar
2022-02-28 21:38 ` Abhinav Kumar
2022-02-28 21:38 ` Abhinav Kumar
2022-03-01 6:48 ` David Laight
2022-03-01 17:45 ` Rob Clark
2022-03-01 17:45 ` Rob Clark
2022-03-11 11:53 ` Johannes Berg
2022-03-11 11:53 ` Johannes Berg
2022-02-12 8:29 ` Greg KH
2022-02-12 8:29 ` Greg KH
2022-02-12 8:33 ` Abhinav Kumar
2022-02-12 8:33 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c59bc1af9974484075091333a3c98a2088251321.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=aravindh@codeaurora.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nganji@codeaurora.org \
--cc=quic_abhinavk@quicinc.com \
--cc=rafael@kernel.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.