From: abhinavk@codeaurora.org To: Lee Jones <lee.jones@linaro.org> Cc: freedreno@lists.freedesktop.org, Shubhashree Dhar <dhar@codeaurora.org>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run> Subject: Re: [PATCH 15/40] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting misuse Date: Mon, 30 Nov 2020 13:23:17 -0800 [thread overview] Message-ID: <7ecb21f6b65de4014b2bbe9dcc5762a0@codeaurora.org> (raw) In-Reply-To: <20201126134240.3214176-16-lee.jones@linaro.org> On 2020-11-26 05:42, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:246: error: Cannot > parse struct or union! > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:756: error: Cannot > parse struct or union! > > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Shubhashree Dhar <dhar@codeaurora.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index 38482b1047745..5c521de715670 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -189,7 +189,7 @@ struct dpu_irq_type { > u32 reg_idx; > }; > > -/** > +/* > * struct dpu_intr_reg - List of DPU interrupt registers > */ > static const struct dpu_intr_reg dpu_intr_set[] = { > @@ -245,7 +245,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = { > } > }; > > -/** > +/* > * struct dpu_irq_type - IRQ mapping table use for lookup an irq_idx > in this > * table that have a matching interface type and > * instance index.
WARNING: multiple messages have this Message-ID (diff)
From: abhinavk@codeaurora.org To: Lee Jones <lee.jones@linaro.org> Cc: Sean Paul <sean@poorly.run>, Shubhashree Dhar <dhar@codeaurora.org>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 15/40] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting misuse Date: Mon, 30 Nov 2020 13:23:17 -0800 [thread overview] Message-ID: <7ecb21f6b65de4014b2bbe9dcc5762a0@codeaurora.org> (raw) In-Reply-To: <20201126134240.3214176-16-lee.jones@linaro.org> On 2020-11-26 05:42, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:246: error: Cannot > parse struct or union! > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:756: error: Cannot > parse struct or union! > > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Shubhashree Dhar <dhar@codeaurora.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index 38482b1047745..5c521de715670 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -189,7 +189,7 @@ struct dpu_irq_type { > u32 reg_idx; > }; > > -/** > +/* > * struct dpu_intr_reg - List of DPU interrupt registers > */ > static const struct dpu_intr_reg dpu_intr_set[] = { > @@ -245,7 +245,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = { > } > }; > > -/** > +/* > * struct dpu_irq_type - IRQ mapping table use for lookup an irq_idx > in this > * table that have a matching interface type and > * instance index. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-30 21:24 UTC|newest] Thread overview: 244+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-26 13:42 [PATCH 00/40] [Set 10] Rid W=1 warnings from GPU Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` [PATCH 01/40] drm/amd/pm/powerplay/smumgr/tonga_smumgr: Remove set but unused variable 'res' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:09 ` Alex Deucher 2020-11-30 23:09 ` Alex Deucher 2020-11-30 23:09 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 02/40] drm/amd/pm/powerplay/smumgr/polaris10_smumgr: Make function called by reference static Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:10 ` Alex Deucher 2020-11-30 23:10 ` Alex Deucher 2020-11-30 23:10 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 03/40] drm/amd/pm/powerplay/smumgr/ci_smumgr: Remove set but unused variable 'res' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:14 ` Alex Deucher 2020-11-30 23:14 ` Alex Deucher 2020-11-30 23:14 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 04/40] drm/amd/pm/powerplay/smumgr/iceland_smumgr: Make function called by reference static Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:16 ` Alex Deucher 2020-11-30 23:16 ` Alex Deucher 2020-11-30 23:16 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 05/40] drm/amd/pm/powerplay/smumgr/vegam_smumgr: " Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:16 ` Alex Deucher 2020-11-30 23:16 ` Alex Deucher 2020-11-30 23:16 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 06/40] drm/amd/pm/powerplay/smumgr/smu9_smumgr: Include our own header containing our prototypes Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:17 ` Alex Deucher 2020-11-30 23:17 ` Alex Deucher 2020-11-30 23:17 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 07/40] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Demote kernel-doc format abuse Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:18 ` Alex Deucher 2020-11-30 23:18 ` Alex Deucher 2020-11-30 23:18 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 08/40] drm/amd/pm/powerplay/hwmgr/hardwaremanager: Remove unused 'phm_set_*()' functions Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:20 ` Alex Deucher 2020-11-30 23:20 ` Alex Deucher 2020-11-30 23:20 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 09/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'smu8_init_function_pointers()' prototype to shared header Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:28 ` Alex Deucher 2020-11-30 23:28 ` Alex Deucher 2020-11-30 23:28 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 10/40] drm/amd/pm/inc/pp_thermal: Mark 'SMU7Thermal{WithDelay}Policy' as __maybe_unused Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:29 ` Alex Deucher 2020-11-30 23:29 ` Alex Deucher 2020-11-30 23:29 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 11/40] drm/amd/pm/powerplay/hwmgr/ppevvmath: Place variable declaration under same clause as its use Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:31 ` Alex Deucher 2020-11-30 23:31 ` Alex Deucher 2020-11-30 23:31 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 12/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Remove unused variable 'fPowerDPMx' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:33 ` Alex Deucher 2020-11-30 23:33 ` Alex Deucher 2020-11-30 23:33 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 13/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'smu7_init_function_pointers()'s prototype to header Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:33 ` Alex Deucher 2020-11-30 23:33 ` Alex Deucher 2020-11-30 23:33 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 14/40] drm/amd/pm/powerplay/hwmgr/ppatomfwctrl: Demote kernel-doc formatting abuses Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:34 ` Alex Deucher 2020-11-30 23:34 ` Alex Deucher 2020-11-30 23:34 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 15/40] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote kernel-doc formatting misuse Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 21:23 ` abhinavk [this message] 2020-11-30 21:23 ` abhinavk 2020-11-26 13:42 ` [PATCH 16/40] drm/amd/pm/powerplay/smumgr/iceland_smumgr: Remove unused variable 'res' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:39 ` Alex Deucher 2020-11-30 23:39 ` Alex Deucher 2020-11-30 23:39 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 17/40] drm/amd/pm/powerplay/hwmgr/hardwaremanager: Fix function header related formatting issues Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:40 ` Alex Deucher 2020-11-30 23:40 ` Alex Deucher 2020-11-30 23:40 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 18/40] drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Convert to proper kernel-doc format Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:41 ` Alex Deucher 2020-11-30 23:41 ` Alex Deucher 2020-11-30 23:41 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 19/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix a myriad of kernel-doc issues Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:43 ` Alex Deucher 2020-11-30 23:43 ` Alex Deucher 2020-11-30 23:43 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 20/40] drm/amd/pm/powerplay/hwmgr/vega10_processpptables: Make function invoked by reference static Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:43 ` Alex Deucher 2020-11-30 23:43 ` Alex Deucher 2020-11-30 23:43 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 21/40] drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix a whole bunch of historical function doc issues Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:44 ` Alex Deucher 2020-11-30 23:44 ` Alex Deucher 2020-11-30 23:44 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 22/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Remove set but unused variable 'result' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` [PATCH 23/40] drm/amd/pm/powerplay/hwmgr/smu7_thermal: Repair formatting in a bunch of function docs Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:48 ` Alex Deucher 2020-11-30 23:48 ` Alex Deucher 2020-11-30 23:48 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 24/40] drm/amd/pm/powerplay/hwmgr/vega10_thermal: Fix a bunch of dated function doc formatting Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:49 ` Alex Deucher 2020-11-30 23:49 ` Alex Deucher 2020-11-30 23:49 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 25/40] drm/amd/pm/powerplay/hwmgr/pp_psm: Remove unused variable 'result' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` [PATCH 26/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega12_hwmgr_init()'s prototype to shared header Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:50 ` Alex Deucher 2020-11-30 23:50 ` Alex Deucher 2020-11-30 23:50 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'vega20_hwmgr_init()'s " Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:51 ` Alex Deucher 2020-11-30 23:51 ` Alex Deucher 2020-11-30 23:51 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 28/40] drm/amd/pm/powerplay/hwmgr/smu_helper: Demote or fix kernel-doc headers Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:52 ` Alex Deucher 2020-11-30 23:52 ` Alex Deucher 2020-11-30 23:52 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 29/40] drm/amd/pm/powerplay/hwmgr/vega20_thermal: Fix some outdated function documentation Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:53 ` Alex Deucher 2020-11-30 23:53 ` Alex Deucher 2020-11-30 23:53 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 30/40] drm/amd/pm/powerplay/hwmgr/vega12_thermal: " Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:54 ` Alex Deucher 2020-11-30 23:54 ` Alex Deucher 2020-11-30 23:54 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 31/40] drm/amd/pm/powerplay/kv_dpm: Remove unused variable 'ret' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 14:00 ` Alex Deucher 2020-12-01 14:00 ` Alex Deucher 2020-12-01 14:00 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 32/40] drm/amd/display/amdgpu_dm/amdgpu_dm: Mark 'link_bandwidth_kbps' as __maybe_unused Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-30 23:57 ` Alex Deucher 2020-11-30 23:57 ` Alex Deucher 2020-11-30 23:57 ` Alex Deucher 2020-12-01 7:19 ` Lee Jones 2020-12-01 7:19 ` Lee Jones 2020-12-01 7:19 ` Lee Jones 2020-11-26 13:42 ` [PATCH 33/40] drm/amd/display/dc/inc/hw/dpp: Mark 'dpp_input_csc_matrix' " Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:00 ` Alex Deucher 2020-12-01 0:00 ` Alex Deucher 2020-12-01 0:00 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 34/40] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Use 'gnu_printf' format notation Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 18:42 ` Alex Deucher 2020-12-01 18:42 ` Alex Deucher 2020-12-01 18:42 ` Alex Deucher 2020-12-01 18:59 ` Christian König 2020-12-01 18:59 ` Christian König 2020-12-01 18:59 ` Christian König 2020-12-01 19:41 ` Alex Deucher 2020-12-01 19:41 ` Alex Deucher 2020-12-01 19:41 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 35/40] drm/amd/display/amdgpu_dm/amdgpu_dm_color: Demote a misuse and fix another kernel-doc header Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:02 ` Alex Deucher 2020-12-01 0:02 ` Alex Deucher 2020-12-01 0:02 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 36/40] drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu: Mark local functions invoked by reference as static Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:04 ` Alex Deucher 2020-12-01 0:04 ` Alex Deucher 2020-12-01 0:04 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 37/40] drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu: Remove unused function 'pp_nv_set_pme_wa_enable()' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:05 ` Alex Deucher 2020-12-01 0:05 ` Alex Deucher 2020-12-01 0:05 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 38/40] drm/amd/display/dc/basics/conversion: Include header containing our prototypes Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:05 ` Alex Deucher 2020-12-01 0:05 ` Alex Deucher 2020-12-01 0:05 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 39/40] drm/amd/display/dc/basics/fixpt31_32: Remove unused variable 'dc_fixpt_pi' Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:06 ` Alex Deucher 2020-12-01 0:06 ` Alex Deucher 2020-12-01 0:06 ` Alex Deucher 2020-11-26 13:42 ` [PATCH 40/40] drm/amd/display/dc/basics/vector: Make local function 'dal_vector_presized_costruct' static Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-11-26 13:42 ` Lee Jones 2020-12-01 0:07 ` Alex Deucher 2020-12-01 0:07 ` Alex Deucher 2020-12-01 0:07 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7ecb21f6b65de4014b2bbe9dcc5762a0@codeaurora.org \ --to=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=dhar@codeaurora.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.