* [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create()
@ 2017-06-05 13:55 Peter Maydell
2017-06-05 14:05 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Maydell @ 2017-06-05 13:55 UTC (permalink / raw)
To: qemu-devel; +Cc: patches, Kevin Wolf, Max Reitz, qemu-block
Coverity points out that the code path in qcow_create() for
the magic "fat:" backing file name leaks the memory used to
store the filename (CID 1307771). Free the memory before
we overwrite the pointer.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
block/qcow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow.c b/block/qcow.c
index 95ab123..7bd94dc 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts *opts, Error **errp)
header_size += backing_filename_len;
} else {
/* special backing file for vvfat */
+ g_free(backing_file);
backing_file = NULL;
}
header.cluster_bits = 9; /* 512 byte cluster to avoid copying
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create()
2017-06-05 13:55 [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create() Peter Maydell
@ 2017-06-05 14:05 ` Eric Blake
2017-06-05 14:19 ` Philippe Mathieu-Daudé
2017-06-06 11:13 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2017-06-05 14:05 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Kevin Wolf, Max Reitz, qemu-block, patches
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On 06/05/2017 08:55 AM, Peter Maydell wrote:
> Coverity points out that the code path in qcow_create() for
> the magic "fat:" backing file name leaks the memory used to
> store the filename (CID 1307771). Free the memory before
> we overwrite the pointer.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> block/qcow.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 95ab123..7bd94dc 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts *opts, Error **errp)
> header_size += backing_filename_len;
> } else {
> /* special backing file for vvfat */
> + g_free(backing_file);
> backing_file = NULL;
> }
> header.cluster_bits = 9; /* 512 byte cluster to avoid copying
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create()
2017-06-05 13:55 [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create() Peter Maydell
2017-06-05 14:05 ` Eric Blake
@ 2017-06-05 14:19 ` Philippe Mathieu-Daudé
2017-06-06 11:13 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-06-05 14:19 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Kevin Wolf, Max Reitz, qemu-block, patches
On 06/05/2017 10:55 AM, Peter Maydell wrote:
> Coverity points out that the code path in qcow_create() for
> the magic "fat:" backing file name leaks the memory used to
> store the filename (CID 1307771). Free the memory before
> we overwrite the pointer.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> block/qcow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 95ab123..7bd94dc 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -852,6 +852,7 @@ static int qcow_create(const char *filename, QemuOpts *opts, Error **errp)
> header_size += backing_filename_len;
> } else {
> /* special backing file for vvfat */
> + g_free(backing_file);
> backing_file = NULL;
> }
> header.cluster_bits = 9; /* 512 byte cluster to avoid copying
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create()
2017-06-05 13:55 [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create() Peter Maydell
2017-06-05 14:05 ` Eric Blake
2017-06-05 14:19 ` Philippe Mathieu-Daudé
@ 2017-06-06 11:13 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2017-06-06 11:13 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches, Max Reitz, qemu-block
Am 05.06.2017 um 15:55 hat Peter Maydell geschrieben:
> Coverity points out that the code path in qcow_create() for
> the magic "fat:" backing file name leaks the memory used to
> store the filename (CID 1307771). Free the memory before
> we overwrite the pointer.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-06 11:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-05 13:55 [Qemu-devel] [PATCH] block/qcow.c: Fix memory leak in qcow_create() Peter Maydell
2017-06-05 14:05 ` Eric Blake
2017-06-05 14:19 ` Philippe Mathieu-Daudé
2017-06-06 11:13 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.