From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Johan Hovold <johan@kernel.org> Cc: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Kishon Vijay Abraham I <kishon@ti.com>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/13] phy: qcom-qmp-pcie: clean up power-down handling Date: Thu, 29 Sep 2022 10:30:20 +0300 [thread overview] Message-ID: <7f577974-7433-107a-a43a-4a3a5f999018@linaro.org> (raw) In-Reply-To: <YzVIhK5z3I6hjzLU@hovoldconsulting.com> On 29/09/2022 10:25, Johan Hovold wrote: > On Wed, Sep 28, 2022 at 10:15:46PM +0300, Dmitry Baryshkov wrote: >> On 28/09/2022 18:28, Johan Hovold wrote: >>> Always define the POWER_DOWN_CONTROL register instead of falling back to >>> the v2 offset during power on and power off. >>> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >>> --- >>> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 20 ++++++-------------- >>> 1 file changed, 6 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >>> index eea66c24cf7e..47cdb9ed80cd 100644 >>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >>> @@ -90,12 +90,14 @@ static const unsigned int pciephy_regs_layout[QPHY_LAYOUT_SIZE] = { >>> [QPHY_SW_RESET] = 0x00, >>> [QPHY_START_CTRL] = 0x08, >>> [QPHY_PCS_STATUS] = 0x174, >>> + [QPHY_PCS_POWER_DOWN_CONTROL] = 0x04, >>> }; >> >> Without symbolic names it's not obvious that 0x04 (and thus this >> regs_layout) can be used for v2 and v3, but not for v4. > > It's no less obvious than it was when we were falling back to the v2 > define when it wasn't in the table. Yes, that's without doubts. Anyway, I've sent my view on the regs layouts standing on top of your six patches from this series. Could you please take a glance? > >> @@ -1872,13 +1874,8 @@ static int qmp_pcie_init(struct phy *phy) >> if (ret) >> goto err_assert_reset; >> - if (cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL]) >> - qphy_setbits(pcs, >> - cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL], >> - cfg->pwrdn_ctrl); >> - else >> - qphy_setbits(pcs, QPHY_V2_PCS_POWER_DOWN_CONTROL, >> - cfg->pwrdn_ctrl); >> + qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL], >> + cfg->pwrdn_ctrl); > > This is the cruft I'm getting rid of. > > Johan -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Johan Hovold <johan@kernel.org> Cc: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Kishon Vijay Abraham I <kishon@ti.com>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/13] phy: qcom-qmp-pcie: clean up power-down handling Date: Thu, 29 Sep 2022 10:30:20 +0300 [thread overview] Message-ID: <7f577974-7433-107a-a43a-4a3a5f999018@linaro.org> (raw) In-Reply-To: <YzVIhK5z3I6hjzLU@hovoldconsulting.com> On 29/09/2022 10:25, Johan Hovold wrote: > On Wed, Sep 28, 2022 at 10:15:46PM +0300, Dmitry Baryshkov wrote: >> On 28/09/2022 18:28, Johan Hovold wrote: >>> Always define the POWER_DOWN_CONTROL register instead of falling back to >>> the v2 offset during power on and power off. >>> >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >>> --- >>> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 20 ++++++-------------- >>> 1 file changed, 6 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >>> index eea66c24cf7e..47cdb9ed80cd 100644 >>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c >>> @@ -90,12 +90,14 @@ static const unsigned int pciephy_regs_layout[QPHY_LAYOUT_SIZE] = { >>> [QPHY_SW_RESET] = 0x00, >>> [QPHY_START_CTRL] = 0x08, >>> [QPHY_PCS_STATUS] = 0x174, >>> + [QPHY_PCS_POWER_DOWN_CONTROL] = 0x04, >>> }; >> >> Without symbolic names it's not obvious that 0x04 (and thus this >> regs_layout) can be used for v2 and v3, but not for v4. > > It's no less obvious than it was when we were falling back to the v2 > define when it wasn't in the table. Yes, that's without doubts. Anyway, I've sent my view on the regs layouts standing on top of your six patches from this series. Could you please take a glance? > >> @@ -1872,13 +1874,8 @@ static int qmp_pcie_init(struct phy *phy) >> if (ret) >> goto err_assert_reset; >> - if (cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL]) >> - qphy_setbits(pcs, >> - cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL], >> - cfg->pwrdn_ctrl); >> - else >> - qphy_setbits(pcs, QPHY_V2_PCS_POWER_DOWN_CONTROL, >> - cfg->pwrdn_ctrl); >> + qphy_setbits(pcs, cfg->regs[QPHY_PCS_POWER_DOWN_CONTROL], >> + cfg->pwrdn_ctrl); > > This is the cruft I'm getting rid of. > > Johan -- With best wishes Dmitry -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-29 7:30 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-28 15:28 [PATCH 00/13] phy: qcom-qmp: more fixes and cleanups Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 15:28 ` [PATCH 01/13] phy: qcom-qmp: fix obsolete lane comments Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 15:56 ` Neil Armstrong 2022-09-28 15:56 ` Neil Armstrong 2022-09-28 17:26 ` Dmitry Baryshkov 2022-09-28 17:26 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 02/13] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 16:04 ` Neil Armstrong 2022-09-28 16:04 ` Neil Armstrong 2022-09-28 17:25 ` Dmitry Baryshkov 2022-09-28 17:25 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 03/13] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 16:03 ` Neil Armstrong 2022-09-28 16:03 ` Neil Armstrong 2022-09-28 17:23 ` Dmitry Baryshkov 2022-09-28 17:23 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 04/13] phy: qcom-qmp-pcie: unify ipq registers Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 15:57 ` Neil Armstrong 2022-09-28 15:57 ` Neil Armstrong 2022-09-28 17:34 ` Dmitry Baryshkov 2022-09-28 17:34 ` Dmitry Baryshkov 2022-09-29 6:53 ` Johan Hovold 2022-09-29 6:53 ` Johan Hovold 2022-09-28 15:28 ` [PATCH 05/13] phy: qcom-qmp-pcie: unify sdm845 registers Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 16:01 ` Neil Armstrong 2022-09-28 16:01 ` Neil Armstrong 2022-09-28 16:03 ` Neil Armstrong 2022-09-28 16:03 ` Neil Armstrong 2022-09-28 19:11 ` Dmitry Baryshkov 2022-09-28 19:11 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 06/13] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:10 ` Dmitry Baryshkov 2022-09-28 19:10 ` Dmitry Baryshkov 2022-09-28 19:48 ` Dmitry Baryshkov 2022-09-28 19:48 ` Dmitry Baryshkov 2022-09-29 7:12 ` Johan Hovold 2022-09-29 7:12 ` Johan Hovold 2022-09-29 7:56 ` Dmitry Baryshkov 2022-09-29 7:56 ` Dmitry Baryshkov 2022-09-29 8:18 ` Johan Hovold 2022-09-29 8:18 ` Johan Hovold 2022-09-29 6:56 ` Johan Hovold 2022-09-29 6:56 ` Johan Hovold 2022-09-28 15:28 ` [PATCH 07/13] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:15 ` Dmitry Baryshkov 2022-09-28 19:15 ` Dmitry Baryshkov 2022-09-29 7:25 ` Johan Hovold 2022-09-29 7:25 ` Johan Hovold 2022-09-29 7:30 ` Dmitry Baryshkov [this message] 2022-09-29 7:30 ` Dmitry Baryshkov 2022-09-29 9:04 ` Johan Hovold 2022-09-29 9:04 ` Johan Hovold 2022-09-29 9:07 ` Dmitry Baryshkov 2022-09-29 9:07 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 08/13] phy: qcom-qmp-pcie: move power-down update Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 15:28 ` [PATCH 09/13] phy: qcom-qmp-pcie-msm8996: clean up power-down handling Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:52 ` Dmitry Baryshkov 2022-09-28 19:52 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 10/13] phy: qcom-qmp-combo: " Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:53 ` Dmitry Baryshkov 2022-09-28 19:53 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 11/13] phy: qcom-qmp-ufs: " Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:53 ` Dmitry Baryshkov 2022-09-28 19:53 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 12/13] phy: qcom-qmp-usb: " Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:53 ` Dmitry Baryshkov 2022-09-28 19:53 ` Dmitry Baryshkov 2022-09-28 15:28 ` [PATCH 13/13] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold 2022-09-28 15:28 ` Johan Hovold 2022-09-28 19:54 ` Dmitry Baryshkov 2022-09-28 19:54 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7f577974-7433-107a-a43a-4a3a5f999018@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=agross@kernel.org \ --cc=andersson@kernel.org \ --cc=johan+linaro@kernel.org \ --cc=johan@kernel.org \ --cc=kishon@ti.com \ --cc=konrad.dybcio@somainline.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.