From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/13] phy: qcom-qmp-pcie: unify ipq registers
Date: Thu, 29 Sep 2022 08:53:46 +0200 [thread overview]
Message-ID: <YzVA+rJY8I1xMwhN@hovoldconsulting.com> (raw)
In-Reply-To: <CD3050AE-693F-4AD7-9F1E-016E2AB1DF99@linaro.org>
On Wed, Sep 28, 2022 at 08:34:37PM +0300, Dmitry Baryshkov wrote:
>
>
> On 28 September 2022 18:28:13 GMT+03:00, Johan Hovold <johan+linaro@kernel.org> wrote:
> >The IPQ register array is identical to sm8250_pcie_regs_layout so drop
> >the former.
>
> I'd not do such merge. They belong to different generations. I'd
> suggest changing these arrays to use symbolic names defined in
> corresponding qmp headers.
That could be done too, but this is not how these drivers are
implemented currently. Whenever the resource lists match, they end up
being reused. These values need not even change between revisions.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/13] phy: qcom-qmp-pcie: unify ipq registers
Date: Thu, 29 Sep 2022 08:53:46 +0200 [thread overview]
Message-ID: <YzVA+rJY8I1xMwhN@hovoldconsulting.com> (raw)
In-Reply-To: <CD3050AE-693F-4AD7-9F1E-016E2AB1DF99@linaro.org>
On Wed, Sep 28, 2022 at 08:34:37PM +0300, Dmitry Baryshkov wrote:
>
>
> On 28 September 2022 18:28:13 GMT+03:00, Johan Hovold <johan+linaro@kernel.org> wrote:
> >The IPQ register array is identical to sm8250_pcie_regs_layout so drop
> >the former.
>
> I'd not do such merge. They belong to different generations. I'd
> suggest changing these arrays to use symbolic names defined in
> corresponding qmp headers.
That could be done too, but this is not how these drivers are
implemented currently. Whenever the resource lists match, they end up
being reused. These values need not even change between revisions.
Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-29 6:53 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 15:28 [PATCH 00/13] phy: qcom-qmp: more fixes and cleanups Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 15:28 ` [PATCH 01/13] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 15:56 ` Neil Armstrong
2022-09-28 15:56 ` Neil Armstrong
2022-09-28 17:26 ` Dmitry Baryshkov
2022-09-28 17:26 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 02/13] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 16:04 ` Neil Armstrong
2022-09-28 16:04 ` Neil Armstrong
2022-09-28 17:25 ` Dmitry Baryshkov
2022-09-28 17:25 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 03/13] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 16:03 ` Neil Armstrong
2022-09-28 16:03 ` Neil Armstrong
2022-09-28 17:23 ` Dmitry Baryshkov
2022-09-28 17:23 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 04/13] phy: qcom-qmp-pcie: unify ipq registers Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 15:57 ` Neil Armstrong
2022-09-28 15:57 ` Neil Armstrong
2022-09-28 17:34 ` Dmitry Baryshkov
2022-09-28 17:34 ` Dmitry Baryshkov
2022-09-29 6:53 ` Johan Hovold [this message]
2022-09-29 6:53 ` Johan Hovold
2022-09-28 15:28 ` [PATCH 05/13] phy: qcom-qmp-pcie: unify sdm845 registers Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 16:01 ` Neil Armstrong
2022-09-28 16:01 ` Neil Armstrong
2022-09-28 16:03 ` Neil Armstrong
2022-09-28 16:03 ` Neil Armstrong
2022-09-28 19:11 ` Dmitry Baryshkov
2022-09-28 19:11 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 06/13] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:10 ` Dmitry Baryshkov
2022-09-28 19:10 ` Dmitry Baryshkov
2022-09-28 19:48 ` Dmitry Baryshkov
2022-09-28 19:48 ` Dmitry Baryshkov
2022-09-29 7:12 ` Johan Hovold
2022-09-29 7:12 ` Johan Hovold
2022-09-29 7:56 ` Dmitry Baryshkov
2022-09-29 7:56 ` Dmitry Baryshkov
2022-09-29 8:18 ` Johan Hovold
2022-09-29 8:18 ` Johan Hovold
2022-09-29 6:56 ` Johan Hovold
2022-09-29 6:56 ` Johan Hovold
2022-09-28 15:28 ` [PATCH 07/13] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:15 ` Dmitry Baryshkov
2022-09-28 19:15 ` Dmitry Baryshkov
2022-09-29 7:25 ` Johan Hovold
2022-09-29 7:25 ` Johan Hovold
2022-09-29 7:30 ` Dmitry Baryshkov
2022-09-29 7:30 ` Dmitry Baryshkov
2022-09-29 9:04 ` Johan Hovold
2022-09-29 9:04 ` Johan Hovold
2022-09-29 9:07 ` Dmitry Baryshkov
2022-09-29 9:07 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 08/13] phy: qcom-qmp-pcie: move power-down update Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 15:28 ` [PATCH 09/13] phy: qcom-qmp-pcie-msm8996: clean up power-down handling Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:52 ` Dmitry Baryshkov
2022-09-28 19:52 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 10/13] phy: qcom-qmp-combo: " Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:53 ` Dmitry Baryshkov
2022-09-28 19:53 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 11/13] phy: qcom-qmp-ufs: " Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:53 ` Dmitry Baryshkov
2022-09-28 19:53 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 12/13] phy: qcom-qmp-usb: " Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:53 ` Dmitry Baryshkov
2022-09-28 19:53 ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 13/13] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 19:54 ` Dmitry Baryshkov
2022-09-28 19:54 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzVA+rJY8I1xMwhN@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.