* [PATCH 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant
2022-05-21 20:07 [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
@ 2022-05-21 20:07 ` Ahmad Fatoum
2022-05-21 21:07 ` [1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding bluez.test.bot
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Ahmad Fatoum @ 2022-05-21 20:07 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz
Cc: kernel, Ahmad Fatoum, Rob Herring, Krzysztof Kozlowski,
linux-kernel, linux-bluetooth, David S. Miller, Jakub Kicinski,
Paolo Abeni, Linus Walleij, devicetree, netdev
The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
Two subversions are added for the chip, because ROM firmware reports
002.002.013 (at least for the chips I have here), while depending on
patchram firmware revision, either 002.002.013 or 002.002.014 is
reported.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
To: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: netdev@vger.kernel.org
---
drivers/bluetooth/btbcm.c | 2 ++
drivers/bluetooth/hci_bcm.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index d9ceca7a7935..a18f289d7346 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -453,6 +453,8 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
{ 0x6606, "BCM4345C5" }, /* 003.006.006 */
{ 0x230f, "BCM4356A2" }, /* 001.003.015 */
{ 0x220e, "BCM20702A1" }, /* 001.002.014 */
+ { 0x420d, "BCM4349B1" }, /* 002.002.013 */
+ { 0x420e, "BCM4349B1" }, /* 002.002.014 */
{ 0x4217, "BCM4329B1" }, /* 002.002.023 */
{ 0x6106, "BCM4359C0" }, /* 003.001.006 */
{ 0x4106, "BCM4335A0" }, /* 002.001.006 */
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 785f445dd60d..d0a6f9ff4e08 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1544,6 +1544,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm43430a0-bt" },
{ .compatible = "brcm,bcm43430a1-bt" },
{ .compatible = "brcm,bcm43438-bt", .data = &bcm43438_device_data },
+ { .compatible = "brcm,bcm4349-bt", .data = &bcm43438_device_data },
{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
{ .compatible = "brcm,bcm4335a0" },
{ },
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-21 20:07 [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
2022-05-21 20:07 ` [PATCH 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
@ 2022-05-21 21:07 ` bluez.test.bot
2022-05-22 7:40 ` [PATCH 1/2] " Krzysztof Kozlowski
2022-05-22 21:03 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: bluez.test.bot @ 2022-05-21 21:07 UTC (permalink / raw)
To: linux-bluetooth, a.fatoum
[-- Attachment #1: Type: text/plain, Size: 2546 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=644017
---Test result---
Test Summary:
CheckPatch FAIL 1.84 seconds
GitLint PASS 0.84 seconds
SubjectPrefix FAIL 0.30 seconds
BuildKernel PASS 40.18 seconds
BuildKernel32 PASS 36.15 seconds
Incremental Build with patchesPASS 54.29 seconds
TestRunner: Setup PASS 602.88 seconds
TestRunner: l2cap-tester PASS 19.98 seconds
TestRunner: bnep-tester PASS 7.16 seconds
TestRunner: mgmt-tester PASS 122.74 seconds
TestRunner: rfcomm-tester PASS 11.33 seconds
TestRunner: sco-tester PASS 11.17 seconds
TestRunner: smp-tester PASS 11.03 seconds
TestRunner: userchan-tester PASS 7.79 seconds
Details
##############################
Test: CheckPatch - FAIL - 1.84 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
[1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding\WARNING:BAD_SIGN_OFF: Duplicate signature
#87:
Cc: linux-kernel@vger.kernel.org
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12858005.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant\WARNING:BAD_SIGN_OFF: Duplicate signature
#91:
Cc: linux-kernel@vger.kernel.org
total: 0 errors, 1 warnings, 15 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12858004.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: SubjectPrefix - FAIL - 0.30 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-21 20:07 [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
2022-05-21 20:07 ` [PATCH 2/2] Bluetooth: hci_bcm: Add BCM4349B1 variant Ahmad Fatoum
2022-05-21 21:07 ` [1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding bluez.test.bot
@ 2022-05-22 7:40 ` Krzysztof Kozlowski
2022-05-22 21:03 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-22 7:40 UTC (permalink / raw)
To: Ahmad Fatoum, Marcel Holtmann, Johan Hedberg,
Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski,
devicetree
Cc: kernel, linux-kernel, linux-bluetooth, David S. Miller,
Jakub Kicinski, Paolo Abeni, Linus Walleij, netdev
On 21/05/2022 22:07, Ahmad Fatoum wrote:
> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
> Extend the binding with its DT compatible.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-21 20:07 [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding Ahmad Fatoum
` (2 preceding siblings ...)
2022-05-22 7:40 ` [PATCH 1/2] " Krzysztof Kozlowski
@ 2022-05-22 21:03 ` Linus Walleij
2022-05-22 22:16 ` Ahmad Fatoum
3 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2022-05-22 21:03 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Rob Herring, Krzysztof Kozlowski, devicetree, kernel,
linux-kernel, linux-bluetooth, David S. Miller, Jakub Kicinski,
Paolo Abeni, netdev
On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
So the BT and the package have two different names.
> + - brcm,bcm4349-bt
Then why do you have to tag on "-bt" on this compatible?
That is typically used when the wifi and bt has the *same* name, so
the only way to distinguish between them is a suffix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-22 21:03 ` Linus Walleij
@ 2022-05-22 22:16 ` Ahmad Fatoum
2022-05-23 8:38 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Ahmad Fatoum @ 2022-05-22 22:16 UTC (permalink / raw)
To: Linus Walleij
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Rob Herring, Krzysztof Kozlowski, devicetree, kernel,
linux-kernel, linux-bluetooth, David S. Miller, Jakub Kicinski,
Paolo Abeni, netdev
On 22.05.22 23:03, Linus Walleij wrote:
> On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
>> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
>> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
>
> So the BT and the package have two different names.
The package also goes by the name BCM4349B1 apparently.
Cypress support had later confirmed BCM4349B1 and BCM89359 to
be the same chipset. I should probably rephrase the commit message.
>> + - brcm,bcm4349-bt
>
> Then why do you have to tag on "-bt" on this compatible?
>
> That is typically used when the wifi and bt has the *same* name, so
> the only way to distinguish between them is a suffix.
I think that's the case here too.
Cheers,
Ahmad
>
> Yours,
> Linus Walleij
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
2022-05-22 22:16 ` Ahmad Fatoum
@ 2022-05-23 8:38 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2022-05-23 8:38 UTC (permalink / raw)
To: Ahmad Fatoum
Cc: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
Rob Herring, Krzysztof Kozlowski, devicetree, kernel,
linux-kernel, linux-bluetooth, David S. Miller, Jakub Kicinski,
Paolo Abeni, netdev
On Mon, May 23, 2022 at 12:16 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> On 22.05.22 23:03, Linus Walleij wrote:
> > On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> >
> >> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
> >> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
> >
> > So the BT and the package have two different names.
>
> The package also goes by the name BCM4349B1 apparently.
> Cypress support had later confirmed BCM4349B1 and BCM89359 to
> be the same chipset. I should probably rephrase the commit message.
>
>
> >> + - brcm,bcm4349-bt
> >
> > Then why do you have to tag on "-bt" on this compatible?
> >
> > That is typically used when the wifi and bt has the *same* name, so
> > the only way to distinguish between them is a suffix.
> I think that's the case here too.
OK then!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread