From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Ulrich Hecht <uli+renesas@fpond.eu> Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com Subject: Re: [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Date: Mon, 20 Aug 2018 14:01:54 +0300 [thread overview] Message-ID: <80779849.cAp1Gtn18s@avalon> (raw) In-Reply-To: <1534254604-24204-11-git-send-email-uli+renesas@fpond.eu> Hi Ulrich, Thank you for the patch. On Tuesday, 14 August 2018 16:50:04 EEST Ulrich Hecht wrote: > Adds LVDS decoder, HDMI encoder and connector for Draak boards. > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'm afraid I'll have to revoke that, as it applied to the patch before the addition of the max-clock and min-vrefresh properties. Let's discuss them in replies to patch 05/10 in this series. > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 84 +++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index bd5c6fa..157adf9 > 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -24,6 +24,41 @@ > stdout-path = "serial0:115200n8"; > }; > > + lvds-decoder { > + compatible = "thine,thc63lvd1024"; > + vcc-supply = <®_3p3v>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + thc63lvd1024_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + thc63lvd1024_out: endpoint { > + remote-endpoint = <&adv7511_in>; > + }; > + }; > + }; > + }; > + > + hdmi-out { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_out: endpoint { > + remote-endpoint = <&adv7511_out>; > + }; > + }; > + }; > + > vga { > compatible = "vga-connector"; > > @@ -218,6 +253,43 @@ > > }; > > + hdmi@39 { > + compatible = "adi,adv7511w"; > + reg = <0x39>, <0x3f>, <0x38>, <0x3c>; > + reg-names = "main", "edid", "packet", "cec"; > + interrupt-parent = <&gpio1>; > + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; > + > + /* Depends on LVDS */ > + max-clock = <135000000>; > + min-vrefresh = <50>; > + > + adi,input-depth = <8>; > + adi,input-colorspace = "rgb"; > + adi,input-clock = "1x"; > + adi,input-style = <1>; > + adi,input-justification = "evenly"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + adv7511_in: endpoint { > + remote-endpoint = <&thc63lvd1024_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + adv7511_out: endpoint { > + remote-endpoint = <&hdmi_con_out>; > + }; > + }; > + }; > + }; > + > hdmi-decoder@4c { > compatible = "adi,adv7612"; > reg = <0x4c>; > @@ -283,6 +355,18 @@ > }; > }; > > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&thc63lvd1024_in>; > + }; > + }; > + }; > +}; > + > &ehci0 { > status = "okay"; > }; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Ulrich Hecht <uli+renesas@fpond.eu> Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, dri-devel@lists.freedesktop.org Subject: Re: [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Date: Mon, 20 Aug 2018 14:01:54 +0300 [thread overview] Message-ID: <80779849.cAp1Gtn18s@avalon> (raw) In-Reply-To: <1534254604-24204-11-git-send-email-uli+renesas@fpond.eu> Hi Ulrich, Thank you for the patch. On Tuesday, 14 August 2018 16:50:04 EEST Ulrich Hecht wrote: > Adds LVDS decoder, HDMI encoder and connector for Draak boards. > > Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'm afraid I'll have to revoke that, as it applied to the patch before the addition of the max-clock and min-vrefresh properties. Let's discuss them in replies to patch 05/10 in this series. > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 84 +++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index bd5c6fa..157adf9 > 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -24,6 +24,41 @@ > stdout-path = "serial0:115200n8"; > }; > > + lvds-decoder { > + compatible = "thine,thc63lvd1024"; > + vcc-supply = <®_3p3v>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + thc63lvd1024_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + thc63lvd1024_out: endpoint { > + remote-endpoint = <&adv7511_in>; > + }; > + }; > + }; > + }; > + > + hdmi-out { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_out: endpoint { > + remote-endpoint = <&adv7511_out>; > + }; > + }; > + }; > + > vga { > compatible = "vga-connector"; > > @@ -218,6 +253,43 @@ > > }; > > + hdmi@39 { > + compatible = "adi,adv7511w"; > + reg = <0x39>, <0x3f>, <0x38>, <0x3c>; > + reg-names = "main", "edid", "packet", "cec"; > + interrupt-parent = <&gpio1>; > + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; > + > + /* Depends on LVDS */ > + max-clock = <135000000>; > + min-vrefresh = <50>; > + > + adi,input-depth = <8>; > + adi,input-colorspace = "rgb"; > + adi,input-clock = "1x"; > + adi,input-style = <1>; > + adi,input-justification = "evenly"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + adv7511_in: endpoint { > + remote-endpoint = <&thc63lvd1024_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + adv7511_out: endpoint { > + remote-endpoint = <&hdmi_con_out>; > + }; > + }; > + }; > + }; > + > hdmi-decoder@4c { > compatible = "adi,adv7612"; > reg = <0x4c>; > @@ -283,6 +355,18 @@ > }; > }; > > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&thc63lvd1024_in>; > + }; > + }; > + }; > +}; > + > &ehci0 { > status = "okay"; > }; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-08-20 14:16 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-14 13:49 [PROTO][PATCH 00/10] R-Car D3 LVDS/HDMI support (with PLL) Ulrich Hecht 2018-08-14 13:49 ` Ulrich Hecht 2018-08-14 13:49 ` [PROTO][PATCH 01/10] drm: rcar-du: Add clk_set_rate for external clock device Ulrich Hecht 2018-08-14 13:49 ` Ulrich Hecht 2018-08-20 10:10 ` Laurent Pinchart 2018-08-20 10:10 ` Laurent Pinchart 2018-08-14 13:49 ` [PROTO][PATCH 02/10] drm: rcar-du: Add r8a77995 device support Ulrich Hecht 2018-08-14 13:49 ` Ulrich Hecht 2018-08-20 8:39 ` Laurent Pinchart 2018-08-20 8:39 ` Laurent Pinchart 2018-08-14 13:49 ` [PROTO][PATCH 03/10] drm: rcar-du: Fix digital RGB routing for R8A77995 Ulrich Hecht 2018-08-14 13:49 ` Ulrich Hecht 2018-08-20 9:25 ` Laurent Pinchart 2018-08-20 9:25 ` Laurent Pinchart 2018-08-14 13:49 ` [PROTO][PATCH 04/10] drm: rcar-du: lvds: LVDS PLL support Ulrich Hecht 2018-08-14 13:49 ` Ulrich Hecht 2018-08-20 10:48 ` Laurent Pinchart 2018-08-20 10:48 ` Laurent Pinchart 2018-08-14 13:49 ` [PROTO][PATCH 05/10] drm/bridge: adv7511: Add max-clock, min-vrefresh options Ulrich Hecht 2018-08-14 13:49 ` Ulrich Hecht 2018-08-20 9:28 ` Laurent Pinchart 2018-08-20 9:28 ` Laurent Pinchart 2018-08-21 8:03 ` Ulrich Hecht 2018-08-21 8:03 ` Ulrich Hecht 2018-08-21 8:09 ` Laurent Pinchart 2018-08-21 8:09 ` Laurent Pinchart 2018-08-22 9:13 ` Ulrich Hecht 2018-08-22 9:13 ` Ulrich Hecht 2018-08-22 14:00 ` Laurent Pinchart 2018-08-22 14:00 ` Laurent Pinchart 2018-08-14 13:50 ` [PROTO][PATCH 06/10] drm: rcar-du: Fix procedure for extal and dotclkin selection Ulrich Hecht 2018-08-14 13:50 ` Ulrich Hecht 2018-08-20 9:40 ` Laurent Pinchart 2018-08-20 9:40 ` Laurent Pinchart 2018-08-14 13:50 ` [PROTO][PATCH 07/10] arm64: dts: r8a77995-draak: set external clock for DU Ulrich Hecht 2018-08-14 13:50 ` Ulrich Hecht 2018-08-20 10:51 ` Laurent Pinchart 2018-08-20 10:51 ` Laurent Pinchart 2018-08-14 13:50 ` [PROTO][PATCH 08/10] drm: rcar-du: lvds: Handle LVDS interface reset Ulrich Hecht 2018-08-14 13:50 ` Ulrich Hecht 2018-08-14 13:50 ` [PROTO][PATCH 09/10] arm64: dts: renesas: r8a77995: Add LVDS support Ulrich Hecht 2018-08-14 13:50 ` Ulrich Hecht 2018-08-14 13:50 ` [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Ulrich Hecht 2018-08-14 13:50 ` Ulrich Hecht 2018-08-20 11:01 ` Laurent Pinchart [this message] 2018-08-20 11:01 ` Laurent Pinchart 2018-08-20 9:50 ` [PROTO][PATCH 00/10] R-Car D3 LVDS/HDMI support (with PLL) Laurent Pinchart 2018-08-20 9:50 ` Laurent Pinchart 2018-08-21 8:02 ` Ulrich Hecht 2018-08-21 8:02 ` Ulrich Hecht
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=80779849.cAp1Gtn18s@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=uli+renesas@fpond.eu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.