All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/6] drm/fb-helper: Remove damage worker
@ 2022-11-15 11:58 Thomas Zimmermann
  2022-11-15 11:58 ` [PATCH v2 1/6] drm/fb-helper: Set damage-clip area in helper Thomas Zimmermann
                   ` (5 more replies)
  0 siblings, 6 replies; 18+ messages in thread
From: Thomas Zimmermann @ 2022-11-15 11:58 UTC (permalink / raw)
  To: daniel, airlied, javierm, mripard, maarten.lankhorst
  Cc: Thomas Zimmermann, dri-devel

The fbdev emulation runs a separate worker that collects all changes
to the framebuffer and runs DRM damage handling. But this can also be
performed by the worker of fbdev's deferred-I/O code. Move damage
handling there, remove the damage worker and reduce the latency.

I ran a simple benchmark with mplayer and Big Buck Bunny [1] on the
console to look for any changes in performance.

  mplayer -nosound -vo fbdev -benchmark big_buck_bunny_1080p_surround.avi

On my test system (i7-4790, simpledrm, 1024x768), this command always
takes around 95 seconds (57% VC, 36% VO, 7% sys). The difference in
internal scheduling appears to have no impact on performance.

v2:
	* keep drm_fb_helper_damage() (Daniel)
	* fix function names (Daniel)
	* clarify comments (Daniel)
	* split patch #3 (Daniel)

[1] https://download.blender.org/peach/bigbuckbunny_movies/big_buck_bunny_1080p_surround.avi

Thomas Zimmermann (6):
  drm/fb-helper: Set damage-clip area in helper
  drm/fb-helper: Move dirty-fb update into helper function
  drm/fb-helper: Remove test for fb_dirty callback from deferred-I/O
    helper
  drm/fb-helper: Perform damage handling in deferred-I/O helper
  drm/fb-helper: Schedule deferred-I/O worker after writing to
    framebuffer
  drm/fb-helper: Remove damage worker

 drivers/gpu/drm/drm_fb_helper.c     | 53 ++++++++++++++++++-----------
 drivers/video/fbdev/core/fb_defio.c | 16 +++++++++
 include/drm/drm_fb_helper.h         |  2 --
 include/linux/fb.h                  |  1 +
 4 files changed, 51 insertions(+), 21 deletions(-)


base-commit: 2cc304afd4967ceffd14940ff73a8beb31778f90
-- 
2.38.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2022-12-05 14:11 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15 11:58 [PATCH v2 0/6] drm/fb-helper: Remove damage worker Thomas Zimmermann
2022-11-15 11:58 ` [PATCH v2 1/6] drm/fb-helper: Set damage-clip area in helper Thomas Zimmermann
2022-11-15 11:58 ` [PATCH v2 2/6] drm/fb-helper: Move dirty-fb update into helper function Thomas Zimmermann
2022-11-15 11:58 ` [PATCH v2 3/6] drm/fb-helper: Remove test for fb_dirty callback from deferred-I/O helper Thomas Zimmermann
2022-11-15 11:58 ` [PATCH v2 4/6] drm/fb-helper: Perform damage handling in " Thomas Zimmermann
2022-11-15 11:58 ` [PATCH v2 5/6] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer Thomas Zimmermann
2022-11-15 20:35   ` kernel test robot
2022-11-15 20:35     ` kernel test robot
2022-11-16  8:48     ` Thomas Zimmermann
     [not found]   ` <CGME20221117125800eucas1p29bc0adbe623ca0c42e903e771bf68b33@eucas1p2.samsung.com>
2022-11-17 12:57     ` [v2,5/6] " Marek Szyprowski
2022-11-17 12:57       ` Marek Szyprowski
2022-11-17 16:07       ` Thomas Zimmermann
2022-11-17 16:07         ` Thomas Zimmermann
2022-11-17 17:21         ` Marek Szyprowski
2022-11-17 17:21           ` Marek Szyprowski
2022-12-05 14:10           ` Marek Szyprowski
2022-12-05 14:10             ` Marek Szyprowski
2022-11-15 11:58 ` [PATCH v2 6/6] drm/fb-helper: Remove damage worker Thomas Zimmermann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.