From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "linux@roeck-us.net" <linux@roeck-us.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wambui.karugax@gmail.com" <wambui.karugax@gmail.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>
Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN
Date: Tue, 4 Feb 2020 00:54:26 +0000 [thread overview]
Message-ID: <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <20191202181505.GA732872@kroah.com>
Hi Greg & All,
On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote:
> > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote:
> > > > The code doesn't compile due to incompatible pointer errors
> > > > such as
> > > >
> > > > drivers/staging/octeon/ethernet-tx.c:649:50: error:
> > > > passing argument 1 of 'cvmx_wqe_get_grp' from
> > > > incompatible pointer type
> > > >
> > > > This is due to mixing, for example, cvmx_wqe_t with 'struct
> > > > cvmx_wqe'.
> > > >
> > > > Unfortunately, one can not just revert the primary offending
> > > > commit, as doing so
> > > > results in secondary errors. This is made worse by the fact
> > > > that the "removed"
> > > > typedefs still exist and are used widely outside the staging
> > > > directory,
> > > > making the entire set of "remove typedef" changes pointless and
> > > > wrong.
> > >
> > > Ugh, sorry about that.
> > >
> > > > Reflect reality and mark the driver as BROKEN.
> > >
> > > Should I just delete this thing? No one seems to be using it and
> > > there
> > > is no move to get it out of staging at all.
> > >
> > > Will anyone actually miss it? It can always come back of someone
> > > does...
> > >
> >
> > All it does is causing trouble and misguided attempts to clean it
> > up.
> > If anything, the whole thing goes into the wrong direction (declare
> > a
> > complete set of dummy functions just to be able to build the driver
> > with COMPILE_TEST ? Seriously ?).
> >
> > I second the motion to drop it. This has been in staging for 10
> > years.
> > Don't we have some kind of time limit for code in staging ? If not,
> > should we ? If anyone really needs it, that person or group should
> > really invest the time to get it out of staging for good.
>
> 10 years? Ugh, yes, it's time to drop the thing, I'll do so after
> -rc1
> is out.
>
As a long suffering Cavium MIPs customer could I request that this
isn't dropped. I'll get someone here to take a look at fixing the build
issues.
Given our platform isn't upstream I'm not sure that we'll be able to
meet the criteria for getting it out of staging.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "linux@roeck-us.net" <linux@roeck-us.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"julia.lawall@lip6.fr" <julia.lawall@lip6.fr>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wambui.karugax@gmail.com" <wambui.karugax@gmail.com>
Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN
Date: Tue, 4 Feb 2020 00:54:26 +0000 [thread overview]
Message-ID: <8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <20191202181505.GA732872@kroah.com>
Hi Greg & All,
On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote:
> > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote:
> > > > The code doesn't compile due to incompatible pointer errors
> > > > such as
> > > >
> > > > drivers/staging/octeon/ethernet-tx.c:649:50: error:
> > > > passing argument 1 of 'cvmx_wqe_get_grp' from
> > > > incompatible pointer type
> > > >
> > > > This is due to mixing, for example, cvmx_wqe_t with 'struct
> > > > cvmx_wqe'.
> > > >
> > > > Unfortunately, one can not just revert the primary offending
> > > > commit, as doing so
> > > > results in secondary errors. This is made worse by the fact
> > > > that the "removed"
> > > > typedefs still exist and are used widely outside the staging
> > > > directory,
> > > > making the entire set of "remove typedef" changes pointless and
> > > > wrong.
> > >
> > > Ugh, sorry about that.
> > >
> > > > Reflect reality and mark the driver as BROKEN.
> > >
> > > Should I just delete this thing? No one seems to be using it and
> > > there
> > > is no move to get it out of staging at all.
> > >
> > > Will anyone actually miss it? It can always come back of someone
> > > does...
> > >
> >
> > All it does is causing trouble and misguided attempts to clean it
> > up.
> > If anything, the whole thing goes into the wrong direction (declare
> > a
> > complete set of dummy functions just to be able to build the driver
> > with COMPILE_TEST ? Seriously ?).
> >
> > I second the motion to drop it. This has been in staging for 10
> > years.
> > Don't we have some kind of time limit for code in staging ? If not,
> > should we ? If anyone really needs it, that person or group should
> > really invest the time to get it out of staging for good.
>
> 10 years? Ugh, yes, it's time to drop the thing, I'll do so after
> -rc1
> is out.
>
As a long suffering Cavium MIPs customer could I request that this
isn't dropped. I'll get someone here to take a look at fixing the build
issues.
Given our platform isn't upstream I'm not sure that we'll be able to
meet the criteria for getting it out of staging.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-02-04 0:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 14:18 [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Guenter Roeck
2019-12-02 14:18 ` Guenter Roeck
2019-12-02 16:52 ` Greg Kroah-Hartman
2019-12-02 16:52 ` Greg Kroah-Hartman
2019-12-02 17:36 ` Guenter Roeck
2019-12-02 17:36 ` Guenter Roeck
2019-12-02 18:15 ` Greg Kroah-Hartman
2019-12-02 18:15 ` Greg Kroah-Hartman
2020-02-04 0:54 ` Chris Packham [this message]
2020-02-04 0:54 ` Chris Packham
2020-02-04 7:36 ` gregkh
2020-02-04 7:36 ` gregkh
2020-02-04 20:03 ` Chris Packham
2020-02-04 20:03 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8168627a60e9e851860f8cc295498423828401c9.camel@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.