* [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0
@ 2019-09-02 11:53 Zheng Ruoqin
2019-09-03 20:45 ` Mark Asselstine
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Ruoqin @ 2019-09-02 11:53 UTC (permalink / raw)
To: meta-virtualization
Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
---
.../python/python-glanceclient_git.bb | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
index 00ea2ab..e828cba 100644
--- a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
+++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
@@ -3,22 +3,20 @@ HOMEPAGE = "https://github.com/openstack/python-glanceclient"
SECTION = "devel/python"
LICENSE = "Apache-2.0"
LIC_FILES_CHKSUM = "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
+SRC_URI = "git://github.com/openstack/python-glanceclient.git \
+ file://glance-api-check.sh \
+ "
+
+PV = "2.16.0+git${SRCPV}"
+SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
+S = "${WORKDIR}/git"
+
DEPENDS += " \
gmp \
python-pip \
python-pbr \
"
-SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
-PV = "2.8.0+git${SRCPV}"
-
-SRC_URI = "\
- git://github.com/openstack/${BPN}.git;branch=stable/pike \
- file://glance-api-check.sh \
- "
-
-S = "${WORKDIR}/git"
-
inherit setuptools monitor rmargparse
FILES_${PN} += "${datadir}/${SRCNAME}"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0
2019-09-02 11:53 [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0 Zheng Ruoqin
@ 2019-09-03 20:45 ` Mark Asselstine
2019-09-03 23:52 ` Zheng, Ruoqin
0 siblings, 1 reply; 4+ messages in thread
From: Mark Asselstine @ 2019-09-03 20:45 UTC (permalink / raw)
To: Zheng Ruoqin; +Cc: meta-virtualization
On Mon, Sep 2, 2019 at 7:53 AM Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com> wrote:
>
> Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> ---
> .../python/python-glanceclient_git.bb | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> index 00ea2ab..e828cba 100644
> --- a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> +++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> @@ -3,22 +3,20 @@ HOMEPAGE = "https://github.com/openstack/python-glanceclient"
> SECTION = "devel/python"
> LICENSE = "Apache-2.0"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
> +SRC_URI = "git://github.com/openstack/python-glanceclient.git \
> + file://glance-api-check.sh \
> + "
> +
> +PV = "2.16.0+git${SRCPV}"
> +SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
> +S = "${WORKDIR}/git"
> +
> DEPENDS += " \
> gmp \
> python-pip \
> python-pbr \
> "
>
> -SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
> -PV = "2.8.0+git${SRCPV}"
> -
> -SRC_URI = "\
> - git://github.com/openstack/${BPN}.git;branch=stable/pike \
> - file://glance-api-check.sh \
> - "
> -
> -S = "${WORKDIR}/git"
What's with the extra churn here? Was the moving around of lines
deliberate, if so it needs to be covered in the long log. If not you
should avoid this as it is similar to mixing real changes and non-real
changes, it only serves to make the review more difficult.
MarkA
> -
> inherit setuptools monitor rmargparse
>
> FILES_${PN} += "${datadir}/${SRCNAME}"
> --
> 2.17.1
>
>
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0
2019-09-03 20:45 ` Mark Asselstine
@ 2019-09-03 23:52 ` Zheng, Ruoqin
2019-09-05 12:56 ` Mark Asselstine
0 siblings, 1 reply; 4+ messages in thread
From: Zheng, Ruoqin @ 2019-09-03 23:52 UTC (permalink / raw)
To: mark.asselstine; +Cc: meta-virtualization
To Mark
> What's with the extra churn here? Was the moving around of lines deliberate, if
> so it needs to be covered in the long log. If not you should avoid this as it is similar
> to mixing real changes and non-real changes, it only serves to make the review
> more difficult.
>
> MarkA
Sorry，I will be careful next time.
--------------------------------------------------
Zheng Ruoqin
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
ADDR.: No.6 Wenzhu Road, Software Avenue,
Nanjing, 210012, China
MAIL : zhengrq.fnst@cn.fujistu.com
> -----Original Message-----
> From: Mark Asselstine [mailto:mark.asselstine@windriver.com]
> Sent: Wednesday, September 04, 2019 4:46 AM
> To: Zheng, Ruoqin/郑 若钦 <zhengrq.fnst@cn.fujitsu.com>
> Cc: meta-virtualization <meta-virtualization@yoctoproject.org>
> Subject: Re: [meta-virtualization] [PATCH] python-glanceclient: upgrade 2.8.0 ->
> 2.16.0
>
> On Mon, Sep 2, 2019 at 7:53 AM Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> wrote:
> >
> > Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> > ---
> > .../python/python-glanceclient_git.bb | 18 ++++++++----------
> > 1 file changed, 8 insertions(+), 10 deletions(-)
> >
> > diff --git
> > a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > index 00ea2ab..e828cba 100644
> > ---
> > a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > +++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.b
> > +++ b
> > @@ -3,22 +3,20 @@ HOMEPAGE = "https://github.com/openstack/python-
> glanceclient"
> > SECTION = "devel/python"
> > LICENSE = "Apache-2.0"
> > LIC_FILES_CHKSUM =
> "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
> > +SRC_URI = "git://github.com/openstack/python-glanceclient.git \
> > + file://glance-api-check.sh \
> > + "
> > +
> > +PV = "2.16.0+git${SRCPV}"
> > +SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
> > +S = "${WORKDIR}/git"
> > +
> > DEPENDS += " \
> > gmp \
> > python-pip \
> > python-pbr \
> > "
> >
> > -SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
> > -PV = "2.8.0+git${SRCPV}"
> > -
> > -SRC_URI = "\
> > - git://github.com/openstack/${BPN}.git;branch=stable/pike \
> > - file://glance-api-check.sh \
> > - "
> > -
> > -S = "${WORKDIR}/git"
>
> What's with the extra churn here? Was the moving around of lines deliberate, if
> so it needs to be covered in the long log. If not you should avoid this as it is similar
> to mixing real changes and non-real changes, it only serves to make the review
> more difficult.
>
> MarkA
>
> > -
> > inherit setuptools monitor rmargparse
> >
> > FILES_${PN} += "${datadir}/${SRCNAME}"
> > --
> > 2.17.1
> >
> >
> >
> > --
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0
2019-09-03 23:52 ` Zheng, Ruoqin
@ 2019-09-05 12:56 ` Mark Asselstine
0 siblings, 0 replies; 4+ messages in thread
From: Mark Asselstine @ 2019-09-05 12:56 UTC (permalink / raw)
To: Zheng, Ruoqin; +Cc: meta-virtualization
On Tuesday, September 3, 2019 7:52:55 P.M. EDT Zheng, Ruoqin wrote:
> To Mark
>
>
> > What's with the extra churn here? Was the moving around of lines
> > deliberate, if
so it needs to be covered in the long log. If not you
> > should avoid this as it is similar to mixing real changes and non-real
> > changes, it only serves to make the review more difficult.
> >
> > MarkA
>
>
> Sorry，I will be careful next time.
np. Thanks for keeping this in mind in the future.
MarkA
>
> --------------------------------------------------
> Zheng Ruoqin
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
> ADDR.: No.6 Wenzhu Road, Software Avenue,
> Nanjing, 210012, China
> MAIL : zhengrq.fnst@cn.fujistu.com
>
>
>
> > -----Original Message-----
> > From: Mark Asselstine [mailto:mark.asselstine@windriver.com]
> > Sent: Wednesday, September 04, 2019 4:46 AM
> > To: Zheng, Ruoqin/郑 若钦 <zhengrq.fnst@cn.fujitsu.com>
> > Cc: meta-virtualization <meta-virtualization@yoctoproject.org>
> > Subject: Re: [meta-virtualization] [PATCH] python-glanceclient: upgrade
> > 2.8.0 ->
2.16.0
> >
> > On Mon, Sep 2, 2019 at 7:53 AM Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> > wrote:
> >
> > >
> > >
> > > Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com>
> > > ---
> > >
> > > .../python/python-glanceclient_git.bb | 18 ++++++++----------
> > > 1 file changed, 8 insertions(+), 10 deletions(-)
> > >
> > >
> > >
> > > diff --git
> > > a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > > b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > > index 00ea2ab..e828cba 100644
> > > ---
> > > a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> > > +++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.b
> > > +++ b
> > > @@ -3,22 +3,20 @@ HOMEPAGE = "https://github.com/openstack/python-> >
> > glanceclient"
> >
> > > SECTION = "devel/python"
> > > LICENSE = "Apache-2.0"
> > > LIC_FILES_CHKSUM =
> >
> > "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
> >
> > > +SRC_URI = "git://github.com/openstack/python-glanceclient.git \
> > > + file://glance-api-check.sh \
> > > + "
> > > +
> > > +PV = "2.16.0+git${SRCPV}"
> > > +SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
> > > +S = "${WORKDIR}/git"
> > > +
> > >
> > > DEPENDS += " \
> > >
> > > gmp \
> > > python-pip \
> > > python-pbr \
> > > "
> > >
> > >
> > >
> > > -SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
> > > -PV = "2.8.0+git${SRCPV}"
> > > -
> > > -SRC_URI = "\
> > > - git://github.com/openstack/${BPN}.git;branch=stable/pike \
> > > - file://glance-api-check.sh \
> > > - "
> > > -
> > > -S = "${WORKDIR}/git"
> >
> >
> > What's with the extra churn here? Was the moving around of lines
> > deliberate, if
so it needs to be covered in the long log. If not you
> > should avoid this as it is similar to mixing real changes and non-real
> > changes, it only serves to make the review more difficult.
> >
> > MarkA
> >
> >
> > > -
> > >
> > > inherit setuptools monitor rmargparse
> > >
> > >
> > >
> > > FILES_${PN} += "${datadir}/${SRCNAME}"
> > >
> > > --
> > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> > > --
> > > _______________________________________________
> > > meta-virtualization mailing list
> > > meta-virtualization@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-05 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 11:53 [PATCH] python-glanceclient: upgrade 2.8.0 -> 2.16.0 Zheng Ruoqin
2019-09-03 20:45 ` Mark Asselstine
2019-09-03 23:52 ` Zheng, Ruoqin
2019-09-05 12:56 ` Mark Asselstine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.