Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Randy Dunlap]

Ricardo Maraschini wrote:
> --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300
> +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300
> @@ -1401,7 +1401,8 @@
>        case CX88_BOARD_SAMSUNG_SMT_7020:
>                dev->ts_gen_cntrl = 0x08;
> 
> -               struct cx88_core *core = dev->core;
> +               struct cx88_core *core;
> +               core = dev->core;
> 
>                cx_set(MO_GP0_IO, 0x0101);
> 
> 
> 
> Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
> 
> 
> For any comments, please CC me in the message. I am waiting moderator
> approval to subscribe to this mailing list
> --

Hi,

Did you test this patch (by building this driver)?
I think not.

Also, the Signed-off-by: line should be before the patch, not after it.

~Randy

[PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Ricardo Maraschini]

--- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300
+++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300
@@ -1401,7 +1401,8 @@
       case CX88_BOARD_SAMSUNG_SMT_7020:
               dev->ts_gen_cntrl = 0x08;

-               struct cx88_core *core = dev->core;
+               struct cx88_core *core;
+               core = dev->core;

               cx_set(MO_GP0_IO, 0x0101);



Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>


For any comments, please CC me in the message. I am waiting moderator
approval to subscribe to this mailing list

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Devin Heitmueller]

On Tue, Mar 23, 2010 at 4:42 PM, Ricardo Maraschini <xrmarsx@gmail.com> wrote:
> --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300
> +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300
> @@ -1401,7 +1401,8 @@
>       case CX88_BOARD_SAMSUNG_SMT_7020:
>               dev->ts_gen_cntrl = 0x08;
>
> -               struct cx88_core *core = dev->core;
> +               struct cx88_core *core;
> +               core = dev->core;
>
>               cx_set(MO_GP0_IO, 0x0101);
>
>
>
> Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>

How do you think this actually addresses the warning in question?  You
still have the declaration of the variable in the middle of the switch
statement.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Ricardo Maraschini]

Hi Randy,

On Tue, Mar 23, 2010 at 4:45 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Did you test this patch (by building this driver)?
> I think not.

I tried to compile with the patch, but in a wrong way. Sorry.
I'm going to adjust the patch and send again.

> Also, the Signed-off-by: line should be before the patch, not after it.

Thanks, I will remember this.

-rm

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Ricardo Maraschini]

On Tue, Mar 23, 2010 at 5:48 PM, Devin Heitmueller
<dheitmueller@kernellabs.com> wrote:
> How do you think this actually addresses the warning in question?  You
> still have the declaration of the variable in the middle of the switch
> statement.

My mistake, sorry. I'm working on it.
Thanks for your tip, I really appreciate that.

-rm

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Ricardo Maraschini]

Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>

--- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300
+++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300
@@ -1401,8 +1401,6 @@
        case CX88_BOARD_SAMSUNG_SMT_7020:
                dev->ts_gen_cntrl = 0x08;

-               struct cx88_core *core = dev->core;
-
                cx_set(MO_GP0_IO, 0x0101);

                cx_clear(MO_GP0_IO, 0x01);

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Douglas Schilling Landgraf]

Hello Ricardo,

On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini <xrmarsx@gmail.com> wrote:
> Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
>
> --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300
> +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300
> @@ -1401,8 +1401,6 @@
>        case CX88_BOARD_SAMSUNG_SMT_7020:
>                dev->ts_gen_cntrl = 0x08;
>
> -               struct cx88_core *core = dev->core;
> -
>                cx_set(MO_GP0_IO, 0x0101);
>
>                cx_clear(MO_GP0_IO, 0x01);
>

This version seems ok to my eyes.

Thanks
Douglas

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

[Hans Verkuil]

On Wednesday 24 March 2010 14:45:50 Douglas Schilling Landgraf wrote:
> Hello Ricardo,
> 
> On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini <xrmarsx@gmail.com> wrote:
> > Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
> >
> > --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300
> > +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300
> > @@ -1401,8 +1401,6 @@
> >        case CX88_BOARD_SAMSUNG_SMT_7020:
> >                dev->ts_gen_cntrl = 0x08;
> >
> > -               struct cx88_core *core = dev->core;
> > -
> >                cx_set(MO_GP0_IO, 0x0101);
> >
> >                cx_clear(MO_GP0_IO, 0x01);
> >
> 
> This version seems ok to my eyes.

And also to my eyes.

Mauro, can you please merge this? This patch didn't turn up in patchwork for
some reason.

This will fix an annoying compile warning.

Regards,

	Hans

> 
> Thanks
> Douglas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG