All of lore.kernel.org
 help / color / mirror / Atom feed
From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
	Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
	Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
	Louis-Alexandre Stuber 
	<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
	Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>,
	Stefan Beller <sbeller@google.com>,
	Philip Oakley <philipoakley@iee.org>
Subject: Re: [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits
Date: Tue, 2 Jun 2015 15:51:03 +0200 (CEST)	[thread overview]
Message-ID: <829387582.31753.1433253063381.JavaMail.zimbra@ensimag.grenoble-inp.fr> (raw)
In-Reply-To: <CAPig+cQF6irJqYFZ=2YSevjF+ySUn25udYMKSg+VzXP0p0-eAw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes: 
> Although the underlying behavior of "ignore" may be the same as the 
> default, you also want to check that higher-level machinery for 
> recognizing the "ignore" option is working correctly, which is why 
> checking "ignore" explicitly is a reasonable thing to do. 

Noted, I'm adding a test for "ignore". 

Thank you, 

Rémi 

  reply	other threads:[~2015-06-02 13:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 11:52 [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-01 11:52 ` [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-01 23:16   ` Eric Sunshine
2015-06-01 23:17     ` Eric Sunshine
2015-06-02  7:42     ` Remi Galan Alfonso
2015-06-02 13:41       ` Eric Sunshine
2015-06-02 13:51         ` Remi Galan Alfonso [this message]
2015-06-02  6:40   ` Matthieu Moy
2015-06-02  9:23     ` Remi Galan Alfonso
2015-06-02 17:17     ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2015-06-03 11:44 [PATCH/RFCv4 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-03 11:44 ` [PATCH/RFCv4 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-03 19:14   ` [PATCH/RFCv2 " Eric Sunshine
2015-06-03 20:09     ` Remi Galan Alfonso
2015-06-06 23:45       ` Remi Galan Alfonso
2015-06-01  9:57 [PATCH/RFCv2 0/2] rebase -i : drop command and " Galan Rémi
2015-06-01  9:57 ` [PATCH/RFCv2 2/2] git rebase -i: warn about " Galan Rémi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=829387582.31753.1433253063381.JavaMail.zimbra@ensimag.grenoble-inp.fr \
    --to=remi.galan-alfonso@ensimag.grenoble-inp.fr \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=antoine.delaite@ensimag.grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=guillaume.pages@ensimag.grenoble-inp.fr \
    --cc=johannes.schindelin@gmx.de \
    --cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
    --cc=philipoakley@iee.org \
    --cc=remi.lespinet@ensimag.grenoble-inp.fr \
    --cc=sbeller@google.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.