From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
To: Git List <git@vger.kernel.org>
Cc: Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
Guillaume Pages <guillaume.pages@ensimag.grenoble-inp.fr>,
Louis-Alexandre Stuber
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits
Date: Sun, 7 Jun 2015 01:45:34 +0200 (CEST) [thread overview]
Message-ID: <876005532.186122.1433634334986.JavaMail.zimbra@ensimag.grenoble-inp.fr> (raw)
In-Reply-To: <1105867541.79324.1433362150592.JavaMail.zimbra@ensimag.grenoble-inp.fr>
I'm going to try to change the die_abort in this patch by a die, so
that the user can use rebase --edit-todo afterward. This way, adding
the checking on the SHA-1 for the 'drop' command (discussed in 1/2)
(and also maybe the other commands requiring a correct SHA-1
corresponding to a commit) to the 2/2 part would make a bit more
sense. Though I still see some other issues with this, I agree that it
makes more sense in 2/2 rather than in 1/2 (some more checking in a
future patch would be a good idea).
(So far I've tried rather quickly, but it doesn't seem as easy as I
originally though, working on it though)
Rémi
next prev parent reply other threads:[~2015-06-06 23:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 11:44 [PATCH/RFCv4 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-03 11:44 ` [PATCH/RFCv4 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-03 12:48 ` Remi Galan Alfonso
2015-06-03 17:38 ` Matthieu Moy
2015-06-03 17:53 ` Remi Galan Alfonso
2015-06-03 18:06 ` Matthieu Moy
2015-06-03 19:14 ` [PATCH/RFCv2 " Eric Sunshine
2015-06-03 20:09 ` Remi Galan Alfonso
2015-06-06 23:45 ` Remi Galan Alfonso [this message]
2015-06-03 18:02 ` [PATCH/RFCv4 1/2] git-rebase -i: add command "drop" to remove a commit Junio C Hamano
2015-06-03 19:23 ` Remi Galan Alfonso
-- strict thread matches above, loose matches on Subject: below --
2015-06-01 11:52 [PATCH/RFCv2 " Galan Rémi
2015-06-01 11:52 ` [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-01 23:16 ` Eric Sunshine
2015-06-01 23:17 ` Eric Sunshine
2015-06-02 7:42 ` Remi Galan Alfonso
2015-06-02 13:41 ` Eric Sunshine
2015-06-02 13:51 ` Remi Galan Alfonso
2015-06-02 6:40 ` Matthieu Moy
2015-06-02 9:23 ` Remi Galan Alfonso
2015-06-02 17:17 ` Junio C Hamano
2015-06-01 9:57 [PATCH/RFCv2 0/2] rebase -i : drop command and " Galan Rémi
2015-06-01 9:57 ` [PATCH/RFCv2 2/2] git rebase -i: warn about " Galan Rémi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876005532.186122.1433634334986.JavaMail.zimbra@ensimag.grenoble-inp.fr \
--to=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.