* [PATCH] xen, fbfront: fix connecting to backend
@ 2017-03-23 12:52 ` Juergen Gross
0 siblings, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-03-23 12:52 UTC (permalink / raw)
To: linux-kernel, xen-devel, linux-fbdev
Cc: b.zolnierkie, boris.ostrovsky, Juergen Gross, stable
Connecting to the backend isn't working reliably in xen-fbfront: in
case XenbusStateInitWait of the backend has been missed the backend
transition to XenbusStateConnected will trigger the connected state
only without doing the actions required when the backend has
connected.
Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/video/fbdev/xen-fbfront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index d0115a7..3ee309c 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
break;
case XenbusStateInitWait:
-InitWait:
xenbus_switch_state(dev, XenbusStateConnected);
break;
@@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
* get Connected twice here.
*/
if (dev->state != XenbusStateConnected)
- goto InitWait; /* no InitWait seen yet, fudge it */
+ /* no InitWait seen yet, fudge it */
+ xenbus_switch_state(dev, XenbusStateConnected);
if (xenbus_read_unsigned(info->xbdev->otherend,
"request-update", 0))
--
2.10.2
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 12:52 ` Juergen Gross
(?)
@ 2017-03-23 13:37 ` Jan Beulich
-1 siblings, 0 replies; 23+ messages in thread
From: Jan Beulich @ 2017-03-23 13:37 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, boris.ostrovsky, b.zolnierkie, linux-fbdev,
linux-kernel, stable
>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
Looks like xen-kbdfront does exactly the same - shouldn't it also be
changed then?
Jan
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-03-23 13:37 ` Jan Beulich
0 siblings, 0 replies; 23+ messages in thread
From: Jan Beulich @ 2017-03-23 13:37 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-fbdev, b.zolnierkie, linux-kernel, stable, xen-devel,
boris.ostrovsky
>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
Looks like xen-kbdfront does exactly the same - shouldn't it also be
changed then?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend
@ 2017-03-23 13:37 ` Jan Beulich
0 siblings, 0 replies; 23+ messages in thread
From: Jan Beulich @ 2017-03-23 13:37 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, boris.ostrovsky, b.zolnierkie, linux-fbdev,
linux-kernel, stable
>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
Looks like xen-kbdfront does exactly the same - shouldn't it also be
changed then?
Jan
^ permalink raw reply [flat|nested] 23+ messages in thread
[parent not found: <58D3DDB40200007800146C6B@suse.com>]
* Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend
[not found] ` <58D3DDB40200007800146C6B@suse.com>
@ 2017-03-23 13:56 ` Juergen Gross
2017-03-23 13:56 ` Juergen Gross
1 sibling, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-03-23 13:56 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel, boris.ostrovsky, b.zolnierkie, linux-fbdev,
linux-kernel, stable
On 23/03/17 14:37, Jan Beulich wrote:
>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
>> Connecting to the backend isn't working reliably in xen-fbfront: in
>> case XenbusStateInitWait of the backend has been missed the backend
>> transition to XenbusStateConnected will trigger the connected state
>> only without doing the actions required when the backend has
>> connected.
>
> Looks like xen-kbdfront does exactly the same - shouldn't it also be
> changed then?
I posted that patch 2 days ago. :-)
Juergen
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend
@ 2017-03-23 13:56 ` Juergen Gross
0 siblings, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-03-23 13:56 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel, boris.ostrovsky, b.zolnierkie, linux-fbdev,
linux-kernel, stable
On 23/03/17 14:37, Jan Beulich wrote:
>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
>> Connecting to the backend isn't working reliably in xen-fbfront: in
>> case XenbusStateInitWait of the backend has been missed the backend
>> transition to XenbusStateConnected will trigger the connected state
>> only without doing the actions required when the backend has
>> connected.
>
> Looks like xen-kbdfront does exactly the same - shouldn't it also be
> changed then?
I posted that patch 2 days ago. :-)
Juergen
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 13:56 ` Juergen Gross
(?)
@ 2017-03-23 14:21 ` Jan Beulich
-1 siblings, 0 replies; 23+ messages in thread
From: Jan Beulich @ 2017-03-23 14:21 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-fbdev, b.zolnierkie, linux-kernel, stable, xen-devel,
boris.ostrovsky
>>> On 23.03.17 at 14:56, <jgross@suse.com> wrote:
> On 23/03/17 14:37, Jan Beulich wrote:
>>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
>>> Connecting to the backend isn't working reliably in xen-fbfront: in
>>> case XenbusStateInitWait of the backend has been missed the backend
>>> transition to XenbusStateConnected will trigger the connected state
>>> only without doing the actions required when the backend has
>>> connected.
>>
>> Looks like xen-kbdfront does exactly the same - shouldn't it also be
>> changed then?
>
> I posted that patch 2 days ago. :-)
Oh, I'm sorry - the completely different title misguided me.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 13:56 ` Juergen Gross
@ 2017-03-23 14:21 ` Jan Beulich
-1 siblings, 0 replies; 23+ messages in thread
From: Jan Beulich @ 2017-03-23 14:21 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, boris.ostrovsky, b.zolnierkie, linux-fbdev,
linux-kernel, stable
>>> On 23.03.17 at 14:56, <jgross@suse.com> wrote:
> On 23/03/17 14:37, Jan Beulich wrote:
>>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
>>> Connecting to the backend isn't working reliably in xen-fbfront: in
>>> case XenbusStateInitWait of the backend has been missed the backend
>>> transition to XenbusStateConnected will trigger the connected state
>>> only without doing the actions required when the backend has
>>> connected.
>>
>> Looks like xen-kbdfront does exactly the same - shouldn't it also be
>> changed then?
>
> I posted that patch 2 days ago. :-)
Oh, I'm sorry - the completely different title misguided me.
Jan
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Xen-devel] [PATCH] xen, fbfront: fix connecting to backend
@ 2017-03-23 14:21 ` Jan Beulich
0 siblings, 0 replies; 23+ messages in thread
From: Jan Beulich @ 2017-03-23 14:21 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, boris.ostrovsky, b.zolnierkie, linux-fbdev,
linux-kernel, stable
>>> On 23.03.17 at 14:56, <jgross@suse.com> wrote:
> On 23/03/17 14:37, Jan Beulich wrote:
>>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
>>> Connecting to the backend isn't working reliably in xen-fbfront: in
>>> case XenbusStateInitWait of the backend has been missed the backend
>>> transition to XenbusStateConnected will trigger the connected state
>>> only without doing the actions required when the backend has
>>> connected.
>>
>> Looks like xen-kbdfront does exactly the same - shouldn't it also be
>> changed then?
>
> I posted that patch 2 days ago. :-)
Oh, I'm sorry - the completely different title misguided me.
Jan
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
[not found] ` <58D3DDB40200007800146C6B@suse.com>
2017-03-23 13:56 ` Juergen Gross
@ 2017-03-23 13:56 ` Juergen Gross
1 sibling, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-03-23 13:56 UTC (permalink / raw)
To: Jan Beulich
Cc: linux-fbdev, b.zolnierkie, linux-kernel, stable, xen-devel,
boris.ostrovsky
On 23/03/17 14:37, Jan Beulich wrote:
>>>> On 23.03.17 at 13:52, <jgross@suse.com> wrote:
>> Connecting to the backend isn't working reliably in xen-fbfront: in
>> case XenbusStateInitWait of the backend has been missed the backend
>> transition to XenbusStateConnected will trigger the connected state
>> only without doing the actions required when the backend has
>> connected.
>
> Looks like xen-kbdfront does exactly the same - shouldn't it also be
> changed then?
I posted that patch 2 days ago. :-)
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 12:52 ` Juergen Gross
` (2 preceding siblings ...)
(?)
@ 2017-03-23 14:11 ` Boris Ostrovsky
-1 siblings, 0 replies; 23+ messages in thread
From: Boris Ostrovsky @ 2017-03-23 14:11 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel, linux-fbdev; +Cc: stable, b.zolnierkie
On 03/23/2017 08:52 AM, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 12:52 ` Juergen Gross
@ 2017-03-23 14:11 ` Boris Ostrovsky
-1 siblings, 0 replies; 23+ messages in thread
From: Boris Ostrovsky @ 2017-03-23 14:11 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel, linux-fbdev; +Cc: b.zolnierkie, stable
On 03/23/2017 08:52 AM, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-03-23 14:11 ` Boris Ostrovsky
0 siblings, 0 replies; 23+ messages in thread
From: Boris Ostrovsky @ 2017-03-23 14:11 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel, linux-fbdev; +Cc: b.zolnierkie, stable
On 03/23/2017 08:52 AM, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 14:11 ` Boris Ostrovsky
(?)
@ 2017-04-07 15:27 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 23+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-07 15:27 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross
Cc: xen-devel, linux-fbdev, linux-kernel, stable
On Thursday, March 23, 2017 10:11:12 AM Boris Ostrovsky wrote:
> On 03/23/2017 08:52 AM, Juergen Gross wrote:
> > Connecting to the backend isn't working reliably in xen-fbfront: in
> > case XenbusStateInitWait of the backend has been missed the backend
> > transition to XenbusStateConnected will trigger the connected state
> > only without doing the actions required when the backend has
> > connected.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Patch queued for 4.11, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 14:11 ` Boris Ostrovsky
@ 2017-04-07 15:27 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 23+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-07 15:27 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross
Cc: linux-kernel, xen-devel, linux-fbdev, stable
On Thursday, March 23, 2017 10:11:12 AM Boris Ostrovsky wrote:
> On 03/23/2017 08:52 AM, Juergen Gross wrote:
> > Connecting to the backend isn't working reliably in xen-fbfront: in
> > case XenbusStateInitWait of the backend has been missed the backend
> > transition to XenbusStateConnected will trigger the connected state
> > only without doing the actions required when the backend has
> > connected.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Patch queued for 4.11, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-04-07 15:27 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 23+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-07 15:27 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross
Cc: linux-kernel, xen-devel, linux-fbdev, stable
On Thursday, March 23, 2017 10:11:12 AM Boris Ostrovsky wrote:
> On 03/23/2017 08:52 AM, Juergen Gross wrote:
> > Connecting to the backend isn't working reliably in xen-fbfront: in
> > case XenbusStateInitWait of the backend has been missed the backend
> > transition to XenbusStateConnected will trigger the connected state
> > only without doing the actions required when the backend has
> > connected.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Patch queued for 4.11, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-03-23 12:52 ` Juergen Gross
(?)
@ 2017-04-05 8:18 ` Juergen Gross
-1 siblings, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-04-05 8:18 UTC (permalink / raw)
To: linux-kernel, xen-devel, linux-fbdev, b.zolnierkie
Cc: boris.ostrovsky, stable
On 23/03/17 13:52, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Bartlomiej, any comments? Can you please take this patch or should I
carry it through the Xen tree?
Juergen
> ---
> drivers/video/fbdev/xen-fbfront.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index d0115a7..3ee309c 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> break;
>
> case XenbusStateInitWait:
> -InitWait:
> xenbus_switch_state(dev, XenbusStateConnected);
> break;
>
> @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> * get Connected twice here.
> */
> if (dev->state != XenbusStateConnected)
> - goto InitWait; /* no InitWait seen yet, fudge it */
> + /* no InitWait seen yet, fudge it */
> + xenbus_switch_state(dev, XenbusStateConnected);
>
> if (xenbus_read_unsigned(info->xbdev->otherend,
> "request-update", 0))
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-04-05 8:18 ` Juergen Gross
0 siblings, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-04-05 8:18 UTC (permalink / raw)
To: linux-kernel, xen-devel, linux-fbdev, b.zolnierkie
Cc: boris.ostrovsky, stable
On 23/03/17 13:52, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Bartlomiej, any comments? Can you please take this patch or should I
carry it through the Xen tree?
Juergen
> ---
> drivers/video/fbdev/xen-fbfront.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index d0115a7..3ee309c 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> break;
>
> case XenbusStateInitWait:
> -InitWait:
> xenbus_switch_state(dev, XenbusStateConnected);
> break;
>
> @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> * get Connected twice here.
> */
> if (dev->state != XenbusStateConnected)
> - goto InitWait; /* no InitWait seen yet, fudge it */
> + /* no InitWait seen yet, fudge it */
> + xenbus_switch_state(dev, XenbusStateConnected);
>
> if (xenbus_read_unsigned(info->xbdev->otherend,
> "request-update", 0))
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-04-05 8:18 ` Juergen Gross
0 siblings, 0 replies; 23+ messages in thread
From: Juergen Gross @ 2017-04-05 8:18 UTC (permalink / raw)
To: linux-kernel, xen-devel, linux-fbdev, b.zolnierkie
Cc: boris.ostrovsky, stable
On 23/03/17 13:52, Juergen Gross wrote:
> Connecting to the backend isn't working reliably in xen-fbfront: in
> case XenbusStateInitWait of the backend has been missed the backend
> transition to XenbusStateConnected will trigger the connected state
> only without doing the actions required when the backend has
> connected.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
Bartlomiej, any comments? Can you please take this patch or should I
carry it through the Xen tree?
Juergen
> ---
> drivers/video/fbdev/xen-fbfront.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index d0115a7..3ee309c 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> break;
>
> case XenbusStateInitWait:
> -InitWait:
> xenbus_switch_state(dev, XenbusStateConnected);
> break;
>
> @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> * get Connected twice here.
> */
> if (dev->state != XenbusStateConnected)
> - goto InitWait; /* no InitWait seen yet, fudge it */
> + /* no InitWait seen yet, fudge it */
> + xenbus_switch_state(dev, XenbusStateConnected);
>
> if (xenbus_read_unsigned(info->xbdev->otherend,
> "request-update", 0))
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
2017-04-05 8:18 ` Juergen Gross
(?)
@ 2017-04-05 14:28 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 23+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-05 14:28 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-kernel, xen-devel, linux-fbdev, boris.ostrovsky, stable
Hi,
On Wednesday, April 05, 2017 10:18:21 AM Juergen Gross wrote:
> On 23/03/17 13:52, Juergen Gross wrote:
> > Connecting to the backend isn't working reliably in xen-fbfront: in
> > case XenbusStateInitWait of the backend has been missed the backend
> > transition to XenbusStateConnected will trigger the connected state
> > only without doing the actions required when the backend has
> > connected.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Bartlomiej, any comments? Can you please take this patch or should I
> carry it through the Xen tree?
Looks fine to me, I will queue it for 4.11 on Friday.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-04-05 14:28 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 23+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-05 14:28 UTC (permalink / raw)
To: Juergen Gross
Cc: boris.ostrovsky, xen-devel, linux-fbdev, linux-kernel, stable
Hi,
On Wednesday, April 05, 2017 10:18:21 AM Juergen Gross wrote:
> On 23/03/17 13:52, Juergen Gross wrote:
> > Connecting to the backend isn't working reliably in xen-fbfront: in
> > case XenbusStateInitWait of the backend has been missed the backend
> > transition to XenbusStateConnected will trigger the connected state
> > only without doing the actions required when the backend has
> > connected.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Bartlomiej, any comments? Can you please take this patch or should I
> carry it through the Xen tree?
Looks fine to me, I will queue it for 4.11 on Friday.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH] xen, fbfront: fix connecting to backend
@ 2017-04-05 14:28 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 23+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-04-05 14:28 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-kernel, xen-devel, linux-fbdev, boris.ostrovsky, stable
Hi,
On Wednesday, April 05, 2017 10:18:21 AM Juergen Gross wrote:
> On 23/03/17 13:52, Juergen Gross wrote:
> > Connecting to the backend isn't working reliably in xen-fbfront: in
> > case XenbusStateInitWait of the backend has been missed the backend
> > transition to XenbusStateConnected will trigger the connected state
> > only without doing the actions required when the backend has
> > connected.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Bartlomiej, any comments? Can you please take this patch or should I
> carry it through the Xen tree?
Looks fine to me, I will queue it for 4.11 on Friday.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 23+ messages in thread