All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration
@ 2019-11-06  0:06 ` Thomas Falcon
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Falcon @ 2019-11-06  0:06 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: netdev, nathanl, tyreld, msuchanek, Thomas Falcon

After a migration, it is necessary to send a gratuitous ARP
from all running interfaces so that the rest of the network
is aware of its new location. However, some supported network
devices are unaware that they have been migrated. To avoid network
interruptions and other unwanted behavior, force a GARP on all
valid, running interfaces as part of the post_mobility_fixup
routine.

Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
---
 arch/powerpc/platforms/pseries/mobility.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c
index b571285f6c14..c1abc14cf2bb 100644
--- a/arch/powerpc/platforms/pseries/mobility.c
+++ b/arch/powerpc/platforms/pseries/mobility.c
@@ -17,6 +17,9 @@
 #include <linux/delay.h>
 #include <linux/slab.h>
 #include <linux/stringify.h>
+#include <linux/netdevice.h>
+#include <linux/rtnetlink.h>
+#include <net/net_namespace.h>
 
 #include <asm/machdep.h>
 #include <asm/rtas.h>
@@ -331,6 +334,8 @@ void post_mobility_fixup(void)
 {
 	int rc;
 	int activate_fw_token;
+	struct net_device *netdev;
+	struct net *net;
 
 	activate_fw_token = rtas_token("ibm,activate-firmware");
 	if (activate_fw_token == RTAS_UNKNOWN_SERVICE) {
@@ -371,6 +376,21 @@ void post_mobility_fixup(void)
 	/* Possibly switch to a new RFI flush type */
 	pseries_setup_rfi_flush();
 
+	/* need to force a gratuitous ARP on running interfaces */
+	rtnl_lock();
+	for_each_net(net) {
+		for_each_netdev(net, netdev) {
+			if (netif_device_present(netdev) &&
+			    netif_running(netdev) &&
+			    !(netdev->flags & (IFF_NOARP | IFF_LOOPBACK)))
+				call_netdevice_notifiers(NETDEV_NOTIFY_PEERS,
+							 netdev);
+				call_netdevice_notifiers(NETDEV_RESEND_IGMP,
+							 netdev);
+		}
+	}
+	rtnl_unlock();
+
 	return;
 }
 
-- 
2.12.3


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-11-08 16:56 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06  0:06 [RFC PATCH] powerpc/pseries/mobility: notify network peers after migration Thomas Falcon
2019-11-06  0:06 ` Thomas Falcon
2019-11-06  4:13 ` Russell Currey
2019-11-06  4:47   ` Thomas Falcon
2019-11-06 22:14 ` Nathan Lynch
2019-11-06 22:14   ` Nathan Lynch
2019-11-07 21:30   ` Thomas Falcon
2019-11-07 21:30     ` Thomas Falcon
2019-11-07  1:33 ` Michael Ellerman
2019-11-07 21:16   ` Thomas Falcon
2019-11-07 21:44 ` kbuild test robot
2019-11-08 16:56 ` kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.