From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Mehta, Piyush" <piyush.mehta@amd.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"balbi@kernel.org" <balbi@kernel.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Paladugu,
Siva Durga Prasad" <siva.durga.prasad.paladugu@amd.com>,
Manish Narani <manish.narani@xilinx.com>
Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt
Date: Fri, 23 Sep 2022 11:34:31 +0200 [thread overview]
Message-ID: <83c104d1-6c09-1744-0621-a50a745a0744@amd.com> (raw)
In-Reply-To: <a127333d-cd25-4fa3-a12d-9c3cda05582f@linaro.org>
Hi Krzysztof,
On 9/23/22 11:22, Krzysztof Kozlowski wrote:
> On 23/09/2022 06:38, Mehta, Piyush wrote:
>>> Thanks,
>>> Michal
>>
>> Enabling wakeup in zynqMp we need to put the core into hibernation, as versal don't have hibernation concept, but we require interrupt for wakeup.
>> We have a versal platform where we are not using hibernation, but system wake up we need the interrupt. For this interrupt-name enum would be:
>> - enum [host, peripheral, otg, usb-wakeup]
>>
>> zynqMp :
>> - enum [host, peripheral, otg, hiber]
>>
>> Versal:
>> - enum [host, peripheral, otg, usb-wakeup]
>
> That's a different name you use now...
It is small confusion.
We have dwc3 in 3 SOCs. ZynqMP/Versal and Versal NET.
In ZynqMP currently we are define it as
interrupt-names = "dwc_usb3", "otg", "hiber";
(https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/zynqmp.dtsi#L996)
where I think we should be able to convert it
host, peripheral, otg, hiber
And Versal (Versal NET is the same as Versal) is now using
interrupt-names = "dwc_usb3","otg","usb-wakeup";
https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/versal.dtsi#L597
where it can be converted to
host, peripheral, otg, usb-wakeup
but the last usb-wakeup entry is the problematic one.
You mentioned before if this is SOC specific maybe we should consider to create
new compatible string to match this.
Thanks,
Michal
next prev parent reply other threads:[~2022-09-23 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 8:57 [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt Piyush Mehta
2022-09-13 9:21 ` Krzysztof Kozlowski
2022-09-14 13:15 ` Mehta, Piyush
2022-09-15 8:44 ` Krzysztof Kozlowski
2022-09-15 9:04 ` Michal Simek
2022-09-16 10:10 ` Krzysztof Kozlowski
2022-09-22 11:34 ` Michal Simek
2022-09-23 4:28 ` Mehta, Piyush
2022-09-23 4:38 ` Mehta, Piyush
2022-09-23 9:22 ` Krzysztof Kozlowski
2022-09-23 9:34 ` Michal Simek [this message]
2022-09-23 12:43 ` Felipe Balbi
2022-09-23 13:25 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c104d1-6c09-1744-0621-a50a745a0744@amd.com \
--to=michal.simek@amd.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=piyush.mehta@amd.com \
--cc=robh+dt@kernel.org \
--cc=siva.durga.prasad.paladugu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.