From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Piyush Mehta <piyush.mehta@amd.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, balbi@kernel.org
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
siva.durga.prasad.paladugu@amd.com,
Manish Narani <manish.narani@xilinx.com>
Subject: Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt
Date: Tue, 13 Sep 2022 11:21:47 +0200 [thread overview]
Message-ID: <4cc7a6d2-64ef-c176-21ad-4c3e66f664f7@linaro.org> (raw)
In-Reply-To: <20220912085730.390555-1-piyush.mehta@amd.com>
On 12/09/2022 10:57, Piyush Mehta wrote:
> From: Manish Narani <manish.narani@xilinx.com>
>
> The hibernation feature enabled for Xilinx ZynqMP SoC in DWC3 IP.
> Added the below interrupt-names in the binding schema for the same.
>
> dwc_usb3: dwc3 core interrupt-names
> otg: otg interrupt-names
> hiber: hibernation interrupt-names
This does not make sense in commit msg. Don't duplicate patch in commit msg.
Where is the user (DTS) and implementation of this change? If this is
specific to Xilinx, why you do not have device specific compatible?
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 1779d08ba1c0..618fa7bd32be 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -53,6 +53,8 @@ properties:
> - const: dwc_usb3
> - items:
> enum: [host, peripheral, otg]
> + - items:
> + enum: [dwc_usb3, otg, hiber]
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-13 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 8:57 [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt Piyush Mehta
2022-09-13 9:21 ` Krzysztof Kozlowski [this message]
2022-09-14 13:15 ` Mehta, Piyush
2022-09-15 8:44 ` Krzysztof Kozlowski
2022-09-15 9:04 ` Michal Simek
2022-09-16 10:10 ` Krzysztof Kozlowski
2022-09-22 11:34 ` Michal Simek
2022-09-23 4:28 ` Mehta, Piyush
2022-09-23 4:38 ` Mehta, Piyush
2022-09-23 9:22 ` Krzysztof Kozlowski
2022-09-23 9:34 ` Michal Simek
2022-09-23 12:43 ` Felipe Balbi
2022-09-23 13:25 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cc7a6d2-64ef-c176-21ad-4c3e66f664f7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=michal.simek@amd.com \
--cc=piyush.mehta@amd.com \
--cc=robh+dt@kernel.org \
--cc=siva.durga.prasad.paladugu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.