All of lore.kernel.org
 help / color / mirror / Atom feed
From: Soeren Moch <smoch@web.de>
To: Fabio Estevam <festevam@gmail.com>, shawnguo@kernel.org
Cc: andrew@lunn.ch, linux@armlinux.org.uk,
	stwiss.opensource@diasemi.com, linux-imx@nxp.com,
	kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
Date: Sun, 31 Mar 2019 12:44:24 +0200	[thread overview]
Message-ID: <84c102c7-952f-fc46-5436-f7581880e98a@web.de> (raw)
In-Reply-To: <20190330155051.9855-1-festevam@gmail.com>

On 30.03.19 16:50, Fabio Estevam wrote:
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
>
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.
>
> Quoting Andrew Lunn:
>
> "The problem here is, all the DTs were broken since day 0. However,
> because the PHY driver was also broken, nobody noticed and it
> worked. Now that the PHY driver has been fixed, all the bugs in the
> DTs now become an issue"
>
> To fix this problem, the phy-mode property needs to be "rgmii-id",  which
> has the following meaning as per
> Documentation/devicetree/bindings/net/ethernet.txt:
>
> "RGMII with internal RX and TX delays provided by the PHY, the MAC should
> not add the RX or TX delays in this case)"
>
> Tested on imx6-sabresd, imx6sx-sdb and imx7d-pico boards with
> successfully restored networking.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi,
>
> Marking it as RFC in the hope of getting some feedback as to how
> to proceed with fixing this regression on 5.1-rc1.
I can confirm this regression on a tbs2910 board, and also thatthis
patch fixes this.

Tested-by: Soeren Moch <smoch@web.de>

I also think it is the right solution to fix the broken dtbs, like in
this patch, instead of adding more complicated backward compatibility stuff.

Thanks,
Soeren
>
> It's not possible to know if there are other imx boards in tree that use
> AR803X, so here is an attempt.
>
> mx6-sabresd, imx6sx-sdb and imx7d-pico have been successfully tested.
>
> Thanks
>
>  arch/arm/boot/dts/imx6q-tbs2910.dts      | 2 +-
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi   | 2 +-
>  arch/arm/boot/dts/imx6qdl-sr-som.dtsi    | 2 +-
>  arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 2 +-
>  arch/arm/boot/dts/imx6sx-sdb.dtsi        | 2 +-
>  arch/arm/boot/dts/imx7d-pico.dtsi        | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-03-31 10:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30 15:50 [RFC] ARM: dts: imx: Fix the AR803X phy-mode Fabio Estevam
2019-03-30 16:18 ` Andrew Lunn
2019-04-01 12:53   ` Fabio Estevam
2019-03-30 19:06 ` Baruch Siach
2019-03-30 19:11   ` Fabio Estevam
2019-03-31  3:50     ` Baruch Siach
2019-03-31 10:44 ` Soeren Moch [this message]
2019-04-01  8:38 ` Steve Twiss
2019-04-01  8:38   ` Steve Twiss
2019-04-01 12:48   ` Fabio Estevam
2019-04-01 12:48     ` Fabio Estevam
2019-04-01  9:01 ` Sébastien Szymanski
2019-04-01  9:05 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84c102c7-952f-fc46-5436-f7581880e98a@web.de \
    --to=smoch@web.de \
    --cc=andrew@lunn.ch \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux@armlinux.org.uk \
    --cc=shawnguo@kernel.org \
    --cc=stwiss.opensource@diasemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.