All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Fabio Estevam <festevam@gmail.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: PENGUTRONIX <kernel@pengutronix.de>, IMXNXP <linux-imx@nxp.com>,
	"smoch@web.de" <smoch@web.de>, ARMLINUX <linux@armlinux.org.uk>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Support Opensource <Support.Opensource@diasemi.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Subject: RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
Date: Mon, 1 Apr 2019 08:38:28 +0000	[thread overview]
Message-ID: <VI1PR10MB2352F3C08CADD6029FF77FF3FE550@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190330155051.9855-1-festevam@gmail.com>

Hi Fabio,

On 30 March 2019 15:51 Fabio Estevam, wrote:

> Subject: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
> 
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
> 
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.

[...]

>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi   | 2 +-

[...]

> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index a0705066ccba..185fb17a3500 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -202,7 +202,7 @@
>  &fec {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };

[...]

This patch looks surprisingly similar to this one ;)
https://lore.kernel.org/patchwork/patch/1052588/

Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Adam Thomson <Adam.Thomson@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>

Regards,
Steve


WARNING: multiple messages have this Message-ID (diff)
From: Steve Twiss <stwiss.opensource@diasemi.com>
To: Fabio Estevam <festevam@gmail.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
	Support Opensource <Support.Opensource@diasemi.com>,
	ARMLINUX <linux@armlinux.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	"smoch@web.de" <smoch@web.de>, IMXNXP <linux-imx@nxp.com>,
	PENGUTRONIX <kernel@pengutronix.de>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>
Subject: RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
Date: Mon, 1 Apr 2019 08:38:28 +0000	[thread overview]
Message-ID: <VI1PR10MB2352F3C08CADD6029FF77FF3FE550@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190330155051.9855-1-festevam@gmail.com>

Hi Fabio,

On 30 March 2019 15:51 Fabio Estevam, wrote:

> Subject: [RFC] ARM: dts: imx: Fix the AR803X phy-mode
> 
> Commit 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> exposed an issue on imx DTS files using AR8031/AR8035 PHYs.
> 
> The end result is that the boards can no longer obtain an IP address
> via UDHCP, for example.

[...]

>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi   | 2 +-

[...]

> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index a0705066ccba..185fb17a3500 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -202,7 +202,7 @@
>  &fec {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet>;
> -	phy-mode = "rgmii";
> +	phy-mode = "rgmii-id";
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };

[...]

This patch looks surprisingly similar to this one ;)
https://lore.kernel.org/patchwork/patch/1052588/

Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Adam Thomson <Adam.Thomson@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>

Regards,
Steve


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-04-01  8:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30 15:50 [RFC] ARM: dts: imx: Fix the AR803X phy-mode Fabio Estevam
2019-03-30 16:18 ` Andrew Lunn
2019-04-01 12:53   ` Fabio Estevam
2019-03-30 19:06 ` Baruch Siach
2019-03-30 19:11   ` Fabio Estevam
2019-03-31  3:50     ` Baruch Siach
2019-03-31 10:44 ` Soeren Moch
2019-04-01  8:38 ` Steve Twiss [this message]
2019-04-01  8:38   ` Steve Twiss
2019-04-01 12:48   ` Fabio Estevam
2019-04-01 12:48     ` Fabio Estevam
2019-04-01  9:01 ` Sébastien Szymanski
2019-04-01  9:05 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR10MB2352F3C08CADD6029FF77FF3FE550@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM \
    --to=stwiss.opensource@diasemi.com \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=andrew@lunn.ch \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=shawnguo@kernel.org \
    --cc=smoch@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.