From: Anshuman Khandual <anshuman.khandual@arm.com> To: David Hildenbrand <david@redhat.com>, linux-mm@kvack.org, akpm@linux-foundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>, Mark Rutland <mark.rutland@arm.com> Subject: Re: [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range() Date: Wed, 2 Dec 2020 17:47:01 +0530 [thread overview] Message-ID: <85975346-d5ae-d971-e50f-9c0b77649910@arm.com> (raw) In-Reply-To: <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> On 12/2/20 2:56 PM, David Hildenbrand wrote: > On 30.11.20 04:29, Anshuman Khandual wrote: >> This overrides arch_get_mappable_range() on arm64 platform which will be >> used with recently added generic framework. It drops inside_linear_region() >> and subsequent check in arch_add_memory() which are no longer required. >> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: Ard Biesheuvel <ardb@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: David Hildenbrand <david@redhat.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> arch/arm64/mm/mmu.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index ca692a815731..49ec8f2838f2 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1444,16 +1444,19 @@ static void __remove_pgd_mapping(pgd_t *pgdir, unsigned long start, u64 size) >> free_empty_tables(start, end, PAGE_OFFSET, PAGE_END); >> } >> >> -static bool inside_linear_region(u64 start, u64 size) >> +struct range arch_get_mappable_range(void) >> { >> + struct range memhp_range; >> + >> /* >> * Linear mapping region is the range [PAGE_OFFSET..(PAGE_END - 1)] >> * accommodating both its ends but excluding PAGE_END. Max physical >> * range which can be mapped inside this linear mapping range, must >> * also be derived from its end points. >> */ >> - return start >= __pa(_PAGE_OFFSET(vabits_actual)) && >> - (start + size - 1) <= __pa(PAGE_END - 1); >> + memhp_range.start = __pa(_PAGE_OFFSET(vabits_actual)); >> + memhp_range.end = __pa(PAGE_END - 1); >> + return memhp_range; >> } >> >> int arch_add_memory(int nid, u64 start, u64 size, >> @@ -1461,11 +1464,6 @@ int arch_add_memory(int nid, u64 start, u64 size, >> { >> int ret, flags = 0; >> >> - if (!inside_linear_region(start, size)) { >> - pr_err("[%llx %llx] is outside linear mapping region\n", start, start + size); >> - return -EINVAL; >> - } > As discussed, I think something like a VM_BUG_ON() here might makes > sense, indicating that we require the caller to validate upfront. Same > applies to the s390x variant. Sure, will do. > > Thanks! >
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com> To: David Hildenbrand <david@redhat.com>, linux-mm@kvack.org, akpm@linux-foundation.org Cc: Mark Rutland <mark.rutland@arm.com>, linux-s390@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>, linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range() Date: Wed, 2 Dec 2020 17:47:01 +0530 [thread overview] Message-ID: <85975346-d5ae-d971-e50f-9c0b77649910@arm.com> (raw) In-Reply-To: <1861413c-fd23-f3e2-14f3-00feec6ff2fb@redhat.com> On 12/2/20 2:56 PM, David Hildenbrand wrote: > On 30.11.20 04:29, Anshuman Khandual wrote: >> This overrides arch_get_mappable_range() on arm64 platform which will be >> used with recently added generic framework. It drops inside_linear_region() >> and subsequent check in arch_add_memory() which are no longer required. >> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: Ard Biesheuvel <ardb@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: David Hildenbrand <david@redhat.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> arch/arm64/mm/mmu.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index ca692a815731..49ec8f2838f2 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1444,16 +1444,19 @@ static void __remove_pgd_mapping(pgd_t *pgdir, unsigned long start, u64 size) >> free_empty_tables(start, end, PAGE_OFFSET, PAGE_END); >> } >> >> -static bool inside_linear_region(u64 start, u64 size) >> +struct range arch_get_mappable_range(void) >> { >> + struct range memhp_range; >> + >> /* >> * Linear mapping region is the range [PAGE_OFFSET..(PAGE_END - 1)] >> * accommodating both its ends but excluding PAGE_END. Max physical >> * range which can be mapped inside this linear mapping range, must >> * also be derived from its end points. >> */ >> - return start >= __pa(_PAGE_OFFSET(vabits_actual)) && >> - (start + size - 1) <= __pa(PAGE_END - 1); >> + memhp_range.start = __pa(_PAGE_OFFSET(vabits_actual)); >> + memhp_range.end = __pa(PAGE_END - 1); >> + return memhp_range; >> } >> >> int arch_add_memory(int nid, u64 start, u64 size, >> @@ -1461,11 +1464,6 @@ int arch_add_memory(int nid, u64 start, u64 size, >> { >> int ret, flags = 0; >> >> - if (!inside_linear_region(start, size)) { >> - pr_err("[%llx %llx] is outside linear mapping region\n", start, start + size); >> - return -EINVAL; >> - } > As discussed, I think something like a VM_BUG_ON() here might makes > sense, indicating that we require the caller to validate upfront. Same > applies to the s390x variant. Sure, will do. > > Thanks! > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-02 12:18 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-30 3:29 [RFC V2 0/3] mm/hotplug: Pre-validate the address range with platform Anshuman Khandual 2020-11-30 3:29 ` Anshuman Khandual 2020-11-30 3:29 ` [RFC V2 1/3] mm/hotplug: Prevalidate the address range being added " Anshuman Khandual 2020-11-30 3:29 ` Anshuman Khandual 2020-12-02 5:10 ` kernel test robot 2020-12-02 9:20 ` David Hildenbrand 2020-12-02 9:20 ` David Hildenbrand 2020-12-02 12:15 ` Anshuman Khandual 2020-12-02 12:15 ` Anshuman Khandual 2020-11-30 3:29 ` [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range() Anshuman Khandual 2020-11-30 3:29 ` Anshuman Khandual 2020-11-30 5:29 ` kernel test robot 2020-11-30 17:38 ` kernel test robot 2020-12-02 9:26 ` David Hildenbrand 2020-12-02 9:26 ` David Hildenbrand 2020-12-02 12:17 ` Anshuman Khandual [this message] 2020-12-02 12:17 ` Anshuman Khandual 2020-11-30 3:29 ` [RFC V2 3/3] s390/mm: " Anshuman Khandual 2020-11-30 3:29 ` Anshuman Khandual 2020-11-30 5:40 ` kernel test robot 2020-12-02 20:32 ` Heiko Carstens 2020-12-02 20:32 ` Heiko Carstens 2020-12-03 0:33 ` Anshuman Khandual 2020-12-03 0:33 ` Anshuman Khandual 2020-12-03 11:51 ` Heiko Carstens 2020-12-03 11:51 ` Heiko Carstens 2020-12-03 12:01 ` David Hildenbrand 2020-12-03 12:01 ` David Hildenbrand 2020-12-07 4:38 ` Anshuman Khandual 2020-12-07 4:38 ` Anshuman Khandual 2020-12-07 9:03 ` David Hildenbrand 2020-12-07 9:03 ` David Hildenbrand 2020-12-08 5:32 ` Anshuman Khandual 2020-12-08 5:32 ` Anshuman Khandual 2020-12-08 8:38 ` David Hildenbrand 2020-12-08 8:38 ` David Hildenbrand 2020-12-02 6:44 ` [RFC V2 0/3] mm/hotplug: Pre-validate the address range with platform Anshuman Khandual 2020-12-02 6:44 ` Anshuman Khandual 2020-12-02 20:35 ` Heiko Carstens 2020-12-02 20:35 ` Heiko Carstens 2020-12-03 0:12 ` Anshuman Khandual 2020-12-03 0:12 ` Anshuman Khandual
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=85975346-d5ae-d971-e50f-9c0b77649910@arm.com \ --to=anshuman.khandual@arm.com \ --cc=akpm@linux-foundation.org \ --cc=ardb@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=david@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-s390@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.