From: Pu Wen <puwen@hygon.cn>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rth@twiddle.net" <rth@twiddle.net>,
"ehabkost@redhat.com" <ehabkost@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"marcel.apfelbaum@gmail.com" <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model
Date: Tue, 16 Apr 2019 17:04:36 +0800 [thread overview]
Message-ID: <8622eb20-ed78-fcc8-4e24-f9b8333af381@hygon.cn> (raw)
In-Reply-To: <20190416081804.GC31311@redhat.com>
On 2019/4/16 16:19, Daniel P. Berrangé wrote:
> On Tue, Apr 16, 2019 at 02:56:12PM +0800, Pu Wen wrote:
>> On 2019/4/15 17:25, Daniel P. Berrangé wrote:
>>> On Sat, Apr 13, 2019 at 10:54:40AM +0800, Pu Wen wrote:
>>>> @@ -152,6 +154,7 @@ GlobalProperty pc_compat_2_12[] = {
>>>> { TYPE_X86_CPU, "topoext", "off" },
>>>> { "EPYC-" TYPE_X86_CPU, "xlevel", "0x8000000a" },
>>>> { "EPYC-IBPB-" TYPE_X86_CPU, "xlevel", "0x8000000a" },
>>>> + { "Dhyana-" TYPE_X86_CPU, "xlevel", "0x8000000a" },
>>>> };
>>>> const size_t pc_compat_2_12_len = G_N_ELEMENTS(pc_compat_2_12);
>>>
>>> You can drop the changes in this file. This CPU model didn't exist
>>> in any older QEMU releases, so there's no machine type backcompat
>>> required, at least from upstream QEMU POV.
>>
>> Then how about running QEMU with the parameter like "-M pc-i440fx-2.12"?
>> Although the default machine is newer than that.
>
> That doesnt matter. This back-compat property table is about ensuring
> that "-cpu Skylake-Client -M pc-i440fx-2.12" run on QEMU 4.0.0 release
> works the same way as when run on QEMU 2.12.0 release.
>
> Since there is no Dhyana CPU model in QEMU 2.12.0 release, there's no
> back compat issue to fix.
Thanks for the explanation. Will drop the changes in next version patch.
--
Regards,
Pu Wen
WARNING: multiple messages have this Message-ID (diff)
From: Pu Wen <puwen@hygon.cn>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "ehabkost@redhat.com" <ehabkost@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model
Date: Tue, 16 Apr 2019 17:04:36 +0800 [thread overview]
Message-ID: <8622eb20-ed78-fcc8-4e24-f9b8333af381@hygon.cn> (raw)
Message-ID: <20190416090436.0xs0vHRzIqYo1c4oOfFpChv6S-Bl0he1U-vesf2Calw@z> (raw)
In-Reply-To: <20190416081804.GC31311@redhat.com>
On 2019/4/16 16:19, Daniel P. Berrangé wrote:
> On Tue, Apr 16, 2019 at 02:56:12PM +0800, Pu Wen wrote:
>> On 2019/4/15 17:25, Daniel P. Berrangé wrote:
>>> On Sat, Apr 13, 2019 at 10:54:40AM +0800, Pu Wen wrote:
>>>> @@ -152,6 +154,7 @@ GlobalProperty pc_compat_2_12[] = {
>>>> { TYPE_X86_CPU, "topoext", "off" },
>>>> { "EPYC-" TYPE_X86_CPU, "xlevel", "0x8000000a" },
>>>> { "EPYC-IBPB-" TYPE_X86_CPU, "xlevel", "0x8000000a" },
>>>> + { "Dhyana-" TYPE_X86_CPU, "xlevel", "0x8000000a" },
>>>> };
>>>> const size_t pc_compat_2_12_len = G_N_ELEMENTS(pc_compat_2_12);
>>>
>>> You can drop the changes in this file. This CPU model didn't exist
>>> in any older QEMU releases, so there's no machine type backcompat
>>> required, at least from upstream QEMU POV.
>>
>> Then how about running QEMU with the parameter like "-M pc-i440fx-2.12"?
>> Although the default machine is newer than that.
>
> That doesnt matter. This back-compat property table is about ensuring
> that "-cpu Skylake-Client -M pc-i440fx-2.12" run on QEMU 4.0.0 release
> works the same way as when run on QEMU 2.12.0 release.
>
> Since there is no Dhyana CPU model in QEMU 2.12.0 release, there's no
> back compat issue to fix.
Thanks for the explanation. Will drop the changes in next version patch.
--
Regards,
Pu Wen
next prev parent reply other threads:[~2019-04-16 9:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 2:54 [Qemu-devel] [PATCH v2] i386: Add new Hygon 'Dhyana' CPU model Pu Wen
2019-04-13 2:54 ` Pu Wen
2019-04-15 9:25 ` Daniel P. Berrangé
2019-04-15 9:25 ` Daniel P. Berrangé
2019-04-16 6:56 ` Pu Wen
2019-04-16 6:56 ` Pu Wen
2019-04-16 8:18 ` Daniel P. Berrangé
2019-04-16 8:18 ` Daniel P. Berrangé
2019-04-16 9:04 ` Pu Wen [this message]
2019-04-16 9:04 ` Pu Wen
2019-04-15 20:39 ` Eduardo Habkost
2019-04-15 20:39 ` Eduardo Habkost
2019-04-16 7:09 ` Pu Wen
2019-04-16 7:09 ` Pu Wen
2019-04-16 8:16 ` Daniel P. Berrangé
2019-04-16 8:16 ` Daniel P. Berrangé
2019-04-16 14:23 ` Eduardo Habkost
2019-04-16 14:23 ` Eduardo Habkost
2019-04-16 14:27 ` Daniel P. Berrangé
2019-04-16 14:27 ` Daniel P. Berrangé
2019-04-16 14:58 ` Eduardo Habkost
2019-04-16 14:58 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8622eb20-ed78-fcc8-4e24-f9b8333af381@hygon.cn \
--to=puwen@hygon.cn \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.