From: Valentin Schneider <valentin.schneider@arm.com> To: Marco Elver <elver@google.com> Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linuxppc-dev@lists.ozlabs.org, linux-kbuild@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Frederic Weisbecker <frederic@kernel.org>, Mike Galbraith <efault@gmx.de>, Dmitry Vyukov <dvyukov@google.com>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Steven Rostedt <rostedt@goodmis.org>, Masahiro Yamada <masahiroy@kernel.org>, Michal Marek <michal.lkml@markovi.net>, Nick Desaulniers <ndesaulniers@google.com> Subject: Re: [PATCH v2 4/5] kscan: Use preemption model accessors Date: Thu, 11 Nov 2021 10:57:02 +0000 [thread overview] Message-ID: <871r3nrmdd.mognet@arm.com> (raw) In-Reply-To: <YYzeOQNFmuieCk3T@elver.google.com> On 11/11/21 10:11, Marco Elver wrote: > Subject s/kscan/kcsan/ > Woops... > On Wed, Nov 10, 2021 at 08:24PM +0000, Valentin Schneider wrote: >> Per PREEMPT_DYNAMIC, checking CONFIG_PREEMPT doesn't tell you the actual >> preemption model of the live kernel. Use the newly-introduced accessors >> instead. >> >> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> > > Reviewed-by: Marco Elver <elver@google.com> > > Though it currently doesn't compile as a module due to missing > EXPORT_SYMBOL of is_preempt*(). > >> --- >> kernel/kcsan/kcsan_test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c >> index dc55fd5a36fc..14d811eb9a21 100644 >> --- a/kernel/kcsan/kcsan_test.c >> +++ b/kernel/kcsan/kcsan_test.c >> @@ -1005,13 +1005,13 @@ static const void *nthreads_gen_params(const void *prev, char *desc) >> else >> nthreads *= 2; >> >> - if (!IS_ENABLED(CONFIG_PREEMPT) || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> + if (!is_preempt_full() || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> /* >> * Without any preemption, keep 2 CPUs free for other tasks, one >> * of which is the main test case function checking for >> * completion or failure. >> */ >> - const long min_unused_cpus = IS_ENABLED(CONFIG_PREEMPT_NONE) ? 2 : 0; >> + const long min_unused_cpus = is_preempt_none() ? 2 : 0; >> const long min_required_cpus = 2 + min_unused_cpus; >> >> if (num_online_cpus() < min_required_cpus) { >> -- >> 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com> To: Marco Elver <elver@google.com> Cc: Michal Marek <michal.lkml@markovi.net>, linux-kbuild@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>, Frederic Weisbecker <frederic@kernel.org>, Mike Galbraith <efault@gmx.de>, Nick Desaulniers <ndesaulniers@google.com>, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Paul Mackerras <paulus@samba.org>, Steven Rostedt <rostedt@goodmis.org>, Masahiro Yamada <masahiroy@kernel.org>, linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH v2 4/5] kscan: Use preemption model accessors Date: Thu, 11 Nov 2021 10:57:02 +0000 [thread overview] Message-ID: <871r3nrmdd.mognet@arm.com> (raw) In-Reply-To: <YYzeOQNFmuieCk3T@elver.google.com> On 11/11/21 10:11, Marco Elver wrote: > Subject s/kscan/kcsan/ > Woops... > On Wed, Nov 10, 2021 at 08:24PM +0000, Valentin Schneider wrote: >> Per PREEMPT_DYNAMIC, checking CONFIG_PREEMPT doesn't tell you the actual >> preemption model of the live kernel. Use the newly-introduced accessors >> instead. >> >> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> > > Reviewed-by: Marco Elver <elver@google.com> > > Though it currently doesn't compile as a module due to missing > EXPORT_SYMBOL of is_preempt*(). > >> --- >> kernel/kcsan/kcsan_test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/kernel/kcsan/kcsan_test.c b/kernel/kcsan/kcsan_test.c >> index dc55fd5a36fc..14d811eb9a21 100644 >> --- a/kernel/kcsan/kcsan_test.c >> +++ b/kernel/kcsan/kcsan_test.c >> @@ -1005,13 +1005,13 @@ static const void *nthreads_gen_params(const void *prev, char *desc) >> else >> nthreads *= 2; >> >> - if (!IS_ENABLED(CONFIG_PREEMPT) || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> + if (!is_preempt_full() || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { >> /* >> * Without any preemption, keep 2 CPUs free for other tasks, one >> * of which is the main test case function checking for >> * completion or failure. >> */ >> - const long min_unused_cpus = IS_ENABLED(CONFIG_PREEMPT_NONE) ? 2 : 0; >> + const long min_unused_cpus = is_preempt_none() ? 2 : 0; >> const long min_required_cpus = 2 + min_unused_cpus; >> >> if (num_online_cpus() < min_required_cpus) { >> -- >> 2.25.1
next prev parent reply other threads:[~2021-11-11 10:57 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-10 20:24 [PATCH v2 0/5] preempt: PREEMPT vs PREEMPT_DYNAMIC configs fixup Valentin Schneider 2021-11-10 20:24 ` Valentin Schneider 2021-11-10 20:24 ` [PATCH v2 1/5] preempt: Restore preemption model selection configs Valentin Schneider 2021-11-10 20:24 ` Valentin Schneider 2021-11-11 8:58 ` Marco Elver 2021-11-11 8:58 ` Marco Elver 2021-11-11 12:22 ` [tip: sched/urgent] " tip-bot2 for Valentin Schneider 2021-11-10 20:24 ` [PATCH v2 2/5] preempt/dynamic: Introduce preempt mode accessors Valentin Schneider 2021-11-10 20:24 ` Valentin Schneider 2021-11-11 3:16 ` Mike Galbraith 2021-11-11 3:16 ` Mike Galbraith 2021-11-11 3:35 ` Mike Galbraith 2021-11-11 3:35 ` Mike Galbraith 2021-11-11 3:47 ` Mike Galbraith 2021-11-11 3:47 ` Mike Galbraith 2021-11-11 3:55 ` Mike Galbraith 2021-11-11 3:55 ` Mike Galbraith 2021-11-11 9:36 ` Marco Elver 2021-11-11 9:36 ` Marco Elver 2021-11-11 10:32 ` Mike Galbraith 2021-11-11 10:32 ` Mike Galbraith 2021-11-11 10:56 ` Valentin Schneider 2021-11-11 10:56 ` Valentin Schneider 2021-11-11 11:09 ` Mike Galbraith 2021-11-11 11:09 ` Mike Galbraith 2021-11-11 8:54 ` Marco Elver 2021-11-11 8:54 ` Marco Elver 2021-11-11 10:56 ` Valentin Schneider 2021-11-11 10:56 ` Valentin Schneider 2021-11-16 13:29 ` Christophe Leroy 2021-11-16 13:29 ` Christophe Leroy 2021-11-22 16:37 ` Valentin Schneider 2021-11-22 16:37 ` Valentin Schneider 2021-11-10 20:24 ` [PATCH v2 3/5] powerpc: Use preemption model accessors Valentin Schneider 2021-11-10 20:24 ` Valentin Schneider 2021-11-11 4:55 ` Michael Ellerman 2021-11-11 4:55 ` Michael Ellerman 2021-11-15 15:29 ` Valentin Schneider 2021-11-15 15:29 ` Valentin Schneider 2021-11-16 13:41 ` Christophe Leroy 2021-11-16 13:41 ` Christophe Leroy 2021-11-22 16:44 ` Valentin Schneider 2021-11-22 16:44 ` Valentin Schneider 2021-11-10 20:24 ` [PATCH v2 4/5] kscan: " Valentin Schneider 2021-11-10 20:24 ` Valentin Schneider 2021-11-11 9:11 ` Marco Elver 2021-11-11 9:11 ` Marco Elver 2021-11-11 9:39 ` Marco Elver 2021-11-11 9:39 ` Marco Elver 2021-11-11 10:57 ` Valentin Schneider [this message] 2021-11-11 10:57 ` Valentin Schneider 2021-11-10 20:24 ` [PATCH v2 5/5] ftrace: Use preemption model accessors for trace header printout Valentin Schneider 2021-11-10 20:24 ` Valentin Schneider 2021-11-10 20:36 ` Steven Rostedt 2021-11-10 20:36 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=871r3nrmdd.mognet@arm.com \ --to=valentin.schneider@arm.com \ --cc=benh@kernel.crashing.org \ --cc=dvyukov@google.com \ --cc=efault@gmx.de \ --cc=elver@google.com \ --cc=frederic@kernel.org \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=masahiroy@kernel.org \ --cc=michal.lkml@markovi.net \ --cc=mingo@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=ndesaulniers@google.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.