* Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error
2020-01-21 21:38 [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error Philippe Mathieu-Daudé
@ 2020-01-21 22:19 ` Alistair Francis
2020-01-22 7:19 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2020-01-21 22:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Peter Maydell, Alistair Francis,
qemu-devel@nongnu.org Developers
On Wed, Jan 22, 2020 at 7:39 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
> STM32F4xxSyscfgState *s = opaque;
> int icrreg = irq / 4;
> int startbit = (irq & 3) * 4;
> - uint8_t config = config = irq / 16;
> + uint8_t config = irq / 16;
>
> trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
>
> --
> 2.21.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error
2020-01-21 21:38 [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error Philippe Mathieu-Daudé
2020-01-21 22:19 ` Alistair Francis
@ 2020-01-22 7:19 ` Thomas Huth
2020-01-22 10:26 ` Alex Bennée
2020-01-23 14:57 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2020-01-22 7:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel, Alistair Francis
Cc: qemu-trivial, Peter Maydell
On 21/01/2020 22.38, Philippe Mathieu-Daudé wrote:
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
> STM32F4xxSyscfgState *s = opaque;
> int icrreg = irq / 4;
> int startbit = (irq & 3) * 4;
> - uint8_t config = config = irq / 16;
> + uint8_t config = irq / 16;
>
> trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error
2020-01-21 21:38 [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error Philippe Mathieu-Daudé
2020-01-21 22:19 ` Alistair Francis
2020-01-22 7:19 ` Thomas Huth
@ 2020-01-22 10:26 ` Alex Bennée
2020-01-23 14:57 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Alex Bennée @ 2020-01-22 10:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Peter Maydell, Alistair Francis, qemu-devel
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
> STM32F4xxSyscfgState *s = opaque;
> int icrreg = irq / 4;
> int startbit = (irq & 3) * 4;
> - uint8_t config = config = irq / 16;
> + uint8_t config = irq / 16;
>
> trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error
2020-01-21 21:38 [PATCH] hw/misc/stm32f4xx_syscfg: Fix copy/paste error Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2020-01-22 10:26 ` Alex Bennée
@ 2020-01-23 14:57 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2020-01-23 14:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Alistair Francis, QEMU Developers
On Tue, 21 Jan 2020 at 21:38, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Missed in 870c034da0b, hopefully reported by Coverity.
>
> Fixes: Coverity CID 1412793 (Incorrect expression)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/misc/stm32f4xx_syscfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/stm32f4xx_syscfg.c b/hw/misc/stm32f4xx_syscfg.c
> index dbcdca59f8..f960e4ea1e 100644
> --- a/hw/misc/stm32f4xx_syscfg.c
> +++ b/hw/misc/stm32f4xx_syscfg.c
> @@ -47,7 +47,7 @@ static void stm32f4xx_syscfg_set_irq(void *opaque, int irq, int level)
> STM32F4xxSyscfgState *s = opaque;
> int icrreg = irq / 4;
> int startbit = (irq & 3) * 4;
> - uint8_t config = config = irq / 16;
> + uint8_t config = irq / 16;
>
> trace_stm32f4xx_syscfg_set_irq(irq / 16, irq % 16, level);
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread