From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Rakesh Pillai <pillair@codeaurora.org>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Enable Factory Test Mode for WCN3990
Date: Thu, 07 Feb 2019 16:14:31 +0200 [thread overview]
Message-ID: <871s4jado8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190205010207.GA219734@google.com> (Brian Norris's message of "Mon, 4 Feb 2019 17:02:08 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Wed, Aug 29, 2018 at 12:30:38PM +0530, Rakesh Pillai wrote:
>> The support to put WCN3990 firmware into Factory
>> test mode is not present currently. The WCN3990
>> firmware can operate in Factory test mode based
>> on the mode it receives in the wlan enable message
>> from the host driver.
>>
>> When the host driver is started in testmode send
>> the operating mode as UTF mode, to the WCN3990
>> firmware, in the wlan enable message to start the
>> firmware in Factory test mode.
>>
>> Tested on: WCN3990
>> Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1.
>>
>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath10k/ahb.c | 3 ++-
>> drivers/net/wireless/ath/ath10k/core.c | 2 +-
>> drivers/net/wireless/ath/ath10k/hif.h | 7 ++++---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> drivers/net/wireless/ath/ath10k/pci.c | 3 ++-
>> drivers/net/wireless/ath/ath10k/sdio.c | 3 ++-
>> drivers/net/wireless/ath/ath10k/snoc.c | 20 ++++++++++++++++----
>> drivers/net/wireless/ath/ath10k/testmode.c | 2 +-
>> drivers/net/wireless/ath/ath10k/usb.c | 3 ++-
>> 9 files changed, 31 insertions(+), 14 deletions(-)
>
> What ever happened here? I'm told this is useful, but I see no comments
> and it's marked Deferred in patchwork:
>
> https://patchwork.kernel.org/patch/10579559/
Not sure, I guess it just got accidentally hidden with other patches.
It's in new state now.
> FWIW, it looks OK to me:
>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Thanks!
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-wireless@vger.kernel.org,
Rakesh Pillai <pillair@codeaurora.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Enable Factory Test Mode for WCN3990
Date: Thu, 07 Feb 2019 16:14:31 +0200 [thread overview]
Message-ID: <871s4jado8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190205010207.GA219734@google.com> (Brian Norris's message of "Mon, 4 Feb 2019 17:02:08 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Wed, Aug 29, 2018 at 12:30:38PM +0530, Rakesh Pillai wrote:
>> The support to put WCN3990 firmware into Factory
>> test mode is not present currently. The WCN3990
>> firmware can operate in Factory test mode based
>> on the mode it receives in the wlan enable message
>> from the host driver.
>>
>> When the host driver is started in testmode send
>> the operating mode as UTF mode, to the WCN3990
>> firmware, in the wlan enable message to start the
>> firmware in Factory test mode.
>>
>> Tested on: WCN3990
>> Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1.
>>
>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath10k/ahb.c | 3 ++-
>> drivers/net/wireless/ath/ath10k/core.c | 2 +-
>> drivers/net/wireless/ath/ath10k/hif.h | 7 ++++---
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> drivers/net/wireless/ath/ath10k/pci.c | 3 ++-
>> drivers/net/wireless/ath/ath10k/sdio.c | 3 ++-
>> drivers/net/wireless/ath/ath10k/snoc.c | 20 ++++++++++++++++----
>> drivers/net/wireless/ath/ath10k/testmode.c | 2 +-
>> drivers/net/wireless/ath/ath10k/usb.c | 3 ++-
>> 9 files changed, 31 insertions(+), 14 deletions(-)
>
> What ever happened here? I'm told this is useful, but I see no comments
> and it's marked Deferred in patchwork:
>
> https://patchwork.kernel.org/patch/10579559/
Not sure, I guess it just got accidentally hidden with other patches.
It's in new state now.
> FWIW, it looks OK to me:
>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
Thanks!
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-02-07 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:00 [PATCH] ath10k: Enable Factory Test Mode for WCN3990 Rakesh Pillai
2018-08-29 7:00 ` Rakesh Pillai
2019-02-05 1:02 ` Brian Norris
2019-02-05 1:02 ` Brian Norris
2019-02-07 14:14 ` Kalle Valo [this message]
2019-02-07 14:14 ` Kalle Valo
2019-02-08 14:16 ` Kalle Valo
2019-02-08 14:16 ` Kalle Valo
[not found] ` <20190208141604.B2D266074F@smtp.codeaurora.org>
2019-02-08 14:40 ` Rakesh Pillai
2019-02-08 14:40 ` Rakesh Pillai
2019-02-11 16:34 ` Kalle Valo
2019-02-11 16:34 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s4jado8.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.