* [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm
@ 2022-12-13 0:35 zijunzhao via ltp
2022-12-13 10:46 ` Richard Palethorpe
0 siblings, 1 reply; 4+ messages in thread
From: zijunzhao via ltp @ 2022-12-13 0:35 UTC (permalink / raw)
To: ltp
---
testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
index 3df941785..c6a7c3a58 100644
--- a/testcases/kernel/syscalls/signalfd/signalfd01.c
+++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
@@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
goto out;
} else {
tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
- fdsi.ssi_signo),
- strsignal(fdsi.ssi_signo);
+ fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
goto out;
}
--
2.39.0.rc1.256.g54fd8350bd-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm
2022-12-13 0:35 [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm zijunzhao via ltp
@ 2022-12-13 10:46 ` Richard Palethorpe
2022-12-14 20:37 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Richard Palethorpe @ 2022-12-13 10:46 UTC (permalink / raw)
To: zijunzhao; +Cc: ltp
Hello,
The patch is perfect, but you need to add your Signed-off-by git trailer
to the commit (or just respond this e-mail with it).
zijunzhao via ltp <ltp@lists.linux.it> writes:
> ---
> testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
> index 3df941785..c6a7c3a58 100644
> --- a/testcases/kernel/syscalls/signalfd/signalfd01.c
> +++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
> @@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
> goto out;
> } else {
> tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
> - fdsi.ssi_signo),
> - strsignal(fdsi.ssi_signo);
> + fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
> goto out;
> }
>
> --
> 2.39.0.rc1.256.g54fd8350bd-goog
--
Thank you,
Richard.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm
2022-12-13 10:46 ` Richard Palethorpe
@ 2022-12-14 20:37 ` Petr Vorel
2022-12-14 20:39 ` Petr Vorel
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2022-12-14 20:37 UTC (permalink / raw)
To: Richard Palethorpe; +Cc: ltp
Hi all,
> Hello,
> The patch is perfect, but you need to add your Signed-off-by git trailer
> to the commit (or just respond this e-mail with it).
I added Zijun's mail and merged. Thanks for the fix!
I dared to slightly modify the commit message and added
Fixes: 3306ad4398 ("m4: clean up ltp-signalfd.m4")
Kind regards,
Petr
> zijunzhao via ltp <ltp@lists.linux.it> writes:
> > ---
> > testcases/kernel/syscalls/signalfd/signalfd01.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> > diff --git a/testcases/kernel/syscalls/signalfd/signalfd01.c b/testcases/kernel/syscalls/signalfd/signalfd01.c
> > index 3df941785..c6a7c3a58 100644
> > --- a/testcases/kernel/syscalls/signalfd/signalfd01.c
> > +++ b/testcases/kernel/syscalls/signalfd/signalfd01.c
> > @@ -249,8 +249,7 @@ void do_test2(int fd, uint32_t sig)
> > goto out;
> > } else {
> > tst_resm(TFAIL, "got unexpected signal: signal=%d : %s",
> > - fdsi.ssi_signo),
> > - strsignal(fdsi.ssi_signo);
> > + fdsi.ssi_signo, strsignal(fdsi.ssi_signo));
> > goto out;
> > }
> > --
> > 2.39.0.rc1.256.g54fd8350bd-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm
2022-12-14 20:37 ` Petr Vorel
@ 2022-12-14 20:39 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2022-12-14 20:39 UTC (permalink / raw)
To: Zijun Zhao; +Cc: Richard Palethorpe, ltp
Hi Zijun,
also, more suggestions:
Add to each patch:
Signed-off-by: Zijun Zhao <zijunzhao@google.com>
You can notice all commits have this.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Richie asked you to do this and thus set your pat
https://patchwork.ozlabs.org/project/ltp/patch/20221213003553.3693243-1-zijunzhao@google.com/
Run 'make check-foo' on target you modify (substitute foo for make target).
That checks for common code mistakes and code style.
You can also use this to check your code:
https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-14 20:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-13 0:35 [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm zijunzhao via ltp
2022-12-13 10:46 ` Richard Palethorpe
2022-12-14 20:37 ` Petr Vorel
2022-12-14 20:39 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.