[Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate

[Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate

[Conrad Ratschan via buildroot]

When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the
fakedate script installed to `host/bin/date` will be overwritten by
host-coreutils. Disable installing the `date` binary in host-coreutils
when BR2_REPRODUCIBLE is set.

Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com>
---
 package/coreutils/coreutils.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
index 65234a113e..1bdfe2f9cf 100644
--- a/package/coreutils/coreutils.mk
+++ b/package/coreutils/coreutils.mk
@@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \
 	--without-gmp \
 	--enable-install-program=ln,realpath
 
+# Avoid overwriting fakedate when creating a reproducible build
+ifeq ($(BR2_REPRODUCIBLE),y)
+HOST_COREUTILS_CONF_OPTS += --enable-no-install-program=date
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate

[Arnout Vandecappelle]

On 27/08/2021 23:14, Conrad Ratschan via buildroot wrote:
> When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the
> fakedate script installed to `host/bin/date` will be overwritten by
> host-coreutils. Disable installing the `date` binary in host-coreutils
> when BR2_REPRODUCIBLE is set.
> 
> Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com>
> ---
>  package/coreutils/coreutils.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
> index 65234a113e..1bdfe2f9cf 100644
> --- a/package/coreutils/coreutils.mk
> +++ b/package/coreutils/coreutils.mk
> @@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \
>  	--without-gmp \
>  	--enable-install-program=ln,realpath

 We were supposed already to only install ln and realpath, so this issue
shouldn't have happened to begin with. Could you investigate in a bit more
detail why this --enable-install-program doesn't seem to do the trick?

>  
> +# Avoid overwriting fakedate when creating a reproducible build
> +ifeq ($(BR2_REPRODUCIBLE),y)

 If there really is no way to get enable-install-program to work correctly, then
we should probably not make this conditional on BR2_REPRODUCIBLE anyway.

 Regards,
 Arnout

> +HOST_COREUTILS_CONF_OPTS += --enable-no-install-program=date
> +endif
> +
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate

[Yann E. MORIN]

Arnout, All,

On 2021-08-28 13:47 +0200, Arnout Vandecappelle spake thusly:
> On 27/08/2021 23:14, Conrad Ratschan via buildroot wrote:
> > When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the
> > fakedate script installed to `host/bin/date` will be overwritten by
> > host-coreutils. Disable installing the `date` binary in host-coreutils
> > when BR2_REPRODUCIBLE is set.
> > 
> > Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com>
> > ---
> >  package/coreutils/coreutils.mk | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
> > index 65234a113e..1bdfe2f9cf 100644
> > --- a/package/coreutils/coreutils.mk
> > +++ b/package/coreutils/coreutils.mk
> > @@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \
> >  	--without-gmp \
> >  	--enable-install-program=ln,realpath
>  We were supposed already to only install ln and realpath, so this issue
> shouldn't have happened to begin with. Could you investigate in a bit more
> detail why this --enable-install-program doesn't seem to do the trick?

See the comment just above the HOST_COREUTILS_CONF_OPTS:

    # A lot of other programs still get installed, however, but disabling
    # them does not gain much at build time, and is a loooong list that is
    # difficult to maintain...

> > +# Avoid overwriting fakedate when creating a reproducible build
> > +ifeq ($(BR2_REPRODUCIBLE),y)
>  If there really is no way to get enable-install-program to work correctly, then
> we should probably not make this conditional on BR2_REPRODUCIBLE anyway.

Yes, we should really just disable it unconditionally...

So, I extended the commit log, the comment to explain all that, and
uncoditionally disabled installing date.

Applied to master, thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate

[Peter Korsgaard]

>>>>> "Conrad" == Conrad Ratschan via buildroot <buildroot@busybox.net> writes:

 > When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the
 > fakedate script installed to `host/bin/date` will be overwritten by
 > host-coreutils. Disable installing the `date` binary in host-coreutils
 > when BR2_REPRODUCIBLE is set.

 > Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot