* [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate @ 2021-08-27 21:14 Conrad Ratschan via buildroot 2021-08-28 11:47 ` Arnout Vandecappelle 2021-09-07 12:40 ` Peter Korsgaard 0 siblings, 2 replies; 4+ messages in thread From: Conrad Ratschan via buildroot @ 2021-08-27 21:14 UTC (permalink / raw) To: buildroot; +Cc: conrad.ratschan When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the fakedate script installed to `host/bin/date` will be overwritten by host-coreutils. Disable installing the `date` binary in host-coreutils when BR2_REPRODUCIBLE is set. Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com> --- package/coreutils/coreutils.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk index 65234a113e..1bdfe2f9cf 100644 --- a/package/coreutils/coreutils.mk +++ b/package/coreutils/coreutils.mk @@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \ --without-gmp \ --enable-install-program=ln,realpath +# Avoid overwriting fakedate when creating a reproducible build +ifeq ($(BR2_REPRODUCIBLE),y) +HOST_COREUTILS_CONF_OPTS += --enable-no-install-program=date +endif + $(eval $(autotools-package)) $(eval $(host-autotools-package)) -- 2.17.1 _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate 2021-08-27 21:14 [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate Conrad Ratschan via buildroot @ 2021-08-28 11:47 ` Arnout Vandecappelle 2021-08-28 12:22 ` Yann E. MORIN 2021-09-07 12:40 ` Peter Korsgaard 1 sibling, 1 reply; 4+ messages in thread From: Arnout Vandecappelle @ 2021-08-28 11:47 UTC (permalink / raw) To: Conrad Ratschan, buildroot On 27/08/2021 23:14, Conrad Ratschan via buildroot wrote: > When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the > fakedate script installed to `host/bin/date` will be overwritten by > host-coreutils. Disable installing the `date` binary in host-coreutils > when BR2_REPRODUCIBLE is set. > > Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com> > --- > package/coreutils/coreutils.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk > index 65234a113e..1bdfe2f9cf 100644 > --- a/package/coreutils/coreutils.mk > +++ b/package/coreutils/coreutils.mk > @@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \ > --without-gmp \ > --enable-install-program=ln,realpath We were supposed already to only install ln and realpath, so this issue shouldn't have happened to begin with. Could you investigate in a bit more detail why this --enable-install-program doesn't seem to do the trick? > > +# Avoid overwriting fakedate when creating a reproducible build > +ifeq ($(BR2_REPRODUCIBLE),y) If there really is no way to get enable-install-program to work correctly, then we should probably not make this conditional on BR2_REPRODUCIBLE anyway. Regards, Arnout > +HOST_COREUTILS_CONF_OPTS += --enable-no-install-program=date > +endif > + > $(eval $(autotools-package)) > $(eval $(host-autotools-package)) > _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate 2021-08-28 11:47 ` Arnout Vandecappelle @ 2021-08-28 12:22 ` Yann E. MORIN 0 siblings, 0 replies; 4+ messages in thread From: Yann E. MORIN @ 2021-08-28 12:22 UTC (permalink / raw) To: Arnout Vandecappelle; +Cc: Conrad Ratschan, buildroot Arnout, All, On 2021-08-28 13:47 +0200, Arnout Vandecappelle spake thusly: > On 27/08/2021 23:14, Conrad Ratschan via buildroot wrote: > > When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the > > fakedate script installed to `host/bin/date` will be overwritten by > > host-coreutils. Disable installing the `date` binary in host-coreutils > > when BR2_REPRODUCIBLE is set. > > > > Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com> > > --- > > package/coreutils/coreutils.mk | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk > > index 65234a113e..1bdfe2f9cf 100644 > > --- a/package/coreutils/coreutils.mk > > +++ b/package/coreutils/coreutils.mk > > @@ -164,5 +164,10 @@ HOST_COREUTILS_CONF_OPTS = \ > > --without-gmp \ > > --enable-install-program=ln,realpath > We were supposed already to only install ln and realpath, so this issue > shouldn't have happened to begin with. Could you investigate in a bit more > detail why this --enable-install-program doesn't seem to do the trick? See the comment just above the HOST_COREUTILS_CONF_OPTS: # A lot of other programs still get installed, however, but disabling # them does not gain much at build time, and is a loooong list that is # difficult to maintain... > > +# Avoid overwriting fakedate when creating a reproducible build > > +ifeq ($(BR2_REPRODUCIBLE),y) > If there really is no way to get enable-install-program to work correctly, then > we should probably not make this conditional on BR2_REPRODUCIBLE anyway. Yes, we should really just disable it unconditionally... So, I extended the commit log, the comment to explain all that, and uncoditionally disabled installing date. Applied to master, thanks. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate 2021-08-27 21:14 [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate Conrad Ratschan via buildroot 2021-08-28 11:47 ` Arnout Vandecappelle @ 2021-09-07 12:40 ` Peter Korsgaard 1 sibling, 0 replies; 4+ messages in thread From: Peter Korsgaard @ 2021-09-07 12:40 UTC (permalink / raw) To: Conrad Ratschan via buildroot; +Cc: Conrad Ratschan, buildroot >>>>> "Conrad" == Conrad Ratschan via buildroot <buildroot@busybox.net> writes: > When BR2_REPRODUCIBLE is set and host-coreutils needs to be built, the > fakedate script installed to `host/bin/date` will be overwritten by > host-coreutils. Disable installing the `date` binary in host-coreutils > when BR2_REPRODUCIBLE is set. > Signed-off-by: Conrad Ratschan <conrad.ratschan@collins.com> Committed to 2021.02.x and 2021.05.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@lists.buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-07 12:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-27 21:14 [Buildroot] [PATCH 1/1] package/coreutils: Prevent overwriting of fakedate Conrad Ratschan via buildroot 2021-08-28 11:47 ` Arnout Vandecappelle 2021-08-28 12:22 ` Yann E. MORIN 2021-09-07 12:40 ` Peter Korsgaard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.