From: Marc Zyngier <maz@kernel.org>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: jasowang@redhat.com, mst@redhat.com, alex.williamson@redhat.com,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, cohuck@redhat.com,
stable@vger.kernel.org,
Shaokun Zhang <zhangshaokun@hisilicon.com>
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Sat, 08 May 2021 10:29:06 +0100 [thread overview]
Message-ID: <8735uxvajh.wl-maz@kernel.org> (raw)
In-Reply-To: <20210508071152.722425-1-lingshan.zhu@intel.com>
On Sat, 08 May 2021 08:11:52 +0100,
Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>
> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
>
> The reverted commit may cause VM freeze on arm64 platform.
> Because on arm64 platform, stop a consumer will suspend the VM,
> the VM will freeze without a start consumer
It also unconditionally calls del_consumer on the producer, which
isn't exactly expected.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Suggested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect")
Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com
Cc: stable@vger.kernel.org
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
cohuck@redhat.com, stable@vger.kernel.org,
Shaokun Zhang <zhangshaokun@hisilicon.com>,
alex.williamson@redhat.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Sat, 08 May 2021 10:29:06 +0100 [thread overview]
Message-ID: <8735uxvajh.wl-maz@kernel.org> (raw)
In-Reply-To: <20210508071152.722425-1-lingshan.zhu@intel.com>
On Sat, 08 May 2021 08:11:52 +0100,
Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>
> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
>
> The reverted commit may cause VM freeze on arm64 platform.
> Because on arm64 platform, stop a consumer will suspend the VM,
> the VM will freeze without a start consumer
It also unconditionally calls del_consumer on the producer, which
isn't exactly expected.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Suggested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect")
Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com
Cc: stable@vger.kernel.org
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: jasowang@redhat.com, mst@redhat.com, alex.williamson@redhat.com,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, cohuck@redhat.com,
stable@vger.kernel.org,
Shaokun Zhang <zhangshaokun@hisilicon.com>
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Sat, 08 May 2021 10:29:06 +0100 [thread overview]
Message-ID: <8735uxvajh.wl-maz@kernel.org> (raw)
In-Reply-To: <20210508071152.722425-1-lingshan.zhu@intel.com>
On Sat, 08 May 2021 08:11:52 +0100,
Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>
> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
>
> The reverted commit may cause VM freeze on arm64 platform.
> Because on arm64 platform, stop a consumer will suspend the VM,
> the VM will freeze without a start consumer
It also unconditionally calls del_consumer on the producer, which
isn't exactly expected.
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Suggested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect")
Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com
Cc: stable@vger.kernel.org
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-08 9:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 7:11 [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" Zhu Lingshan
2021-05-08 7:11 ` Zhu Lingshan
2021-05-08 7:11 ` Zhu Lingshan
2021-05-08 7:22 ` Greg KH
2021-05-08 7:22 ` Greg KH
2021-05-08 7:22 ` Greg KH
2021-05-08 9:29 ` Marc Zyngier [this message]
2021-05-08 9:29 ` Marc Zyngier
2021-05-08 9:29 ` Marc Zyngier
2021-05-09 17:04 ` Auger Eric
2021-05-09 17:04 ` Auger Eric
2021-05-09 17:04 ` Auger Eric
2021-05-10 1:12 ` Shaokun Zhang
2021-05-10 1:12 ` Shaokun Zhang
2021-05-10 1:12 ` Shaokun Zhang
2021-05-10 7:39 ` Marc Zyngier
2021-05-10 7:39 ` Marc Zyngier
2021-05-10 7:39 ` Marc Zyngier
2021-05-10 2:43 ` Jason Wang
2021-05-10 2:43 ` Jason Wang
2021-05-10 2:43 ` Jason Wang
2021-05-10 3:00 ` Zhu, Lingshan
2021-05-10 3:00 ` Zhu, Lingshan
2021-05-10 3:00 ` Zhu, Lingshan
2021-05-10 4:34 ` Jason Wang
2021-05-10 4:34 ` Jason Wang
2021-05-10 4:34 ` Jason Wang
2021-05-10 7:09 ` Zhu, Lingshan
2021-05-10 7:09 ` Zhu, Lingshan
2021-05-10 7:09 ` Zhu, Lingshan
2021-05-10 8:32 ` Zhu, Lingshan
2021-05-10 8:32 ` Zhu, Lingshan
2021-05-10 8:32 ` Zhu, Lingshan
2021-05-10 10:00 ` Marc Zyngier
2021-05-10 10:00 ` Marc Zyngier
2021-05-10 10:00 ` Marc Zyngier
2021-05-10 10:37 ` Zhu, Lingshan
2021-05-10 10:37 ` Zhu, Lingshan
2021-05-10 10:37 ` Zhu, Lingshan
2021-05-10 11:01 ` Marc Zyngier
2021-05-10 11:01 ` Marc Zyngier
2021-05-10 11:01 ` Marc Zyngier
2021-05-11 8:48 ` Michael S. Tsirkin
2021-05-11 8:48 ` Michael S. Tsirkin
2021-05-11 8:48 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735uxvajh.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=lingshan.zhu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.