From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: dri-devel@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-fbdev@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
Andrzej Hajda <a.hajda@samsung.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Saeed Mahameed <saeedm@mellanox.com>,
masahiroy@kernel.org, Laurent.pinchart@ideasonboard.com,
linux-renesas-soc@vger.kernel.org,
kieran.bingham+renesas@ideasonboard.com, airlied@linux.ie,
daniel@zonque.org, haojian.zhuang@gmail.com, daniel@ffwll.ch,
marex@denx.de, stefan@agner.ch,
linux-graphics-maintainer@vmware.com, thellstrom@vmware.com,
jfrederich@gmail.com, dsd@laptop.org, geert@linux-m68k.org
Subject: Re: [PATCH 2/8] fbdev/ARM: pxa: avoid selecting CONFIG_FB
Date: Sat, 18 Apr 2020 12:18:38 +0200 [thread overview]
Message-ID: <873691p05d.fsf@belgarion.home> (raw)
In-Reply-To: <20200417155553.675905-3-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 17 Apr 2020 17:55:47 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> In order to add more compile-time dependencies to CONFIG_FB, remove the
> last few instances of selecting it from platform code.
>
> This was originally written to allow a modular driver, but that never
> worked because vmlinux cannot call exported functions from a loadable
> module.
>
> Just change the #ifdef check to what it should have been and remove
> the 'select' statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
Ok, so if you remove the select FB_PXA, I think there will be a couple of
defconfigs which _might_ break, namely :
corgi_defconfig
h5000_defconfig
hx4700_good_defconfig
lubbock_defconfig
mmp2_defconfig
multi_v7_defconfig
mvebu_v7_defconfig
pcm027_defconfig
pxa168_defconfig
pxa910_defconfig
xcep_defconfig
zylonite_defconfig
Could you please have a look to see if they shouldn't have a CONFIG_FB_PXA=y and
CONFIG_FB=y now with this change ?
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fbdev@vger.kernel.org, airlied@linux.ie,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent.pinchart@ideasonboard.com, marex@denx.de,
thellstrom@vmware.com, dsd@laptop.org,
Jason Gunthorpe <jgg@ziepe.ca>,
masahiroy@kernel.org, Saeed Mahameed <saeedm@mellanox.com>,
geert@linux-m68k.org, linux-graphics-maintainer@vmware.com,
haojian.zhuang@gmail.com, Nicolas Pitre <nico@fluxnic.net>,
dri-devel@lists.freedesktop.org, jfrederich@gmail.com,
linux-renesas-soc@vger.kernel.org,
kieran.bingham+renesas@ideasonboard.com, daniel@zonque.org
Subject: Re: [PATCH 2/8] fbdev/ARM: pxa: avoid selecting CONFIG_FB
Date: Sat, 18 Apr 2020 10:18:38 +0000 [thread overview]
Message-ID: <873691p05d.fsf@belgarion.home> (raw)
In-Reply-To: <20200417155553.675905-3-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 17 Apr 2020 17:55:47 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> In order to add more compile-time dependencies to CONFIG_FB, remove the
> last few instances of selecting it from platform code.
>
> This was originally written to allow a modular driver, but that never
> worked because vmlinux cannot call exported functions from a loadable
> module.
>
> Just change the #ifdef check to what it should have been and remove
> the 'select' statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
Ok, so if you remove the select FB_PXA, I think there will be a couple of
defconfigs which _might_ break, namely :
corgi_defconfig
h5000_defconfig
hx4700_good_defconfig
lubbock_defconfig
mmp2_defconfig
multi_v7_defconfig
mvebu_v7_defconfig
pcm027_defconfig
pxa168_defconfig
pxa910_defconfig
xcep_defconfig
zylonite_defconfig
Could you please have a look to see if they shouldn't have a CONFIG_FB_PXA=y and
CONFIG_FB=y now with this change ?
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fbdev@vger.kernel.org, airlied@linux.ie,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent.pinchart@ideasonboard.com, marex@denx.de,
thellstrom@vmware.com, dsd@laptop.org,
Jason Gunthorpe <jgg@ziepe.ca>,
masahiroy@kernel.org, Saeed Mahameed <saeedm@mellanox.com>,
geert@linux-m68k.org, linux-graphics-maintainer@vmware.com,
haojian.zhuang@gmail.com, Nicolas Pitre <nico@fluxnic.net>,
dri-devel@lists.freedesktop.org, jfrederich@gmail.com,
linux-renesas-soc@vger.kernel.org,
kieran.bingham+renesas@ideasonboard.com, daniel@zonque.org
Subject: Re: [PATCH 2/8] fbdev/ARM: pxa: avoid selecting CONFIG_FB
Date: Sat, 18 Apr 2020 12:18:38 +0200 [thread overview]
Message-ID: <873691p05d.fsf@belgarion.home> (raw)
In-Reply-To: <20200417155553.675905-3-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 17 Apr 2020 17:55:47 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> In order to add more compile-time dependencies to CONFIG_FB, remove the
> last few instances of selecting it from platform code.
>
> This was originally written to allow a modular driver, but that never
> worked because vmlinux cannot call exported functions from a loadable
> module.
>
> Just change the #ifdef check to what it should have been and remove
> the 'select' statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
Ok, so if you remove the select FB_PXA, I think there will be a couple of
defconfigs which _might_ break, namely :
corgi_defconfig
h5000_defconfig
hx4700_good_defconfig
lubbock_defconfig
mmp2_defconfig
multi_v7_defconfig
mvebu_v7_defconfig
pcm027_defconfig
pxa168_defconfig
pxa910_defconfig
xcep_defconfig
zylonite_defconfig
Could you please have a look to see if they shouldn't have a CONFIG_FB_PXA=y and
CONFIG_FB=y now with this change ?
Cheers.
--
Robert
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-18 10:18 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:55 [PATCH 0/8] drm, fbdev: rework dependencies Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` [PATCH 1/8] fbdev: w100fb: clean up mach-pxa compile-time dependency Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-18 10:10 ` Robert Jarzmik
2020-04-18 10:10 ` Robert Jarzmik
2020-04-18 10:10 ` Robert Jarzmik
2020-04-18 10:14 ` Arnd Bergmann
2020-04-18 10:14 ` Arnd Bergmann
2020-04-18 10:14 ` Arnd Bergmann
2020-04-17 15:55 ` [PATCH 2/8] fbdev/ARM: pxa: avoid selecting CONFIG_FB Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-18 10:18 ` Robert Jarzmik [this message]
2020-04-18 10:18 ` Robert Jarzmik
2020-04-18 10:18 ` Robert Jarzmik
2020-04-17 15:55 ` [PATCH 3/8] fbdev: rework FB_DDC dependencies Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` [PATCH 4/8] drm/rcar: stop using 'imply' for dependencies Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` [PATCH 5/8] drm/vmwgfx: make framebuffer support optional Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-20 12:07 ` Thomas Zimmermann
2020-04-20 12:07 ` Thomas Zimmermann
2020-04-20 12:07 ` Thomas Zimmermann
2020-04-17 15:55 ` [PATCH 6/8] drm: decouple from CONFIG_FB Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 16:50 ` Sam Ravnborg
2020-04-17 16:50 ` Sam Ravnborg
2020-04-17 16:50 ` Sam Ravnborg
2020-04-17 20:03 ` Arnd Bergmann
2020-04-17 20:03 ` Arnd Bergmann
2020-04-17 20:03 ` Arnd Bergmann
2020-04-17 20:29 ` Sam Ravnborg
2020-04-17 20:29 ` Sam Ravnborg
2020-04-17 20:29 ` Sam Ravnborg
2020-04-17 15:55 ` [PATCH 7/8] fbdev: rework backlight dependencies Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 17:04 ` Sam Ravnborg
2020-04-17 17:04 ` Sam Ravnborg
2020-04-17 17:04 ` Sam Ravnborg
2020-04-17 19:55 ` Arnd Bergmann
2020-04-17 19:55 ` Arnd Bergmann
2020-04-17 19:55 ` Arnd Bergmann
2020-04-20 8:02 ` Jani Nikula
2020-04-20 8:02 ` Jani Nikula
2020-04-20 8:02 ` Jani Nikula
2020-04-17 15:55 ` [PATCH 8/8] drm/bridge/sii8620: fix extcon dependency Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 15:55 ` Arnd Bergmann
2020-04-17 16:52 ` Andrzej Hajda
2020-04-17 16:52 ` Andrzej Hajda
2020-04-17 16:52 ` Andrzej Hajda
2020-04-17 17:14 ` [PATCH 0/8] drm, fbdev: rework dependencies Daniel Vetter
2020-04-17 17:14 ` Daniel Vetter
2020-04-17 17:14 ` Daniel Vetter
2020-04-17 19:08 ` Jason Gunthorpe
2020-04-17 19:08 ` Jason Gunthorpe
2020-04-17 19:08 ` Jason Gunthorpe
2020-04-20 8:14 ` Jani Nikula
2020-04-20 8:14 ` Jani Nikula
2020-04-20 8:14 ` Jani Nikula
2020-04-20 14:03 ` Arnd Bergmann
2020-04-20 14:03 ` Arnd Bergmann
2020-04-20 14:03 ` Arnd Bergmann
2020-04-21 12:27 ` Daniel Vetter
2020-04-21 12:27 ` Daniel Vetter
2020-04-21 12:27 ` Daniel Vetter
2020-04-21 12:58 ` Jani Nikula
2020-04-21 12:58 ` Jani Nikula
2020-04-21 12:58 ` Jani Nikula
2020-04-21 13:05 ` Geert Uytterhoeven
2020-04-21 13:05 ` Geert Uytterhoeven
2020-04-21 13:05 ` Geert Uytterhoeven
2020-04-21 13:10 ` Daniel Vetter
2020-04-21 13:10 ` Daniel Vetter
2020-04-21 13:10 ` Daniel Vetter
2020-04-21 13:25 ` Jani Nikula
2020-04-21 13:25 ` Jani Nikula
2020-04-21 13:25 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873691p05d.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=daniel@zonque.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsd@laptop.org \
--cc=geert@linux-m68k.org \
--cc=haojian.zhuang@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=jfrederich@gmail.com \
--cc=jgg@ziepe.ca \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marex@denx.de \
--cc=masahiroy@kernel.org \
--cc=nico@fluxnic.net \
--cc=saeedm@mellanox.com \
--cc=stefan@agner.ch \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.