From: Kevin Hilman <khilman@linaro.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@surriel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Zlatko Calusic <zcalusic@bitsync.net>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, linux-arm-kernel@lists.infradead.org,
Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [patch v2 3/3] mm: page_alloc: fair zone allocator policy
Date: Fri, 16 Aug 2013 14:52:11 -0700 [thread overview]
Message-ID: <8738q9b8xg.fsf@kernel.org> (raw)
In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400")
Johannes Weiner <hannes@cmpxchg.org> writes:
> Hi Kevin,
>
> On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote:
>> Johannes Weiner <hannes@cmpxchg.org> writes:
>> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote:
>> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching
>> >
>> > Avoid dirtying the same cache line with every single page allocation
>> > by making the fair per-zone allocation batch a vmstat item, which will
>> > turn it into batched percpu counters on SMP.
>> >
>> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>>
>> I bisected several boot failures on various ARM platform in
>> next-20130816 down to this patch (commit 67131f9837 in linux-next.)
>>
>> Simply reverting it got things booting again on top of -next. Example
>> boot crash below.
>
> Thanks for the bisect and report!
You're welcome. Thanks for the quick fix!
> I deref the percpu pointers before initializing them properly. It
> didn't trigger on x86 because the percpu offset added to the pointer
> is big enough so that it does not fall into PFN 0, but it probably
> ended up corrupting something...
>
> Could you try this patch on top of linux-next instead of the revert?
Yup, that change fixes it.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@linaro.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@surriel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Zlatko Calusic <zcalusic@bitsync.net>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, linux-arm-kernel@lists.infradead.org,
Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [patch v2 3/3] mm: page_alloc: fair zone allocator policy
Date: Fri, 16 Aug 2013 14:52:11 -0700 [thread overview]
Message-ID: <8738q9b8xg.fsf@kernel.org> (raw)
In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400")
Johannes Weiner <hannes@cmpxchg.org> writes:
> Hi Kevin,
>
> On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote:
>> Johannes Weiner <hannes@cmpxchg.org> writes:
>> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote:
>> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching
>> >
>> > Avoid dirtying the same cache line with every single page allocation
>> > by making the fair per-zone allocation batch a vmstat item, which will
>> > turn it into batched percpu counters on SMP.
>> >
>> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>>
>> I bisected several boot failures on various ARM platform in
>> next-20130816 down to this patch (commit 67131f9837 in linux-next.)
>>
>> Simply reverting it got things booting again on top of -next. Example
>> boot crash below.
>
> Thanks for the bisect and report!
You're welcome. Thanks for the quick fix!
> I deref the percpu pointers before initializing them properly. It
> didn't trigger on x86 because the percpu offset added to the pointer
> is big enough so that it does not fall into PFN 0, but it probably
> ended up corrupting something...
>
> Could you try this patch on top of linux-next instead of the revert?
Yup, that change fixes it.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch v2 3/3] mm: page_alloc: fair zone allocator policy
Date: Fri, 16 Aug 2013 14:52:11 -0700 [thread overview]
Message-ID: <8738q9b8xg.fsf@kernel.org> (raw)
In-Reply-To: <20130816201814.GA26409@cmpxchg.org> (Johannes Weiner's message of "Fri, 16 Aug 2013 16:18:14 -0400")
Johannes Weiner <hannes@cmpxchg.org> writes:
> Hi Kevin,
>
> On Fri, Aug 16, 2013 at 10:17:01AM -0700, Kevin Hilman wrote:
>> Johannes Weiner <hannes@cmpxchg.org> writes:
>> > On Wed, Aug 07, 2013 at 11:37:43AM -0400, Johannes Weiner wrote:
>> > Subject: [patch] mm: page_alloc: use vmstats for fair zone allocation batching
>> >
>> > Avoid dirtying the same cache line with every single page allocation
>> > by making the fair per-zone allocation batch a vmstat item, which will
>> > turn it into batched percpu counters on SMP.
>> >
>> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
>>
>> I bisected several boot failures on various ARM platform in
>> next-20130816 down to this patch (commit 67131f9837 in linux-next.)
>>
>> Simply reverting it got things booting again on top of -next. Example
>> boot crash below.
>
> Thanks for the bisect and report!
You're welcome. Thanks for the quick fix!
> I deref the percpu pointers before initializing them properly. It
> didn't trigger on x86 because the percpu offset added to the pointer
> is big enough so that it does not fall into PFN 0, but it probably
> ended up corrupting something...
>
> Could you try this patch on top of linux-next instead of the revert?
Yup, that change fixes it.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
next prev parent reply other threads:[~2013-08-16 22:18 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 15:37 [patch v2 0/3] mm: improve page aging fairness between zones/nodes Johannes Weiner
2013-08-02 15:37 ` Johannes Weiner
2013-08-02 15:37 ` [patch v2 1/3] mm: vmscan: fix numa reclaim balance problem in kswapd Johannes Weiner
2013-08-02 15:37 ` Johannes Weiner
2013-08-07 14:15 ` Mel Gorman
2013-08-07 14:15 ` Mel Gorman
2013-08-02 15:37 ` [patch v2 2/3] mm: page_alloc: rearrange watermark checking in get_page_from_freelist Johannes Weiner
2013-08-02 15:37 ` Johannes Weiner
2013-08-07 14:20 ` Mel Gorman
2013-08-07 14:20 ` Mel Gorman
2013-08-02 15:37 ` [patch v2 3/3] mm: page_alloc: fair zone allocator policy Johannes Weiner
2013-08-02 15:37 ` Johannes Weiner
2013-08-02 17:51 ` Rik van Riel
2013-08-02 17:51 ` Rik van Riel
2013-08-05 1:15 ` Minchan Kim
2013-08-05 1:15 ` Minchan Kim
2013-08-05 3:43 ` Johannes Weiner
2013-08-05 3:43 ` Johannes Weiner
2013-08-05 4:48 ` Minchan Kim
2013-08-05 4:48 ` Minchan Kim
2013-08-05 5:01 ` Johannes Weiner
2013-08-05 5:01 ` Johannes Weiner
2013-08-05 10:34 ` Wanpeng Li
2013-08-05 10:34 ` Wanpeng Li
2013-08-05 11:34 ` Andrea Arcangeli
2013-08-05 11:34 ` Andrea Arcangeli
2013-08-05 13:11 ` Wanpeng Li
2013-08-05 13:11 ` Wanpeng Li
2013-08-07 14:58 ` Mel Gorman
2013-08-07 14:58 ` Mel Gorman
2013-08-07 15:37 ` Johannes Weiner
2013-08-07 15:37 ` Johannes Weiner
2013-08-08 4:16 ` Johannes Weiner
2013-08-08 4:16 ` Johannes Weiner
2013-08-08 9:21 ` Mel Gorman
2013-08-08 9:21 ` Mel Gorman
2013-08-09 18:45 ` Rik van Riel
2013-08-09 18:45 ` Rik van Riel
2013-08-16 17:07 ` Kevin Hilman
2013-08-16 17:17 ` Kevin Hilman
2013-08-16 20:18 ` Johannes Weiner
2013-08-16 20:18 ` Johannes Weiner
2013-08-16 20:18 ` Johannes Weiner
2013-08-16 21:24 ` Stephen Warren
2013-08-16 21:24 ` Stephen Warren
2013-08-16 21:24 ` Stephen Warren
2013-08-16 21:52 ` Kevin Hilman [this message]
2013-08-16 21:52 ` Kevin Hilman
2013-08-16 21:52 ` Kevin Hilman
2013-08-19 0:48 ` Stephen Rothwell
2013-08-19 0:48 ` Stephen Rothwell
2014-04-02 14:26 ` Thomas Schwinge
2014-04-02 14:26 ` Thomas Schwinge
2014-04-24 13:37 ` radeon: screen garbled after page allocator change, was: " Johannes Weiner
2014-04-24 13:37 ` Johannes Weiner
2014-04-24 13:37 ` Johannes Weiner
2014-04-25 21:47 ` Jerome Glisse
2014-04-25 21:47 ` Jerome Glisse
2014-04-25 21:47 ` Jerome Glisse
2014-04-25 21:50 ` Jerome Glisse
2014-04-25 21:50 ` Jerome Glisse
2014-04-25 23:03 ` Jerome Glisse
2014-04-25 23:03 ` Jerome Glisse
2014-04-25 23:03 ` Jerome Glisse
2014-04-28 8:03 ` Thomas Schwinge
2014-04-28 9:09 ` Thomas Schwinge
2014-04-27 3:31 ` Jerome Glisse
2014-04-27 3:31 ` Jerome Glisse
2014-04-27 3:31 ` Jerome Glisse
2014-04-27 19:55 ` Jerome Glisse
2014-04-27 19:55 ` Jerome Glisse
2014-04-27 19:55 ` Jerome Glisse
2014-04-28 7:30 ` Christian König
2014-04-28 7:30 ` Christian König
2014-04-28 12:51 ` Deucher, Alexander
2014-04-28 12:51 ` Deucher, Alexander
2014-04-28 12:52 ` Deucher, Alexander
2014-04-28 12:52 ` Deucher, Alexander
2014-04-28 8:09 ` Thomas Schwinge
2014-06-16 7:11 ` Thomas Schwinge
2013-08-02 19:59 ` [patch v2 0/3] mm: improve page aging fairness between zones/nodes Andrea Arcangeli
2013-08-02 19:59 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738q9b8xg.fsf@kernel.org \
--to=khilman@linaro.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=olof@lixom.net \
--cc=riel@surriel.com \
--cc=sfr@canb.auug.org.au \
--cc=swarren@wwwdotorg.org \
--cc=zcalusic@bitsync.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.