From: ebiederm@xmission.com (Eric W. Biederman) To: Nathan Chancellor <nathan@kernel.org> Cc: Santosh Shilimkar <ssantosh@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@kernel.org> Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread() Date: Mon, 08 Nov 2021 13:18:41 -0600 [thread overview] Message-ID: <877ddipib2.fsf@disp2133> (raw) In-Reply-To: <20211102160315.1067553-1-nathan@kernel.org> (Nathan Chancellor's message of "Tue, 2 Nov 2021 09:03:15 -0700") Nathan Chancellor <nathan@kernel.org> writes: > This function should not return a value: > > drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread': > drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type] > 429 | return 0; > | ^ > drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here > 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors Apologies for not replying to this sooner. I did not realize at first that this was in response to one of my changes. Arnd also reported this and included a correct fix please see: https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org Thank you, Eric > > Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/soc/ti/wkup_m3_ipc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 0733443a2631..2238beb40f8d 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > dev_err(dev, "rproc_boot failed\n"); > else > m3_ipc_state = m3_ipc; > - > - return 0; > } > > static int wkup_m3_ipc_probe(struct platform_device *pdev) > > base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm@xmission.com (Eric W. Biederman) To: Nathan Chancellor <nathan@kernel.org> Cc: Santosh Shilimkar <ssantosh@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@kernel.org> Subject: Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread() Date: Mon, 08 Nov 2021 13:18:41 -0600 [thread overview] Message-ID: <877ddipib2.fsf@disp2133> (raw) In-Reply-To: <20211102160315.1067553-1-nathan@kernel.org> (Nathan Chancellor's message of "Tue, 2 Nov 2021 09:03:15 -0700") Nathan Chancellor <nathan@kernel.org> writes: > This function should not return a value: > > drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread': > drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type] > 429 | return 0; > | ^ > drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here > 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors Apologies for not replying to this sooner. I did not realize at first that this was in response to one of my changes. Arnd also reported this and included a correct fix please see: https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org Thank you, Eric > > Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/soc/ti/wkup_m3_ipc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 0733443a2631..2238beb40f8d 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc) > dev_err(dev, "rproc_boot failed\n"); > else > m3_ipc_state = m3_ipc; > - > - return 0; > } > > static int wkup_m3_ipc_probe(struct platform_device *pdev) > > base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-08 19:19 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-02 16:03 [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread() Nathan Chancellor 2021-11-02 16:03 ` Nathan Chancellor 2021-11-08 19:18 ` Eric W. Biederman [this message] 2021-11-08 19:18 ` Eric W. Biederman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=877ddipib2.fsf@disp2133 \ --to=ebiederm@xmission.com \ --cc=arnd@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nathan@kernel.org \ --cc=ssantosh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.