* [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread()
@ 2021-11-02 16:03 ` Nathan Chancellor
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2021-11-02 16:03 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Santosh Shilimkar, linux-kernel, linux-arm-kernel, Nathan Chancellor
This function should not return a value:
drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
429 | return 0;
| ^
drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/soc/ti/wkup_m3_ipc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 0733443a2631..2238beb40f8d 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
dev_err(dev, "rproc_boot failed\n");
else
m3_ipc_state = m3_ipc;
-
- return 0;
}
static int wkup_m3_ipc_probe(struct platform_device *pdev)
base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495
--
2.34.0.rc0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread()
@ 2021-11-02 16:03 ` Nathan Chancellor
0 siblings, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2021-11-02 16:03 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Santosh Shilimkar, linux-kernel, linux-arm-kernel, Nathan Chancellor
This function should not return a value:
drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
429 | return 0;
| ^
drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/soc/ti/wkup_m3_ipc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 0733443a2631..2238beb40f8d 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
dev_err(dev, "rproc_boot failed\n");
else
m3_ipc_state = m3_ipc;
-
- return 0;
}
static int wkup_m3_ipc_probe(struct platform_device *pdev)
base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495
--
2.34.0.rc0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread()
2021-11-02 16:03 ` Nathan Chancellor
@ 2021-11-08 19:18 ` Eric W. Biederman
-1 siblings, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2021-11-08 19:18 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Santosh Shilimkar, linux-kernel, linux-arm-kernel, Arnd Bergmann
Nathan Chancellor <nathan@kernel.org> writes:
> This function should not return a value:
>
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
> 429 | return 0;
> | ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
> 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
Apologies for not replying to this sooner. I did not realize at first
that this was in response to one of my changes.
Arnd also reported this and included a correct fix please see:
https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org
Thank you,
Eric
>
> Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 0733443a2631..2238beb40f8d 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> dev_err(dev, "rproc_boot failed\n");
> else
> m3_ipc_state = m3_ipc;
> -
> - return 0;
> }
>
> static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread()
@ 2021-11-08 19:18 ` Eric W. Biederman
0 siblings, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2021-11-08 19:18 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Santosh Shilimkar, linux-kernel, linux-arm-kernel, Arnd Bergmann
Nathan Chancellor <nathan@kernel.org> writes:
> This function should not return a value:
>
> drivers/soc/ti/wkup_m3_ipc.c: In function 'wkup_m3_rproc_boot_thread':
> drivers/soc/ti/wkup_m3_ipc.c:429:16: error: 'return' with a value, in function returning void [-Werror=return-type]
> 429 | return 0;
> | ^
> drivers/soc/ti/wkup_m3_ipc.c:416:13: note: declared here
> 416 | static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
Apologies for not replying to this sooner. I did not realize at first
that this was in response to one of my changes.
Arnd also reported this and included a correct fix please see:
https://lkml.kernel.org/r/20211105075119.2327190-1-arnd@kernel.org
Thank you,
Eric
>
> Fixes: 111e70490d2a ("exit/kthread: Have kernel threads return instead of calling do_exit")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 0733443a2631..2238beb40f8d 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -425,8 +425,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> dev_err(dev, "rproc_boot failed\n");
> else
> m3_ipc_state = m3_ipc;
> -
> - return 0;
> }
>
> static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> base-commit: ac4fdfaf4792d41ad7b24d1c8ab486aeb7ccd495
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-08 19:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 16:03 [PATCH] soc: ti: wkup_m3_ipc: Fix return type error in wkup_m3_rproc_boot_thread() Nathan Chancellor
2021-11-02 16:03 ` Nathan Chancellor
2021-11-08 19:18 ` Eric W. Biederman
2021-11-08 19:18 ` Eric W. Biederman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.