From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] ath11k: Add multi TX ring support for WCN6750
Date: Fri, 02 Sep 2022 15:49:24 +0300 [thread overview]
Message-ID: <878rn2aqln.fsf@kernel.org> (raw)
In-Reply-To: <20220720135113.15755-3-quic_mpubbise@quicinc.com> (Manikanta Pubbisetty's message of "Wed, 20 Jul 2022 19:21:12 +0530")
Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
> Currently in the case of WCN6750, only one TCL ring is used for TX,
> this is limiting the TX throughput in 160 MHz case, enabling multiple
> TCL rings on WCN6750 has shown an improvement of nearly 300 Mbps in
> the case of TCP TX, therefore add the support of multi TX ring for
> WCN6750.
>
> Currently TCL ring is selected based on CPU ID, this logic cannot be
> applied for WCN6750 as there is chance of out of order TX of packets
> and to avoid this, choose TCL ring based on flow hash so that packets
> of the same flow will end up on same TCL ring. For the same reason,
> TCL ring retry logic is also not applicable for WCN6750.
>
> Also the mapping of TCL, WBM & RBM IDs for WCN6750 is different from
> existing devices. Create a new TCM/WBM/RBM mapping for WCN6750.
>
> Change does not impact existing ath11k devices.
It would also nice to document _why_ it doesn't impact existing (or do
you mean "other"?) devices.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] ath11k: Add multi TX ring support for WCN6750
Date: Fri, 02 Sep 2022 15:49:24 +0300 [thread overview]
Message-ID: <878rn2aqln.fsf@kernel.org> (raw)
In-Reply-To: <20220720135113.15755-3-quic_mpubbise@quicinc.com> (Manikanta Pubbisetty's message of "Wed, 20 Jul 2022 19:21:12 +0530")
Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
> Currently in the case of WCN6750, only one TCL ring is used for TX,
> this is limiting the TX throughput in 160 MHz case, enabling multiple
> TCL rings on WCN6750 has shown an improvement of nearly 300 Mbps in
> the case of TCP TX, therefore add the support of multi TX ring for
> WCN6750.
>
> Currently TCL ring is selected based on CPU ID, this logic cannot be
> applied for WCN6750 as there is chance of out of order TX of packets
> and to avoid this, choose TCL ring based on flow hash so that packets
> of the same flow will end up on same TCL ring. For the same reason,
> TCL ring retry logic is also not applicable for WCN6750.
>
> Also the mapping of TCL, WBM & RBM IDs for WCN6750 is different from
> existing devices. Create a new TCM/WBM/RBM mapping for WCN6750.
>
> Change does not impact existing ath11k devices.
It would also nice to document _why_ it doesn't impact existing (or do
you mean "other"?) devices.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-09-02 12:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 13:51 [PATCH 0/3] Throughput fixes for WCN6750 Manikanta Pubbisetty
2022-07-20 13:51 ` Manikanta Pubbisetty
2022-07-20 13:51 ` [PATCH 1/3] ath11k: Enable threaded NAPI on WCN6750 Manikanta Pubbisetty
2022-07-20 13:51 ` Manikanta Pubbisetty
2022-09-02 12:37 ` Kalle Valo
2022-09-02 12:37 ` Kalle Valo
2022-09-02 12:54 ` Manikanta Pubbisetty
2022-09-02 12:54 ` Manikanta Pubbisetty
2022-09-02 12:48 ` Kalle Valo
2022-09-02 12:48 ` Kalle Valo
2022-09-02 13:17 ` Manikanta Pubbisetty
2022-09-02 13:17 ` Manikanta Pubbisetty
2022-09-02 13:20 ` Robert Marko
2022-09-02 13:20 ` Robert Marko
2022-09-02 13:42 ` Manikanta Pubbisetty
2022-09-02 13:42 ` Manikanta Pubbisetty
2022-09-02 13:46 ` Robert Marko
2022-09-02 13:46 ` Robert Marko
2022-09-02 14:30 ` Manikanta Pubbisetty
2022-09-02 14:30 ` Manikanta Pubbisetty
2022-09-08 6:46 ` Kalle Valo
2022-09-08 6:46 ` Kalle Valo
2022-09-08 8:49 ` Robert Marko
2022-09-08 8:49 ` Robert Marko
2022-09-08 12:15 ` Kalle Valo
2022-09-08 12:15 ` Kalle Valo
2022-09-08 6:49 ` Kalle Valo
2022-09-08 6:49 ` Kalle Valo
2022-07-20 13:51 ` [PATCH 2/3] ath11k: Add multi TX ring support for WCN6750 Manikanta Pubbisetty
2022-07-20 13:51 ` Manikanta Pubbisetty
2022-09-02 12:49 ` Kalle Valo [this message]
2022-09-02 12:49 ` Kalle Valo
2022-09-02 13:44 ` Manikanta Pubbisetty
2022-09-02 13:44 ` Manikanta Pubbisetty
2022-07-20 13:51 ` [PATCH 3/3] ath11k: Increase TCL data ring size " Manikanta Pubbisetty
2022-07-20 13:51 ` Manikanta Pubbisetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rn2aqln.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_mpubbise@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.