All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath11k: Enable threaded NAPI on WCN6750
Date: Thu, 08 Sep 2022 15:15:31 +0300	[thread overview]
Message-ID: <87tu5i83ks.fsf@kernel.org> (raw)
In-Reply-To: <CA+HBbNEAgMPKJFrAYGUT1x-XAX81tTNj4W5xgW-bYSm5j_r_4w@mail.gmail.com> (Robert Marko's message of "Thu, 8 Sep 2022 10:49:30 +0200")

Robert Marko <robert.marko@sartura.hr> writes:

> On Thu, Sep 8, 2022 at 8:46 AM Kalle Valo <kvalo@kernel.org> wrote:
>
>>
>> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>>
>> > On 9/2/2022 7:16 PM, Robert Marko wrote:
>> >> On Fri, Sep 2, 2022 at 3:42 PM Manikanta Pubbisetty
>> >> <quic_mpubbise@quicinc.com> wrote:
>> >>>
>> >>> On 9/2/2022 6:50 PM, Robert Marko wrote:
>> >>>> On Fri, Sep 2, 2022 at 3:18 PM Manikanta Pubbisetty
>> >>>> <quic_mpubbise@quicinc.com> wrote:
>> >>>>>
>> >>>>> Regardless of the chip family, even I feel that the tput changes like
>> >>>>> these should be tested on all the chipsets. Availability of the hardware
>> >>>>> and time are something which are stopping me in testing the changes on
>> >>>>> all supported targets.
>> >>>>>
>> >>>>> As I said, I had made the changes only to WCN6750 initially (using a
>> >>>>> hw_param). Can we take that approach for now and enable this for other
>> >>>>> targets only if required & upon thorough testing?
>> >>>>
>> >>>> I can tell you that on IPQ8074 threaded NAPI really improves perfromance.
>> >>>>
>> >>>
>> >>> Great. Do you have any test results on IPQ8074?
>> >>
>> >> I dont have full test results, but on Poco F2 Pro as the client @80MHz AX
>> >> I got ~720Mbps compared to ~550Mbps before.
>> >>
>> >> I can tell you that in OpenWrt, we have had it enabled for 6+ months
>> >> at this point
>> >> and its been really good.
>> >>
>> >
>> > That's a significant improvement, great to hear that. We have another
>> > strong reason to have this change in upstream driver.
>>
>> Indeed, thanks Robert. Is the code in openwrt similar as what
>> Manikanta's patch does?
>
> It's actually identical, we are also just calling dev_set_threaded
> before napi_enable.

Nice, even better :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
	 ath11k@lists.infradead.org,  linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath11k: Enable threaded NAPI on WCN6750
Date: Thu, 08 Sep 2022 15:15:31 +0300	[thread overview]
Message-ID: <87tu5i83ks.fsf@kernel.org> (raw)
In-Reply-To: <CA+HBbNEAgMPKJFrAYGUT1x-XAX81tTNj4W5xgW-bYSm5j_r_4w@mail.gmail.com> (Robert Marko's message of "Thu, 8 Sep 2022 10:49:30 +0200")

Robert Marko <robert.marko@sartura.hr> writes:

> On Thu, Sep 8, 2022 at 8:46 AM Kalle Valo <kvalo@kernel.org> wrote:
>
>>
>> Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes:
>>
>> > On 9/2/2022 7:16 PM, Robert Marko wrote:
>> >> On Fri, Sep 2, 2022 at 3:42 PM Manikanta Pubbisetty
>> >> <quic_mpubbise@quicinc.com> wrote:
>> >>>
>> >>> On 9/2/2022 6:50 PM, Robert Marko wrote:
>> >>>> On Fri, Sep 2, 2022 at 3:18 PM Manikanta Pubbisetty
>> >>>> <quic_mpubbise@quicinc.com> wrote:
>> >>>>>
>> >>>>> Regardless of the chip family, even I feel that the tput changes like
>> >>>>> these should be tested on all the chipsets. Availability of the hardware
>> >>>>> and time are something which are stopping me in testing the changes on
>> >>>>> all supported targets.
>> >>>>>
>> >>>>> As I said, I had made the changes only to WCN6750 initially (using a
>> >>>>> hw_param). Can we take that approach for now and enable this for other
>> >>>>> targets only if required & upon thorough testing?
>> >>>>
>> >>>> I can tell you that on IPQ8074 threaded NAPI really improves perfromance.
>> >>>>
>> >>>
>> >>> Great. Do you have any test results on IPQ8074?
>> >>
>> >> I dont have full test results, but on Poco F2 Pro as the client @80MHz AX
>> >> I got ~720Mbps compared to ~550Mbps before.
>> >>
>> >> I can tell you that in OpenWrt, we have had it enabled for 6+ months
>> >> at this point
>> >> and its been really good.
>> >>
>> >
>> > That's a significant improvement, great to hear that. We have another
>> > strong reason to have this change in upstream driver.
>>
>> Indeed, thanks Robert. Is the code in openwrt similar as what
>> Manikanta's patch does?
>
> It's actually identical, we are also just calling dev_set_threaded
> before napi_enable.

Nice, even better :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2022-09-08 12:15 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 13:51 [PATCH 0/3] Throughput fixes for WCN6750 Manikanta Pubbisetty
2022-07-20 13:51 ` Manikanta Pubbisetty
2022-07-20 13:51 ` [PATCH 1/3] ath11k: Enable threaded NAPI on WCN6750 Manikanta Pubbisetty
2022-07-20 13:51   ` Manikanta Pubbisetty
2022-09-02 12:37   ` Kalle Valo
2022-09-02 12:37     ` Kalle Valo
2022-09-02 12:54     ` Manikanta Pubbisetty
2022-09-02 12:54       ` Manikanta Pubbisetty
2022-09-02 12:48   ` Kalle Valo
2022-09-02 12:48     ` Kalle Valo
2022-09-02 13:17     ` Manikanta Pubbisetty
2022-09-02 13:17       ` Manikanta Pubbisetty
2022-09-02 13:20       ` Robert Marko
2022-09-02 13:20         ` Robert Marko
2022-09-02 13:42         ` Manikanta Pubbisetty
2022-09-02 13:42           ` Manikanta Pubbisetty
2022-09-02 13:46           ` Robert Marko
2022-09-02 13:46             ` Robert Marko
2022-09-02 14:30             ` Manikanta Pubbisetty
2022-09-02 14:30               ` Manikanta Pubbisetty
2022-09-08  6:46               ` Kalle Valo
2022-09-08  6:46                 ` Kalle Valo
2022-09-08  8:49                 ` Robert Marko
2022-09-08  8:49                   ` Robert Marko
2022-09-08 12:15                   ` Kalle Valo [this message]
2022-09-08 12:15                     ` Kalle Valo
2022-09-08  6:49       ` Kalle Valo
2022-09-08  6:49         ` Kalle Valo
2022-07-20 13:51 ` [PATCH 2/3] ath11k: Add multi TX ring support for WCN6750 Manikanta Pubbisetty
2022-07-20 13:51   ` Manikanta Pubbisetty
2022-09-02 12:49   ` Kalle Valo
2022-09-02 12:49     ` Kalle Valo
2022-09-02 13:44     ` Manikanta Pubbisetty
2022-09-02 13:44       ` Manikanta Pubbisetty
2022-07-20 13:51 ` [PATCH 3/3] ath11k: Increase TCL data ring size " Manikanta Pubbisetty
2022-07-20 13:51   ` Manikanta Pubbisetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu5i83ks.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_mpubbise@quicinc.com \
    --cc=robert.marko@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.