All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 0/2] ath11k: add handler for board-2.bin without variant and read SMBIOS
Date: Mon, 21 Mar 2022 12:31:58 +0200	[thread overview]
Message-ID: <878rt3oau9.fsf@kernel.org> (raw)
In-Reply-To: <20220315104721.26649-1-quic_wgong@quicinc.com> (Wen Gong's message of "Tue, 15 Mar 2022 06:47:19 -0400")

Wen Gong <quic_wgong@quicinc.com> writes:

> v6:
>    1. rebased to ath.git ath-202203101556
>    2. add error message if could not find any board data at last.
>    3. change "ath11k: add read variant from SMBIOS for download board data" for
>       add struct ath11k_smbios_bdf, strlen(), not mix defines and function declarations.
>
> v5:
>    1. rebased to ath.git ath-202112161538
>    2. fix warning "failed to fetch board data for bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=DE_1901 from ath11k/QCA6390/hw2.0/board-2.bin"
>
> v4:
>    1. add helper function ath11k_core_create_fallback_board_name()
>    2. rebased to ath.git ath-202112071521
>
> v3:
>    1. add patch "ath11k: add fallback board name without variant while searching board-2.bin"
>    2. reabsed to latest ath.git master ath-202111221436
>
> v2: rebased to latest ath.git master ath-202111170737
>
> When it does not have matched board name with variant in board-2.bin,
> ath11k will fallback to search without variant.
>
> Also read the variant from SMBIOS.

Thanks, I now tested this patchset and looks to work perfectly now.

BTW, please add the change log here, that is after the description but
before the patch list below. In other words, the cover letter needs to
have the desription as the first thing.

> Wen Gong (2):
>   ath11k: add fallback board name without variant while searching
>     board-2.bin
>   ath11k: add read variant from SMBIOS for download board data
>
>  drivers/net/wireless/ath/ath11k/core.c | 116 +++++++++++++++++++++++--
>  drivers/net/wireless/ath/ath11k/core.h |  20 ++++-
>  drivers/net/wireless/ath/ath11k/qmi.c  |   4 +
>  3 files changed, 132 insertions(+), 8 deletions(-)
>
>
> base-commit: d845cf007bdf8b2bf41522e1ecd0eb804e553d57
> -- 
> 2.31.1

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: <ath11k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v6 0/2] ath11k: add handler for board-2.bin without variant and read SMBIOS
Date: Mon, 21 Mar 2022 12:31:58 +0200	[thread overview]
Message-ID: <878rt3oau9.fsf@kernel.org> (raw)
In-Reply-To: <20220315104721.26649-1-quic_wgong@quicinc.com> (Wen Gong's message of "Tue, 15 Mar 2022 06:47:19 -0400")

Wen Gong <quic_wgong@quicinc.com> writes:

> v6:
>    1. rebased to ath.git ath-202203101556
>    2. add error message if could not find any board data at last.
>    3. change "ath11k: add read variant from SMBIOS for download board data" for
>       add struct ath11k_smbios_bdf, strlen(), not mix defines and function declarations.
>
> v5:
>    1. rebased to ath.git ath-202112161538
>    2. fix warning "failed to fetch board data for bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=DE_1901 from ath11k/QCA6390/hw2.0/board-2.bin"
>
> v4:
>    1. add helper function ath11k_core_create_fallback_board_name()
>    2. rebased to ath.git ath-202112071521
>
> v3:
>    1. add patch "ath11k: add fallback board name without variant while searching board-2.bin"
>    2. reabsed to latest ath.git master ath-202111221436
>
> v2: rebased to latest ath.git master ath-202111170737
>
> When it does not have matched board name with variant in board-2.bin,
> ath11k will fallback to search without variant.
>
> Also read the variant from SMBIOS.

Thanks, I now tested this patchset and looks to work perfectly now.

BTW, please add the change log here, that is after the description but
before the patch list below. In other words, the cover letter needs to
have the desription as the first thing.

> Wen Gong (2):
>   ath11k: add fallback board name without variant while searching
>     board-2.bin
>   ath11k: add read variant from SMBIOS for download board data
>
>  drivers/net/wireless/ath/ath11k/core.c | 116 +++++++++++++++++++++++--
>  drivers/net/wireless/ath/ath11k/core.h |  20 ++++-
>  drivers/net/wireless/ath/ath11k/qmi.c  |   4 +
>  3 files changed, 132 insertions(+), 8 deletions(-)
>
>
> base-commit: d845cf007bdf8b2bf41522e1ecd0eb804e553d57
> -- 
> 2.31.1

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  parent reply	other threads:[~2022-03-21 10:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 10:47 [PATCH v6 0/2] ath11k: add handler for board-2.bin without variant and read SMBIOS Wen Gong
2022-03-15 10:47 ` Wen Gong
2022-03-15 10:47 ` [PATCH v6 1/2] ath11k: add fallback board name without variant while searching board-2.bin Wen Gong
2022-03-15 10:47   ` Wen Gong
2022-03-25 10:30   ` Kalle Valo
2022-03-25 10:30     ` Kalle Valo
2022-03-15 10:47 ` [PATCH v6 2/2] ath11k: add read variant from SMBIOS for download board data Wen Gong
2022-03-15 10:47   ` Wen Gong
2022-03-21 10:33   ` Kalle Valo
2022-03-21 10:33     ` Kalle Valo
2022-03-23  8:47   ` Kalle Valo
2022-03-23  8:47     ` Kalle Valo
2022-03-23  8:52     ` Wen Gong
2022-03-23  8:52       ` Wen Gong
2022-03-23 13:05       ` Kalle Valo
2022-03-23 13:05         ` Kalle Valo
2022-03-21 10:31 ` Kalle Valo [this message]
2022-03-21 10:31   ` [PATCH v6 0/2] ath11k: add handler for board-2.bin without variant and read SMBIOS Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rt3oau9.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_wgong@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.