From: Kalle Valo <kvalo@kernel.org> To: Wen Gong <quic_wgong@quicinc.com> Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org> Subject: Re: [PATCH v6 2/2] ath11k: add read variant from SMBIOS for download board data Date: Wed, 23 Mar 2022 10:47:46 +0200 [thread overview] Message-ID: <87r16tkqbx.fsf@kernel.org> (raw) In-Reply-To: <20220315104721.26649-3-quic_wgong@quicinc.com> (Wen Gong's message of "Tue, 15 Mar 2022 06:47:21 -0400") Wen Gong <quic_wgong@quicinc.com> writes: > This is to read variant from SMBIOS such as read from DT, the variant > string will be used to one part of string which used to search board > data from board-2.bin. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Signed-off-by: Wen Gong <quic_wgong@quicinc.com> [...] > +struct ath11k_smbios_bdf { > + struct dmi_header hdr; > + u32 padding; > + u8 bdf_enabled; > + u8 bdf_ext[1]; > +}; I was about to commit this but noticed bdf_ext[1], is there a reason for that? Use of [1] in arrays is deprecated nowadays: https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org> To: Wen Gong <quic_wgong@quicinc.com> Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org> Subject: Re: [PATCH v6 2/2] ath11k: add read variant from SMBIOS for download board data Date: Wed, 23 Mar 2022 10:47:46 +0200 [thread overview] Message-ID: <87r16tkqbx.fsf@kernel.org> (raw) In-Reply-To: <20220315104721.26649-3-quic_wgong@quicinc.com> (Wen Gong's message of "Tue, 15 Mar 2022 06:47:21 -0400") Wen Gong <quic_wgong@quicinc.com> writes: > This is to read variant from SMBIOS such as read from DT, the variant > string will be used to one part of string which used to search board > data from board-2.bin. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3 > > Signed-off-by: Wen Gong <quic_wgong@quicinc.com> [...] > +struct ath11k_smbios_bdf { > + struct dmi_header hdr; > + u32 padding; > + u8 bdf_enabled; > + u8 bdf_ext[1]; > +}; I was about to commit this but noticed bdf_ext[1], is there a reason for that? Use of [1] in arrays is deprecated nowadays: https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-03-23 8:47 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-15 10:47 [PATCH v6 0/2] ath11k: add handler for board-2.bin without variant and read SMBIOS Wen Gong 2022-03-15 10:47 ` Wen Gong 2022-03-15 10:47 ` [PATCH v6 1/2] ath11k: add fallback board name without variant while searching board-2.bin Wen Gong 2022-03-15 10:47 ` Wen Gong 2022-03-25 10:30 ` Kalle Valo 2022-03-25 10:30 ` Kalle Valo 2022-03-15 10:47 ` [PATCH v6 2/2] ath11k: add read variant from SMBIOS for download board data Wen Gong 2022-03-15 10:47 ` Wen Gong 2022-03-21 10:33 ` Kalle Valo 2022-03-21 10:33 ` Kalle Valo 2022-03-23 8:47 ` Kalle Valo [this message] 2022-03-23 8:47 ` Kalle Valo 2022-03-23 8:52 ` Wen Gong 2022-03-23 8:52 ` Wen Gong 2022-03-23 13:05 ` Kalle Valo 2022-03-23 13:05 ` Kalle Valo 2022-03-21 10:31 ` [PATCH v6 0/2] ath11k: add handler for board-2.bin without variant and read SMBIOS Kalle Valo 2022-03-21 10:31 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87r16tkqbx.fsf@kernel.org \ --to=kvalo@kernel.org \ --cc=ath11k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=quic_wgong@quicinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.