From: Markus Armbruster <armbru@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: ensuring a machine's buses have unique names
Date: Wed, 22 Sep 2021 15:07:11 +0200 [thread overview]
Message-ID: <878rzokbcw.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <79a46e17-ddae-eab8-9ff6-80c3a64d0cb@eik.bme.hu> (BALATON Zoltan's message of "Wed, 22 Sep 2021 11:58:24 +0200 (CEST)")
BALATON Zoltan <balaton@eik.bme.hu> writes:
> On Wed, 22 Sep 2021, Markus Armbruster wrote:
>> BALATON Zoltan <balaton@eik.bme.hu> writes:
>>> To me it looks like device code can't really set a globally unique
>>> name on creating the bus without getting some help from upper
>>> levels. So maybe naming busses should be done by qdev (or whatever is
>>> handling this) instead of passing the name as an argument to
>>> qbus_create or only use that name as a unique component within the
>>> device and append it to a unique name for the device.
>>
>> Have you read the whole thread? qdev does come up with a name when
>
> No I haven't. This just got my attention because I'm responsible for
> adding ati-vga.ddc and sm501.i2c and some ppc440 stuff so I was
> wondering what could I do better bur otherwise I did not check the
> whole thread so just ignore what I said if it's not useful in this
> context.
I wouldn't call it "not useful".
What you could do better in future code: pass a null bus name. This is
not obvious. As Peter noted "we created a family of easy-to-misuse
APIs".
[...]
next prev parent reply other threads:[~2021-09-22 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:05 ensuring a machine's buses have unique names Peter Maydell
2021-08-26 13:00 ` Peter Maydell
2021-08-26 14:08 ` Markus Armbruster
2021-09-14 15:25 ` Peter Maydell
2021-09-15 4:28 ` Markus Armbruster
2021-09-21 13:20 ` Peter Maydell
2021-09-21 15:48 ` BALATON Zoltan
2021-09-22 4:37 ` Markus Armbruster
2021-09-22 9:58 ` BALATON Zoltan
2021-09-22 13:07 ` Markus Armbruster [this message]
2021-09-22 7:02 ` Markus Armbruster
2021-09-22 8:14 ` Cédric Le Goater
2021-09-22 4:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rzokbcw.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.