* [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf
@ 2019-04-09 13:17 Giulio Benetti
2019-04-11 6:22 ` Thomas Petazzoni
2019-04-14 21:19 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-04-09 13:17 UTC (permalink / raw)
To: buildroot
Host version of this package needs pkg-conf the same way as target
package: for Makefiles library dependencies retrieving.
Set HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES) to
provide host-pkg-conf.
Fixes:
http://autobuild.buildroot.net/results/854/8543eb3815a67747349a2e60654d19b9804a3a89/
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
package/android-tools/android-tools.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/android-tools/android-tools.mk b/package/android-tools/android-tools.mk
index 3a63139014..b8808057a2 100644
--- a/package/android-tools/android-tools.mk
+++ b/package/android-tools/android-tools.mk
@@ -12,6 +12,7 @@ HOST_ANDROID_TOOLS_EXTRA_DOWNLOADS = $(ANDROID_TOOLS_EXTRA_DOWNLOADS)
ANDROID_TOOLS_LICENSE = Apache-2.0
ANDROID_TOOLS_LICENSE_FILES = debian/copyright
ANDROID_TOOLS_DEPENDENCIES = host-pkgconf
+HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES)
# Extract the Debian tarball inside the sources
define ANDROID_TOOLS_DEBIAN_EXTRACT
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf
2019-04-09 13:17 [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf Giulio Benetti
@ 2019-04-11 6:22 ` Thomas Petazzoni
2019-04-11 6:25 ` Thomas Petazzoni
2019-04-14 21:19 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-11 6:22 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 9 Apr 2019 15:17:54 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> ANDROID_TOOLS_DEPENDENCIES = host-pkgconf
> +HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES)
We don't typically re-use the target dependencies variable for the host
dependencies. So I changed this to = host-pkgconf and applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf
2019-04-11 6:22 ` Thomas Petazzoni
@ 2019-04-11 6:25 ` Thomas Petazzoni
2019-04-11 6:46 ` Giulio Benetti
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-04-11 6:25 UTC (permalink / raw)
To: buildroot
On Thu, 11 Apr 2019 08:22:18 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> We don't typically re-use the target dependencies variable for the host
> dependencies. So I changed this to = host-pkgconf and applied.
An illustration of why re-using $(ANDROID_TOOLS_DEPENDENCIES) doesn't
do what you think it does:
$ cat foo.mk
FOO_DEPENDENCIES = host-pkgconf
HOST_FOO_DEPENDENCIES = $(FOO_DEPENDENCIES)
FOO_DEPENDENCIES += zlib
HOST_FOO_DEPENDENCIES += host-zlib
all:
@echo $(FOO_DEPENDENCIES)
@echo $(HOST_FOO_DEPENDENCIES)
$ make -f foo.mk
host-pkgconf zlib
host-pkgconf zlib host-zlib
See how HOST_FOO_DEPENDENCIES contains "zlib" ?
= assignments are evaluated at the time of use, not at the time of
assignment (contrary to := assignments).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf
2019-04-11 6:25 ` Thomas Petazzoni
@ 2019-04-11 6:46 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-04-11 6:46 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Il 11/04/2019 08:25, Thomas Petazzoni ha scritto:
> On Thu, 11 Apr 2019 08:22:18 +0200
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
>> We don't typically re-use the target dependencies variable for the host
>> dependencies. So I changed this to = host-pkgconf and applied.
>
> An illustration of why re-using $(ANDROID_TOOLS_DEPENDENCIES) doesn't
> do what you think it does:
>
> $ cat foo.mk
> FOO_DEPENDENCIES = host-pkgconf
> HOST_FOO_DEPENDENCIES = $(FOO_DEPENDENCIES)
>
> FOO_DEPENDENCIES += zlib
> HOST_FOO_DEPENDENCIES += host-zlib
>
> all:
> @echo $(FOO_DEPENDENCIES)
> @echo $(HOST_FOO_DEPENDENCIES)
> $ make -f foo.mk
> host-pkgconf zlib
> host-pkgconf zlib host-zlib
>
> See how HOST_FOO_DEPENDENCIES contains "zlib" ?
>
> = assignments are evaluated at the time of use, not at the time of
> assignment (contrary to := assignments).
Aah, this is why, '=' vs ':='.
Thank you for the explanation.
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf
2019-04-09 13:17 [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf Giulio Benetti
2019-04-11 6:22 ` Thomas Petazzoni
@ 2019-04-14 21:19 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-04-14 21:19 UTC (permalink / raw)
To: buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:
> Host version of this package needs pkg-conf the same way as target
> package: for Makefiles library dependencies retrieving.
> Set HOST_ANDROID_TOOLS_DEPENDENCIES = $(ANDROID_TOOLS_DEPENDENCIES) to
> provide host-pkg-conf.
> Fixes:
> http://autobuild.buildroot.net/results/854/8543eb3815a67747349a2e60654d19b9804a3a89/
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Committed to 2019.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-14 21:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 13:17 [Buildroot] [PATCH] package/android-tools: host-android-tools need pkg-conf Giulio Benetti
2019-04-11 6:22 ` Thomas Petazzoni
2019-04-11 6:25 ` Thomas Petazzoni
2019-04-11 6:46 ` Giulio Benetti
2019-04-14 21:19 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.