From: Eric Anholt <eric@anholt.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Stephen Boyd <sboyd@codeaurora.org>,
Tom Cooksey <tom.cooksey@arm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/p[111: add CONFIG_OF dependency
Date: Thu, 22 Feb 2018 12:08:08 -0800 [thread overview]
Message-ID: <878tbkaitz.fsf@anholt.net> (raw)
In-Reply-To: <20180222162420.2825703-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Arnd Bergmann <arnd@arndb.de> writes:
> We cannot select a symbol without meeting its other dependencies:
>
> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF)
> drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe':
> drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node'
> vga->bridge.of_node = pdev->dev.of_node;
> ^
>
> Here it seems reasonable to depend on CONFIG_OF, as all platforms
> using this driver already require that anyway.
Looks like we'll be going with
https://patchwork.freedesktop.org/patch/205580/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
Cc: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/p[111: add CONFIG_OF dependency
Date: Thu, 22 Feb 2018 12:08:08 -0800 [thread overview]
Message-ID: <878tbkaitz.fsf@anholt.net> (raw)
In-Reply-To: <20180222162420.2825703-1-arnd@arndb.de>
[-- Attachment #1.1: Type: text/plain, Size: 670 bytes --]
Arnd Bergmann <arnd@arndb.de> writes:
> We cannot select a symbol without meeting its other dependencies:
>
> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF)
> drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe':
> drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node'
> vga->bridge.of_node = pdev->dev.of_node;
> ^
>
> Here it seems reasonable to depend on CONFIG_OF, as all platforms
> using this driver already require that anyway.
Looks like we'll be going with
https://patchwork.freedesktop.org/patch/205580/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-22 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 16:24 [PATCH] drm/p[111: add CONFIG_OF dependency Arnd Bergmann
2018-02-22 16:24 ` Arnd Bergmann
2018-02-22 20:08 ` Eric Anholt [this message]
2018-02-22 20:08 ` Eric Anholt
2018-02-22 22:54 ` Arnd Bergmann
2018-02-22 22:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tbkaitz.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tom.cooksey@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.