* [PATCH 1/3 v2] net/irda: sh_irda: add missing header
2011-08-11 9:19 ` [PATCH v2] " Kuninori Morimoto
@ 2011-08-11 9:25 ` kuninori.morimoto.gx
2011-08-11 12:53 ` David Miller
2011-08-11 9:26 ` [PATCH 2/3 v2] net/irda: sh_sir: " kuninori.morimoto.gx
2011-08-11 9:26 ` [PATCH 3/3] net/irda: sh_sir: tidyup compile warning kuninori.morimoto.gx
2 siblings, 1 reply; 9+ messages in thread
From: kuninori.morimoto.gx @ 2011-08-11 9:25 UTC (permalink / raw)
To: David Miller; +Cc: Kuninori Morimoto, netdev
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
This patch fixup below build error on sh_irda
sh_irda.c: In function 'sh_irda_write':
sh_irda.c:174: error: implicit declaration of function 'iowrite16'
sh_irda.c: In function 'sh_irda_read':
sh_irda.c:184: error: implicit declaration of function 'ioread16'
sh_irda.c: At top level:
sh_irda.c:492: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_irda_irq'
sh_irda.c: In function 'sh_irda_probe':
sh_irda.c:776: error: implicit declaration of function 'ioremap_nocache'
sh_irda.c:776: warning: assignment makes pointer from integer without a cast
sh_irda.c:811: error: implicit declaration of function 'request_irq'
sh_irda.c:811: error: 'sh_irda_irq' undeclared (first use in this function)
sh_irda.c:811: error: (Each undeclared identifier is reported only once
sh_irda.c:811: error: for each function it appears in.)
sh_irda.c:811: error: 'IRQF_DISABLED' undeclared (first use in this function)
sh_irda.c:825: error: implicit declaration of function 'iounmap'
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- just add missing header
- change email subject
drivers/net/irda/sh_irda.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/irda/sh_irda.c b/drivers/net/irda/sh_irda.c
index 4488bd5..8266067 100644
--- a/drivers/net/irda/sh_irda.c
+++ b/drivers/net/irda/sh_irda.c
@@ -22,6 +22,8 @@
* - DMA transfer support
* - FIFO mode support
*/
+#include <linux/io.h>
+#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/clk.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3 v2] net/irda: sh_irda: add missing header
2011-08-11 9:25 ` [PATCH 1/3 v2] net/irda: sh_irda: add missing header kuninori.morimoto.gx
@ 2011-08-11 12:53 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2011-08-11 12:53 UTC (permalink / raw)
To: kuninori.morimoto.gx; +Cc: kuninori.morimoto.gx, netdev
From: kuninori.morimoto.gx@gmail.com
Date: Thu, 11 Aug 2011 02:25:42 -0700 (PDT)
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch fixup below build error on sh_irda
>
> sh_irda.c: In function 'sh_irda_write':
> sh_irda.c:174: error: implicit declaration of function 'iowrite16'
> sh_irda.c: In function 'sh_irda_read':
> sh_irda.c:184: error: implicit declaration of function 'ioread16'
> sh_irda.c: At top level:
> sh_irda.c:492: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_irda_irq'
> sh_irda.c: In function 'sh_irda_probe':
> sh_irda.c:776: error: implicit declaration of function 'ioremap_nocache'
> sh_irda.c:776: warning: assignment makes pointer from integer without a cast
> sh_irda.c:811: error: implicit declaration of function 'request_irq'
> sh_irda.c:811: error: 'sh_irda_irq' undeclared (first use in this function)
> sh_irda.c:811: error: (Each undeclared identifier is reported only once
> sh_irda.c:811: error: for each function it appears in.)
> sh_irda.c:811: error: 'IRQF_DISABLED' undeclared (first use in this function)
> sh_irda.c:825: error: implicit declaration of function 'iounmap'
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3 v2] net/irda: sh_sir: add missing header
2011-08-11 9:19 ` [PATCH v2] " Kuninori Morimoto
2011-08-11 9:25 ` [PATCH 1/3 v2] net/irda: sh_irda: add missing header kuninori.morimoto.gx
@ 2011-08-11 9:26 ` kuninori.morimoto.gx
2011-08-11 12:53 ` David Miller
2011-08-11 9:26 ` [PATCH 3/3] net/irda: sh_sir: tidyup compile warning kuninori.morimoto.gx
2 siblings, 1 reply; 9+ messages in thread
From: kuninori.morimoto.gx @ 2011-08-11 9:26 UTC (permalink / raw)
To: David Miller; +Cc: Kuninori Morimoto, netdev
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
This patch fixup below build error on sh_sir
sh_sir.c: In function 'sh_sir_write':
sh_sir.c:127:2: error: implicit declaration of function 'iowrite16'
sh_sir.c: In function 'sh_sir_read':
sh_sir.c:132:2: error: implicit declaration of function 'ioread16'
sh_sir.c: At top level:
sh_sir.c:561:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_sir_irq'
sh_sir.c: In function 'sh_sir_probe':
sh_sir.c:727:2: error: implicit declaration of function 'ioremap_nocache'
sh_sir.c:727:16: warning: assignment makes pointer from integer without a cast
sh_sir.c:762:2: error: implicit declaration of function 'request_irq'
sh_sir.c:762:23: error: 'sh_sir_irq' undeclared (first use in this function)
sh_sir.c:762:23: note: each undeclared identifier is reported only once for each function it appears in
sh_sir.c:762:35: error: 'IRQF_DISABLED' undeclared (first use in this function)
sh_sir.c:776:2: error: implicit declaration of function 'iounmap'
sh_sir.c: At top level:
sh_sir.c:436:13: warning: 'sh_sir_clear_all_err' defined but not used
sh_sir.c:474:12: warning: 'sh_sir_is_which_phase' defined but not used
sh_sir.c:490:13: warning: 'sh_sir_tx' defined but not used
sh_sir.c:540:13: warning: 'sh_sir_rx' defined but not used
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- just add missing header
- change email subject
drivers/net/irda/sh_sir.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 52a7c86..10b13ea 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -12,6 +12,8 @@
* published by the Free Software Foundation.
*/
+#include <linux/io.h>
+#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3 v2] net/irda: sh_sir: add missing header
2011-08-11 9:26 ` [PATCH 2/3 v2] net/irda: sh_sir: " kuninori.morimoto.gx
@ 2011-08-11 12:53 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2011-08-11 12:53 UTC (permalink / raw)
To: kuninori.morimoto.gx; +Cc: kuninori.morimoto.gx, netdev
From: kuninori.morimoto.gx@gmail.com
Date: Thu, 11 Aug 2011 02:26:09 -0700 (PDT)
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch fixup below build error on sh_sir
>
> sh_sir.c: In function 'sh_sir_write':
> sh_sir.c:127:2: error: implicit declaration of function 'iowrite16'
> sh_sir.c: In function 'sh_sir_read':
> sh_sir.c:132:2: error: implicit declaration of function 'ioread16'
> sh_sir.c: At top level:
> sh_sir.c:561:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sh_sir_irq'
> sh_sir.c: In function 'sh_sir_probe':
> sh_sir.c:727:2: error: implicit declaration of function 'ioremap_nocache'
> sh_sir.c:727:16: warning: assignment makes pointer from integer without a cast
> sh_sir.c:762:2: error: implicit declaration of function 'request_irq'
> sh_sir.c:762:23: error: 'sh_sir_irq' undeclared (first use in this function)
> sh_sir.c:762:23: note: each undeclared identifier is reported only once for each function it appears in
> sh_sir.c:762:35: error: 'IRQF_DISABLED' undeclared (first use in this function)
> sh_sir.c:776:2: error: implicit declaration of function 'iounmap'
> sh_sir.c: At top level:
> sh_sir.c:436:13: warning: 'sh_sir_clear_all_err' defined but not used
> sh_sir.c:474:12: warning: 'sh_sir_is_which_phase' defined but not used
> sh_sir.c:490:13: warning: 'sh_sir_tx' defined but not used
> sh_sir.c:540:13: warning: 'sh_sir_rx' defined but not used
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] net/irda: sh_sir: tidyup compile warning
2011-08-11 9:19 ` [PATCH v2] " Kuninori Morimoto
2011-08-11 9:25 ` [PATCH 1/3 v2] net/irda: sh_irda: add missing header kuninori.morimoto.gx
2011-08-11 9:26 ` [PATCH 2/3 v2] net/irda: sh_sir: " kuninori.morimoto.gx
@ 2011-08-11 9:26 ` kuninori.morimoto.gx
2011-08-11 12:54 ` David Miller
2 siblings, 1 reply; 9+ messages in thread
From: kuninori.morimoto.gx @ 2011-08-11 9:26 UTC (permalink / raw)
To: David Miller; +Cc: Kuninori Morimoto, netdev
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
This patch tidyup below warning
${LINUX}/drivers/net/irda/sh_sir.c:514:6: warning:
'val' may be used uninitialized in this function
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/net/irda/sh_sir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 10b13ea..ed7d7d6 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -513,7 +513,7 @@ static void sh_sir_tx(struct sh_sir_self *self, int phase)
static int sh_sir_read_data(struct sh_sir_self *self)
{
- u16 val;
+ u16 val = 0;
int timeout = 1024;
while (timeout--) {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 9+ messages in thread