[PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt

[PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt

[Jon Hunter]

Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the
Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This
is breaking a PCIe sanity test that we are running on Tegra124 Jetson
TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which
is no longer found. Although we could update the test to fix this, at
the same time it does not seem necessary to rename the interrupt.
Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.

Fixes: 973a28677e39 ("PCI: tegra: Convert to MSI domains")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/pci/controller/pci-tegra.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index eaba7b2fab4a..32ca16c87092 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
 }
 
 static struct irq_chip tegra_msi_top_chip = {
-	.name		= "tegra PCIe MSI",
+	.name		= "Tegra PCIe MSI",
 	.irq_ack	= tegra_msi_top_irq_ack,
 	.irq_mask	= tegra_msi_top_irq_mask,
 	.irq_unmask	= tegra_msi_top_irq_unmask,
-- 
2.25.1

Re: [PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt

[Marc Zyngier]

On Tue, 20 Apr 2021 13:55:45 +0100,
Jon Hunter <jonathanh@nvidia.com> wrote:
> 
> Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the
> Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This
> is breaking a PCIe sanity test that we are running on Tegra124 Jetson
> TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which
> is no longer found. Although we could update the test to fix this, at
> the same time it does not seem necessary to rename the interrupt.
> Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.
> 
> Fixes: 973a28677e39 ("PCI: tegra: Convert to MSI domains")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/pci/controller/pci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index eaba7b2fab4a..32ca16c87092 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
>  }
>  
>  static struct irq_chip tegra_msi_top_chip = {
> -	.name		= "tegra PCIe MSI",
> +	.name		= "Tegra PCIe MSI",
>  	.irq_ack	= tegra_msi_top_irq_ack,
>  	.irq_mask	= tegra_msi_top_irq_mask,
>  	.irq_unmask	= tegra_msi_top_irq_unmask,

Ah, apologies for the spurious renaming. I always wondered if
userspace would actually be parsing this, and it turns out that it is
indeed the case.

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH] PCI: tegra: Don't rename the Tegra MSI interrupt

[Lorenzo Pieralisi]

On Tue, Apr 20, 2021 at 01:55:45PM +0100, Jon Hunter wrote:
> Commit 973a28677e39 ("PCI: tegra: Convert to MSI domains") renamed the
> Tegra PCIe MSI interrupt from 'Tegra PCIe MSI' to 'tegra PCIe MSI'. This
> is breaking a PCIe sanity test that we are running on Tegra124 Jetson
> TK1 because it is looking for an interrupt called 'Tegra PCIe MSI' which
> is no longer found. Although we could update the test to fix this, at
> the same time it does not seem necessary to rename the interrupt.
> Therefore, change the name of the interrupt back to 'Tegra PCIe MSI'.
> 
> Fixes: 973a28677e39 ("PCI: tegra: Convert to MSI domains")
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/pci/controller/pci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Squashed with the Fixes: commit in my pci/msi branch, pushed out.

Thanks,
Lorenzo

> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index eaba7b2fab4a..32ca16c87092 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -1593,7 +1593,7 @@ static void tegra_msi_top_irq_unmask(struct irq_data *d)
>  }
>  
>  static struct irq_chip tegra_msi_top_chip = {
> -	.name		= "tegra PCIe MSI",
> +	.name		= "Tegra PCIe MSI",
>  	.irq_ack	= tegra_msi_top_irq_ack,
>  	.irq_mask	= tegra_msi_top_irq_mask,
>  	.irq_unmask	= tegra_msi_top_irq_unmask,
> -- 
> 2.25.1
>