All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, Bhagath Singh Karunakaran <bhagath@kalycito.com>
Subject: Re: [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus
Date: Thu, 04 Apr 2019 18:32:16 -0700	[thread overview]
Message-ID: <87bm1lck4f.fsf@intel.com> (raw)
In-Reply-To: <461c66428b411644e78ad5a9a44c47442c9b6edf.camel@intel.com>

Hi Jeff,

Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:

> A module parameter maybe fine for our out-of-tree driver, but not for the
> kernel driver.
>
> NACK on the basis that a new module parameter is being introduced for the
> driver.  This is not acceptable by Dave Miller or myself.  As of now, I do
> not have a alternative solution to propose unfortunately.

I understand completely. This patch already served its purpose :-)

>
> I will discuss the issue with my fellow developers and hopefully we can
> come up with a kernel interface that all drivers can use to handle this
> issue.

Thank you.

If it helps, the only other alternative I can think of is a sysctl knob,
something like:

net.core.netdev_max_num_queues

And the default value would be the number of cpus.

Cheers,
--
Vinicius

WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus
Date: Thu, 04 Apr 2019 18:32:16 -0700	[thread overview]
Message-ID: <87bm1lck4f.fsf@intel.com> (raw)
In-Reply-To: <461c66428b411644e78ad5a9a44c47442c9b6edf.camel@intel.com>

Hi Jeff,

Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:

> A module parameter maybe fine for our out-of-tree driver, but not for the
> kernel driver.
>
> NACK on the basis that a new module parameter is being introduced for the
> driver.  This is not acceptable by Dave Miller or myself.  As of now, I do
> not have a alternative solution to propose unfortunately.

I understand completely. This patch already served its purpose :-)

>
> I will discuss the issue with my fellow developers and hopefully we can
> come up with a kernel interface that all drivers can use to handle this
> issue.

Thank you.

If it helps, the only other alternative I can think of is a sysctl knob,
something like:

net.core.netdev_max_num_queues

And the default value would be the number of cpus.

Cheers,
--
Vinicius

  reply	other threads:[~2019-04-05  1:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 21:56 [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus Vinicius Costa Gomes
2019-04-04 21:56 ` [Intel-wired-lan] " Vinicius Costa Gomes
2019-04-05  0:04 ` Jeff Kirsher
2019-04-05  0:04   ` [Intel-wired-lan] " Jeff Kirsher
2019-04-05  1:32   ` Vinicius Costa Gomes [this message]
2019-04-05  1:32     ` Vinicius Costa Gomes
2019-04-18 20:57   ` Vinicius Costa Gomes
2019-04-18 20:57     ` [Intel-wired-lan] " Vinicius Costa Gomes
2019-04-18 21:28     ` Alexander Duyck
2019-04-18 21:28       ` Alexander Duyck
2019-04-18 22:40       ` Vinicius Costa Gomes
2019-04-18 22:40         ` Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm1lck4f.fsf@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=bhagath@kalycito.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.