All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
	Netdev <netdev@vger.kernel.org>,
	Bhagath Singh Karunakaran <bhagath@kalycito.com>
Subject: Re: [Intel-wired-lan] [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus
Date: Thu, 18 Apr 2019 14:28:49 -0700	[thread overview]
Message-ID: <CAKgT0Ud1WkN9OT4ftwzry8Wf2Qwr3h=SwVrsRc9zu_BEg3w0_w@mail.gmail.com> (raw)
In-Reply-To: <87d0ljhw09.fsf@intel.com>

On Thu, Apr 18, 2019 at 1:57 PM Vinicius Costa Gomes
<vinicius.gomes@intel.com> wrote:
>
> Hi Jeff,
>
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:
>
> > I will discuss the issue with my fellow developers and hopefully we can
> > come up with a kernel interface that all drivers can use to handle this
> > issue.
>
> Did you have the chance to discuss this issue?
>
>
> Cheers,
> --
> Vinicius

Is there any reason why you couldn't just use the "ethtool -L" command
to change the number of queues after creating the interface instead of
having to use a module parameter? Just wondering since that would be a
way to change the number of queues, and it should support values
greater than the number of CPUs if I am not mistaken.

Thanks.

- Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <alexander.duyck@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus
Date: Thu, 18 Apr 2019 14:28:49 -0700	[thread overview]
Message-ID: <CAKgT0Ud1WkN9OT4ftwzry8Wf2Qwr3h=SwVrsRc9zu_BEg3w0_w@mail.gmail.com> (raw)
In-Reply-To: <87d0ljhw09.fsf@intel.com>

On Thu, Apr 18, 2019 at 1:57 PM Vinicius Costa Gomes
<vinicius.gomes@intel.com> wrote:
>
> Hi Jeff,
>
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:
>
> > I will discuss the issue with my fellow developers and hopefully we can
> > come up with a kernel interface that all drivers can use to handle this
> > issue.
>
> Did you have the chance to discuss this issue?
>
>
> Cheers,
> --
> Vinicius

Is there any reason why you couldn't just use the "ethtool -L" command
to change the number of queues after creating the interface instead of
having to use a module parameter? Just wondering since that would be a
way to change the number of queues, and it should support values
greater than the number of CPUs if I am not mistaken.

Thanks.

- Alex

  reply	other threads:[~2019-04-18 21:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 21:56 [next-queue PATCH v1] igb: Fix limiting the number of queues to number of cpus Vinicius Costa Gomes
2019-04-04 21:56 ` [Intel-wired-lan] " Vinicius Costa Gomes
2019-04-05  0:04 ` Jeff Kirsher
2019-04-05  0:04   ` [Intel-wired-lan] " Jeff Kirsher
2019-04-05  1:32   ` Vinicius Costa Gomes
2019-04-05  1:32     ` [Intel-wired-lan] " Vinicius Costa Gomes
2019-04-18 20:57   ` Vinicius Costa Gomes
2019-04-18 20:57     ` [Intel-wired-lan] " Vinicius Costa Gomes
2019-04-18 21:28     ` Alexander Duyck [this message]
2019-04-18 21:28       ` Alexander Duyck
2019-04-18 22:40       ` Vinicius Costa Gomes
2019-04-18 22:40         ` Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKgT0Ud1WkN9OT4ftwzry8Wf2Qwr3h=SwVrsRc9zu_BEg3w0_w@mail.gmail.com' \
    --to=alexander.duyck@gmail.com \
    --cc=bhagath@kalycito.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.