All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Stephen Warren <swarren@wwwdotorg.org>,
	Lee Jones <lee@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts
Date: Fri, 28 Oct 2016 08:52:08 -0700	[thread overview]
Message-ID: <87bmy4qxnb.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1610281257230.4896@nanos>

Thomas Gleixner <tglx@linutronix.de> writes:

> On Thu, 27 Oct 2016, Eric Anholt wrote:
>
>> From: Phil Elwell <phil@raspberrypi.org>
>> 
>> The old arch-specific IRQ macros included a dsb to ensure the
>> write to clear the mailbox interrupt completed before returning
>> from the interrupt. The BCM2836 irqchip driver needs the same
>> precaution to avoid spurious interrupts.
>
> This is missing a fixes tag. I have no idea when that problem was
> introduced, so I have no way to decide whether this needs to be tagged
> stable or not.

This code has been there since introduction of the driver, so:

Fixes: 1a15aaa998dc ("irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2")

WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts
Date: Fri, 28 Oct 2016 08:52:08 -0700	[thread overview]
Message-ID: <87bmy4qxnb.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1610281257230.4896@nanos>

Thomas Gleixner <tglx@linutronix.de> writes:

> On Thu, 27 Oct 2016, Eric Anholt wrote:
>
>> From: Phil Elwell <phil@raspberrypi.org>
>> 
>> The old arch-specific IRQ macros included a dsb to ensure the
>> write to clear the mailbox interrupt completed before returning
>> from the interrupt. The BCM2836 irqchip driver needs the same
>> precaution to avoid spurious interrupts.
>
> This is missing a fixes tag. I have no idea when that problem was
> introduced, so I have no way to decide whether this needs to be tagged
> stable or not.

This code has been there since introduction of the driver, so:

Fixes: 1a15aaa998dc ("irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2")

  reply	other threads:[~2016-10-28 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 18:20 [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Eric Anholt
2016-10-27 18:20 ` Eric Anholt
2016-10-28 11:00 ` Thomas Gleixner
2016-10-28 11:00   ` Thomas Gleixner
2016-10-28 15:52   ` Eric Anholt [this message]
2016-10-28 15:52     ` Eric Anholt
2016-10-28 19:55     ` Thomas Gleixner
2016-10-28 19:55       ` Thomas Gleixner
2016-10-31 17:58       ` Eric Anholt
2016-10-31 17:58         ` Eric Anholt
2016-10-31 18:16         ` Thomas Gleixner
2016-10-31 18:16           ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmy4qxnb.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=jason@lakedaemon.net \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=phil@raspberrypi.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.