From: Thomas Gleixner <tglx@linutronix.de> To: Eric Anholt <eric@anholt.net> Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren <swarren@wwwdotorg.org>, Lee Jones <lee@kernel.org>, bcm-kernel-feedback-list@broadcom.com, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, Phil Elwell <phil@raspberrypi.org> Subject: Re: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Date: Fri, 28 Oct 2016 13:00:22 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1610281257230.4896@nanos> (raw) In-Reply-To: <20161027182038.11312-1-eric@anholt.net> On Thu, 27 Oct 2016, Eric Anholt wrote: > From: Phil Elwell <phil@raspberrypi.org> > > The old arch-specific IRQ macros included a dsb to ensure the > write to clear the mailbox interrupt completed before returning > from the interrupt. The BCM2836 irqchip driver needs the same > precaution to avoid spurious interrupts. This is missing a fixes tag. I have no idea when that problem was introduced, so I have no way to decide whether this needs to be tagged stable or not. Thanks, tglx > > Signed-off-by: Phil Elwell <phil@raspberrypi.org> > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > drivers/irqchip/irq-bcm2836.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > index d96b2c947e74..93e3f7660c42 100644 > --- a/drivers/irqchip/irq-bcm2836.c > +++ b/drivers/irqchip/irq-bcm2836.c > @@ -175,6 +175,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs) > u32 ipi = ffs(mbox_val) - 1; > > writel(1 << ipi, mailbox0); > + dsb(sy); > handle_IPI(ipi, regs); > #endif > } else if (stat) { > -- > 2.9.3 > >
WARNING: multiple messages have this Message-ID (diff)
From: tglx@linutronix.de (Thomas Gleixner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Date: Fri, 28 Oct 2016 13:00:22 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1610281257230.4896@nanos> (raw) In-Reply-To: <20161027182038.11312-1-eric@anholt.net> On Thu, 27 Oct 2016, Eric Anholt wrote: > From: Phil Elwell <phil@raspberrypi.org> > > The old arch-specific IRQ macros included a dsb to ensure the > write to clear the mailbox interrupt completed before returning > from the interrupt. The BCM2836 irqchip driver needs the same > precaution to avoid spurious interrupts. This is missing a fixes tag. I have no idea when that problem was introduced, so I have no way to decide whether this needs to be tagged stable or not. Thanks, tglx > > Signed-off-by: Phil Elwell <phil@raspberrypi.org> > Signed-off-by: Eric Anholt <eric@anholt.net> > --- > drivers/irqchip/irq-bcm2836.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > index d96b2c947e74..93e3f7660c42 100644 > --- a/drivers/irqchip/irq-bcm2836.c > +++ b/drivers/irqchip/irq-bcm2836.c > @@ -175,6 +175,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs) > u32 ipi = ffs(mbox_val) - 1; > > writel(1 << ipi, mailbox0); > + dsb(sy); > handle_IPI(ipi, regs); > #endif > } else if (stat) { > -- > 2.9.3 > >
next prev parent reply other threads:[~2016-10-28 11:02 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-27 18:20 [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Eric Anholt 2016-10-27 18:20 ` Eric Anholt 2016-10-28 11:00 ` Thomas Gleixner [this message] 2016-10-28 11:00 ` Thomas Gleixner 2016-10-28 15:52 ` Eric Anholt 2016-10-28 15:52 ` Eric Anholt 2016-10-28 19:55 ` Thomas Gleixner 2016-10-28 19:55 ` Thomas Gleixner 2016-10-31 17:58 ` Eric Anholt 2016-10-31 17:58 ` Eric Anholt 2016-10-31 18:16 ` Thomas Gleixner 2016-10-31 18:16 ` Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.20.1610281257230.4896@nanos \ --to=tglx@linutronix.de \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=eric@anholt.net \ --cc=jason@lakedaemon.net \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=phil@raspberrypi.org \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.