All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node.
@ 2016-06-24 13:31 ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 13:31 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, plagnioj, robh+dt, pawel.moll,
	mark.rutland, ijc+devicetree, galak, linux, linux-arm-kernel,
	devicetree, linux-kernel
  Cc: Raashid Muhammed

Add missing pinctrl information to ethernet node.

Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index 349a461..be409f2 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -49,6 +49,7 @@
 			};
 
 			macb0: ethernet@fffc4000 {
+				pinctrl-0 = <&pinctrl_macb_rmii &pinctrl_macb_rmii_mii_alt>;
 				phy-mode = "mii";
 				#address-cells = <1>;
 				#size-cells = <0>;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node.
@ 2016-06-24 13:31 ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 13:31 UTC (permalink / raw)
  To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
	alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
	plagnioj-sclMFOaUSTBWk0Htik3J/w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
	galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Raashid Muhammed

Add missing pinctrl information to ethernet node.

Signed-off-by: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Vijay Kumar B. <vijaykumar-NDm7FNP0skFg9hUCZPvPmw@public.gmane.org>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index 349a461..be409f2 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -49,6 +49,7 @@
 			};
 
 			macb0: ethernet@fffc4000 {
+				pinctrl-0 = <&pinctrl_macb_rmii &pinctrl_macb_rmii_mii_alt>;
 				phy-mode = "mii";
 				#address-cells = <1>;
 				#size-cells = <0>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node.
@ 2016-06-24 13:31 ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 13:31 UTC (permalink / raw)
  To: linux-arm-kernel

Add missing pinctrl information to ethernet node.

Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index 349a461..be409f2 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -49,6 +49,7 @@
 			};
 
 			macb0: ethernet at fffc4000 {
+				pinctrl-0 = <&pinctrl_macb_rmii &pinctrl_macb_rmii_mii_alt>;
 				phy-mode = "mii";
 				#address-cells = <1>;
 				#size-cells = <0>;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:31   ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 13:31 UTC (permalink / raw)
  To: nicolas.ferre, alexandre.belloni, plagnioj, robh+dt, pawel.moll,
	mark.rutland, ijc+devicetree, galak, linux, linux-arm-kernel,
	devicetree, linux-kernel
  Cc: Raashid Muhammed

Add power led node and rename status led node.

Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index be409f2..814753a 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -106,11 +106,16 @@
 	leds {
 		compatible = "gpio-leds";
 
-		b0 {
-			label = "b0";
-			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "heartbeat";
+		pwr_led {
+			label = "sam9-l9260:yellow:pwr";
+			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "cpu0";
 		};
 
+		status_led {
+			label = "sam9-l9260:green:status";
+			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "timer";
+		};
 	};
 };
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:31   ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 13:31 UTC (permalink / raw)
  To: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
	alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
	plagnioj-sclMFOaUSTBWk0Htik3J/w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
	galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Raashid Muhammed

Add power led node and rename status led node.

Signed-off-by: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Vijay Kumar B. <vijaykumar-NDm7FNP0skFg9hUCZPvPmw@public.gmane.org>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index be409f2..814753a 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -106,11 +106,16 @@
 	leds {
 		compatible = "gpio-leds";
 
-		b0 {
-			label = "b0";
-			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "heartbeat";
+		pwr_led {
+			label = "sam9-l9260:yellow:pwr";
+			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "cpu0";
 		};
 
+		status_led {
+			label = "sam9-l9260:green:status";
+			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "timer";
+		};
 	};
 };
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:31   ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 13:31 UTC (permalink / raw)
  To: linux-arm-kernel

Add power led node and rename status led node.

Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
---
 arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
index be409f2..814753a 100644
--- a/arch/arm/boot/dts/at91-sam9_l9260.dts
+++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
@@ -106,11 +106,16 @@
 	leds {
 		compatible = "gpio-leds";
 
-		b0 {
-			label = "b0";
-			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
-			linux,default-trigger = "heartbeat";
+		pwr_led {
+			label = "sam9-l9260:yellow:pwr";
+			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "cpu0";
 		};
 
+		status_led {
+			label = "sam9-l9260:green:status";
+			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "timer";
+		};
 	};
 };
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
  2016-06-24 13:31   ` Raashid Muhammed
@ 2016-06-24 13:40     ` Alexandre Belloni
  -1 siblings, 0 replies; 16+ messages in thread
From: Alexandre Belloni @ 2016-06-24 13:40 UTC (permalink / raw)
  To: Raashid Muhammed
  Cc: nicolas.ferre, plagnioj, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, linux-arm-kernel, devicetree,
	linux-kernel

Hi,

On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
> Add power led node and rename status led node.
> 

Well, I'm ok with the change but this does more:

> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
> ---
>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
> index be409f2..814753a 100644
> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
> @@ -106,11 +106,16 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		b0 {
> -			label = "b0";
> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "heartbeat";
> +		pwr_led {
> +			label = "sam9-l9260:yellow:pwr";
> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "cpu0";
>  		};
>  
> +		status_led {
> +			label = "sam9-l9260:green:status";
> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "timer";

This trigger is also switched from heartbeat to timer, is this
intentional?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:40     ` Alexandre Belloni
  0 siblings, 0 replies; 16+ messages in thread
From: Alexandre Belloni @ 2016-06-24 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
> Add power led node and rename status led node.
> 

Well, I'm ok with the change but this does more:

> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
> ---
>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
> index be409f2..814753a 100644
> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
> @@ -106,11 +106,16 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		b0 {
> -			label = "b0";
> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
> -			linux,default-trigger = "heartbeat";
> +		pwr_led {
> +			label = "sam9-l9260:yellow:pwr";
> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> +			linux,default-trigger = "cpu0";
>  		};
>  
> +		status_led {
> +			label = "sam9-l9260:green:status";
> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "timer";

This trigger is also switched from heartbeat to timer, is this
intentional?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:56       ` raashidmuhammed
  0 siblings, 0 replies; 16+ messages in thread
From: raashidmuhammed @ 2016-06-24 13:56 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: nicolas.ferre, plagnioj, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, linux-arm-kernel, devicetree,
	linux-kernel



On 06/24/2016 07:10 PM, Alexandre Belloni wrote:
> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>>   arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>   1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>   	leds {
>>   		compatible = "gpio-leds";
>>   
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>   		};
>>   
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
> This trigger is also switched from heartbeat to timer, is this
> intentional?
>
Yes, that is intentional. I should have included that in the commit message.

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:56       ` raashidmuhammed
  0 siblings, 0 replies; 16+ messages in thread
From: raashidmuhammed @ 2016-06-24 13:56 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w,
	plagnioj-sclMFOaUSTBWk0Htik3J/w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
	galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA



On 06/24/2016 07:10 PM, Alexandre Belloni wrote:
> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed-1MQmoylvZ5VBDgjK7y7TUQ@public.gmane.org>
>> Reviewed-by: Vijay Kumar B. <vijaykumar-NDm7FNP0skFg9hUCZPvPmw@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>   1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>   	leds {
>>   		compatible = "gpio-leds";
>>   
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>   		};
>>   
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
> This trigger is also switched from heartbeat to timer, is this
> intentional?
>
Yes, that is intentional. I should have included that in the commit message.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 13:56       ` raashidmuhammed
  0 siblings, 0 replies; 16+ messages in thread
From: raashidmuhammed @ 2016-06-24 13:56 UTC (permalink / raw)
  To: linux-arm-kernel



On 06/24/2016 07:10 PM, Alexandre Belloni wrote:
> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>>   arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>   1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>   	leds {
>>   		compatible = "gpio-leds";
>>   
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>   		};
>>   
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
> This trigger is also switched from heartbeat to timer, is this
> intentional?
>
Yes, that is intentional. I should have included that in the commit message.

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
  2016-06-24 13:40     ` Alexandre Belloni
  (?)
@ 2016-06-24 14:04       ` Raashid Muhammed
  -1 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 14:04 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Raashid Muhammed, nicolas.ferre, plagnioj, robh+dt, pawel.moll,
	mark.rutland, ijc+devicetree, galak, linux, linux-arm-kernel,
	devicetree, linux-kernel


Alexandre Belloni writes:

> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>  	leds {
>>  		compatible = "gpio-leds";
>>
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>  		};
>>
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
>
> This trigger is also switched from heartbeat to timer, is this
> intentional?

Yes, that is intentional. I should have included that in the commit
message.

--
Sent with my mu4e

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 14:04       ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 14:04 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: mark.rutland, devicetree, pawel.moll, ijc+devicetree,
	nicolas.ferre, linux, linux-kernel, robh+dt, galak, plagnioj,
	Raashid Muhammed, linux-arm-kernel


Alexandre Belloni writes:

> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>  	leds {
>>  		compatible = "gpio-leds";
>>
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>  		};
>>
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
>
> This trigger is also switched from heartbeat to timer, is this
> intentional?

Yes, that is intentional. I should have included that in the commit
message.

--
Sent with my mu4e

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes.
@ 2016-06-24 14:04       ` Raashid Muhammed
  0 siblings, 0 replies; 16+ messages in thread
From: Raashid Muhammed @ 2016-06-24 14:04 UTC (permalink / raw)
  To: linux-arm-kernel


Alexandre Belloni writes:

> Hi,
>
> On 24/06/2016 at 19:01:09 +0530, Raashid Muhammed wrote :
>> Add power led node and rename status led node.
>>
>
> Well, I'm ok with the change but this does more:
>
>> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
>> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
>> ---
>>  arch/arm/boot/dts/at91-sam9_l9260.dts | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sam9_l9260.dts b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> index be409f2..814753a 100644
>> --- a/arch/arm/boot/dts/at91-sam9_l9260.dts
>> +++ b/arch/arm/boot/dts/at91-sam9_l9260.dts
>> @@ -106,11 +106,16 @@
>>  	leds {
>>  		compatible = "gpio-leds";
>>
>> -		b0 {
>> -			label = "b0";
>> -			gpios = <&pioA 6 GPIO_ACTIVE_HIGH>;
>> -			linux,default-trigger = "heartbeat";
>> +		pwr_led {
>> +			label = "sam9-l9260:yellow:pwr";
>> +			gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "cpu0";
>>  		};
>>
>> +		status_led {
>> +			label = "sam9-l9260:green:status";
>> +			gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
>> +			linux,default-trigger = "timer";
>
> This trigger is also switched from heartbeat to timer, is this
> intentional?

Yes, that is intentional. I should have included that in the commit
message.

--
Sent with my mu4e

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node.
  2016-06-24 13:31 ` Raashid Muhammed
@ 2016-07-01 18:47   ` Alexandre Belloni
  -1 siblings, 0 replies; 16+ messages in thread
From: Alexandre Belloni @ 2016-07-01 18:47 UTC (permalink / raw)
  To: Raashid Muhammed
  Cc: nicolas.ferre, plagnioj, robh+dt, pawel.moll, mark.rutland,
	ijc+devicetree, galak, linux, linux-arm-kernel, devicetree,
	linux-kernel

On 24/06/2016 at 19:01:08 +0530, Raashid Muhammed wrote :
> Add missing pinctrl information to ethernet node.
> 
> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
> ---
>  arch/arm/boot/dts/at91-sam9_l9260.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
Both applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node.
@ 2016-07-01 18:47   ` Alexandre Belloni
  0 siblings, 0 replies; 16+ messages in thread
From: Alexandre Belloni @ 2016-07-01 18:47 UTC (permalink / raw)
  To: linux-arm-kernel

On 24/06/2016 at 19:01:08 +0530, Raashid Muhammed wrote :
> Add missing pinctrl information to ethernet node.
> 
> Signed-off-by: Raashid Muhammed <raashidmuhammed@zilogic.com>
> Reviewed-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
> ---
>  arch/arm/boot/dts/at91-sam9_l9260.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
Both applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-07-01 18:47 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-24 13:31 [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node Raashid Muhammed
2016-06-24 13:31 ` Raashid Muhammed
2016-06-24 13:31 ` Raashid Muhammed
2016-06-24 13:31 ` [PATCH 2/2] ARM: dts: at91: Modify information in LED nodes Raashid Muhammed
2016-06-24 13:31   ` Raashid Muhammed
2016-06-24 13:31   ` Raashid Muhammed
2016-06-24 13:40   ` Alexandre Belloni
2016-06-24 13:40     ` Alexandre Belloni
2016-06-24 13:56     ` raashidmuhammed
2016-06-24 13:56       ` raashidmuhammed
2016-06-24 13:56       ` raashidmuhammed
2016-06-24 14:04     ` Raashid Muhammed
2016-06-24 14:04       ` Raashid Muhammed
2016-06-24 14:04       ` Raashid Muhammed
2016-07-01 18:47 ` [PATCH 1/2] ARM: dts: at91: Add pinctrl information to ethernet node Alexandre Belloni
2016-07-01 18:47   ` Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.